From: Henning Schild <henning.schild@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH] isar-bootstrap: Remove unwanted sudo calls
Date: Fri, 31 Jan 2020 01:55:11 +0100 [thread overview]
Message-ID: <20200131015511.6d9a2faf@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20200128213603.knzef2o4t3hu27d7@yssyq.m.ilbers.de>
Merging such low-hanging fruits now causes issues easily rebasing other
pending changes. What is the order we can agree on? My take would be,
first come first serve.
I have got feedback on my long base-apt q, but this merge is not the
only preventing a smooth rebase+rework.
Not happy about that extra work.
Henning
On Tue, 28 Jan 2020 22:36:03 +0100
Baurzhan Ismagulov <ibr@radix50.net> wrote:
> On Tue, Dec 24, 2019 at 10:34:12AM +0530,
> vijaikumar.kanagarajan@gmail.com wrote:
> > Remove unwanted sudo calls inside
> > |sudo -E -s <<'EOSUDO'
> > |...
> > |EOSUDO
>
> I agree those are superfluous, so I've applied that to next, thanks.
>
> That said, I'd personally go the opposite way, prepending every
> command with sudo, to prevent a non-sudo command from being inserted
> in the middle of the sudo block.
>
> With kind regards,
> Baurzhan.
>
next prev parent reply other threads:[~2020-01-31 0:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 5:04 vijaikumar.kanagarajan
2020-01-28 21:36 ` Baurzhan Ismagulov
2020-01-31 0:55 ` Henning Schild [this message]
2020-03-10 15:44 ` Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131015511.6d9a2faf@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox