From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6773867203010756608 X-Received: by 2002:adf:fc4b:: with SMTP id e11mr8779321wrs.326.1580432115925; Thu, 30 Jan 2020 16:55:15 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:d847:: with SMTP id k7ls2876571wrl.0.gmail; Thu, 30 Jan 2020 16:55:15 -0800 (PST) X-Google-Smtp-Source: APXvYqwwKTzqqYlIGdhrg2LwI2C3osqm4zLyvDcekk6b4LvFt02xweeLKumcaZXpXkkvbt77k/8J X-Received: by 2002:adf:de86:: with SMTP id w6mr8837738wrl.115.1580432115130; Thu, 30 Jan 2020 16:55:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580432115; cv=none; d=google.com; s=arc-20160816; b=Q6xvCTGn8yFBy6XvVHfl6DWhDtyR31P4Zy6MqWvjyBH6/MMdSTyO8Z+H571VNhjTaW WKKx7OEAGVcnYJjKWhHY0g3XfFAAgOgMBYX4jEQJbEtf21pack5E2Uao3ftH4Vf145i4 VZpK7plkRfiXlBOqBExxWr01Tv6Zk4IodRZNxlpXY1LaaWT5whZH4YtX81IyGEvdj2Wc Yu6C0guInY9WSn4cr1dps+/BL9ap8XpbAAapfbkmnWoIdgRsEIomwrwZsgiamLk2MNDB EEUU5F5TnicD2LwoeL0eqsne/+bVSOIJXg2E8cL9mKU6xSEcraNSkZ6iRmgQnnwTjgtP PSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=a18qTtYCVcf7qyAjx7LF8UCzz8VE/uV9PXTN3/W7frM=; b=kbwn081tzwI2Yi+dPE9BYFZrzkp+bL9pJEDIj/YkYc7v5/hzbgqfsuq4EPYLAKgOMZ +rtYq2qIiVazpRR5FoLiDjqidKFS6lHCoMs1blDEsoHlOxereJJ6GF5xYSyyscWe9Men XqSjHshsgWN8Jsj2Rf1PYBJGNCXX24plNcjsV/IRRyc4XpsapArIaQnP9CuwaN25XYaB KtG1nwzeqSXcTOUtXVLX0anAPnWKQVAXvIzebJMjo8um/npB+yOiMehFylsPObSRTOs8 ZGtdv8ZPHC9+WDYD11lE74j9E2uxxqljGmQTy+Jcjx+hj3rEc5R+CS4X+mMbpcd3sbeb LHLA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id e21si509864wme.1.2020.01.30.16.55.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jan 2020 16:55:15 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 00V0tEYQ011049 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jan 2020 01:55:14 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.0.239]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 00V0tEfo010286; Fri, 31 Jan 2020 01:55:14 +0100 Date: Fri, 31 Jan 2020 01:55:11 +0100 From: Henning Schild To: Baurzhan Ismagulov Cc: Subject: Re: [PATCH] isar-bootstrap: Remove unwanted sudo calls Message-ID: <20200131015511.6d9a2faf@md1za8fc.ad001.siemens.net> In-Reply-To: <20200128213603.knzef2o4t3hu27d7@yssyq.m.ilbers.de> References: <20191224050412.17234-1-Vijaikumar_Kangarajan@mentor.com> <20200128213603.knzef2o4t3hu27d7@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: vQo4RNAZK5qY Merging such low-hanging fruits now causes issues easily rebasing other pending changes. What is the order we can agree on? My take would be, first come first serve. I have got feedback on my long base-apt q, but this merge is not the only preventing a smooth rebase+rework. Not happy about that extra work. Henning On Tue, 28 Jan 2020 22:36:03 +0100 Baurzhan Ismagulov wrote: > On Tue, Dec 24, 2019 at 10:34:12AM +0530, > vijaikumar.kanagarajan@gmail.com wrote: > > Remove unwanted sudo calls inside > > |sudo -E -s <<'EOSUDO' > > |... > > |EOSUDO > > I agree those are superfluous, so I've applied that to next, thanks. > > That said, I'd personally go the opposite way, prepending every > command with sudo, to prevent a non-sudo command from being inserted > in the middle of the sudo block. > > With kind regards, > Baurzhan. >