From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6771003123014041600 X-Received: by 2002:adf:fc4b:: with SMTP id e11mr11457247wrs.326.1580462851778; Fri, 31 Jan 2020 01:27:31 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:cf15:: with SMTP id l21ls4627208wmg.0.canary-gmail; Fri, 31 Jan 2020 01:27:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyk6WbhZeC2D9T0k5YFxkmKPmZWcX6pEvVsjIWLFbG8gfeYvPMxLAZ6W4d3XirHA/eSG7vq X-Received: by 2002:a1c:4d07:: with SMTP id o7mr11244752wmh.174.1580462851276; Fri, 31 Jan 2020 01:27:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580462851; cv=none; d=google.com; s=arc-20160816; b=pSi6kzrQIUdyklwmkRp4fDYYEJVrcQXpEwVx7lYpmv7GMwDcFovltBDZjXKlteGryi 0ZLIGAp/f3f4A1n5t+YHnyvhBTVflelY1iyQIFsu/cgrUyDfZNoU7laPKwGUzhgDrQjZ 0+oOUTR9kf+A7+4ep9072Z7IF8tDO1nZsnEVCSCj6+UDQf7Tj5jszqQxjyIPa7T2FdDG kNEh2jc20CO6GQqBZb6+Kcfa1cAl9TV6cJPIDNtlWIZJQwSfUrL21virvwsjVDaNN9Ui RP8OjK72eHZKpq2uOSXSp5WAcsg0lkQXls5BSqSgBxJCn1t8ZNfKGBak6QuPuQQon5yq bnSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=FaGPvv31wfQh2O3vQCSP8Ge3UsN/Wq4cWGs94GLwjwk=; b=sO7kSu23mfRB2CQpS/vh/TpW8bEhgVbQaHDBMJaTt2AugHlDVLgdwdgzXtOJ3+ubPl d1eSN9f3lpwqPmdFomS5j6kpXxqB4VHt9skyoaP0iXqjPL1wI3nufB4cIvhcZzj/g96G q8g/a3rx8r6M1YexzpThZPHAYe53cOTbOsgaS/3GZvZCvKbzR/AvuacvZG0qhX4uxR9p ulADzKSmQfoNu2n0r9HhyHQygBbrPuKv8Ieeg7Ikyrf/25NClYoKBB9QUoDJej6N7pRq nWzEX31X66W0gwLhXjXHD03JsP9a/VdFjYrcPLvkEWPlD/QLHpzmSpfXEVIVOxya9HzF UU/g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id u9si362170wri.3.2020.01.31.01.27.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jan 2020 01:27:31 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 00V9RUTi024398 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jan 2020 10:27:30 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.127.49]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 00V9RUaw026887; Fri, 31 Jan 2020 10:27:30 +0100 Date: Fri, 31 Jan 2020 10:27:26 +0100 From: Henning Schild To: Vijai Kumar K Cc: isar-users Subject: Re: [PATCH v3 26/26] meta/recipes-kernel: Export KBUILD_DEPENDS to cache Message-ID: <20200131102726.1471120e@md1za8fc.ad001.siemens.net> In-Reply-To: <20200129052918.GA11866@oxygen> References: <20200128154312.337e61f6@md1za8fc.ad001.siemens.net> <20200128154213.22353-1-vijaikumar.kanagarajan@gmail.com> <20200128154213.22353-27-vijaikumar.kanagarajan@gmail.com> <20200128175235.5645b10d@md1za8fc.ad001.siemens.net> <4f458566-c16e-4af0-9b08-174188b21ef8@googlegroups.com> <20200128222240.3a72eb54@md1za8fc.ad001.siemens.net> <20200129052918.GA11866@oxygen> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: jP3JHUIDPrPd On Wed, 29 Jan 2020 10:59:18 +0530 Vijai Kumar K wrote: > On Tue, Jan 28, 2020 at 10:22:40PM +0100, Henning Schild wrote: > > On Tue, 28 Jan 2020 11:45:18 -0800 > > vijai kumar wrote: > > > > > On Tuesday, January 28, 2020 at 10:22:37 PM UTC+5:30, Henning > > > Schild wrote: > > > > > > > > Thanks. > > > > > > > > On Tue, 28 Jan 2020 21:12:13 +0530 > > > > Vijai Kumar K > wrote: > > > > > > > > > From: Vijai Kumar K > > > > > > > > > > > linux-custom overrides do_dpkg_builddeps with its own > > > > > variant. Since deb-dl-dir* is not called KBUILD_DEPENDS is > > > > > not cached. > > > > > > > > > > Call deb-dl-dir-import/deb-dl-dir-export to cache it. > > > > > > > > > > Signed-off-by: Vijai Kumar K > > > > > --- > > > > > meta/recipes-kernel/linux/linux-custom.inc | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc > > > > > b/meta/recipes-kernel/linux/linux-custom.inc index > > > > > 17f8464..37eb3c2 100644 --- > > > > > a/meta/recipes-kernel/linux/linux-custom.inc +++ > > > > > b/meta/recipes-kernel/linux/linux-custom.inc @@ -41,6 +41,7 @@ > > > > > KERNEL_LIBC_DEV_DEPLOY ?= "0" do_install_builddeps() { > > > > > dpkg_do_mounts > > > > > E="${@ isar_export_proxies(d)}" > > > > > + deb_dl_dir_import "${BUILDCHROOT_DIR}" > > > > > sudo -E chroot ${BUILDCHROOT_DIR} \ > > > > > apt-get update \ > > > > > -o > > > > > Dir::Etc::SourceList="sources.list.d/isar-apt.list" \ @@ -50,6 > > > > > +51,7 @@ do_install_builddeps() { apt-get install \ > > > > > -y -o Debug::pkgProblemResolver=yes > > > > > \ --no-install-recommends > > > > > ${KBUILD_DEPENDS} > > > > > > > > In between here you will have to do the split from p8. > > > > Otherwise if you have post-install hooks to clear the caches > > > > the next statement will copy nothing. > > > > > > > > > > > Ah, I see. Will change that. > > > > It is not likely to have such a hook for the buildchroot but we can > > not rule it out for the image. Let us just follow the pattern for > > the buildchroot as well. > > > > > > > > > I guess it is ok to send just one patch and note that it is > > > > supposed to sit on top of my v2. > > > > > > > > > Sure. > > > > I could fold your improvements into the queue as regular review > > feedback. Or we make it a patch on top to give you credit for > > finding the problem with the custom kernel. > > > > One thing that needs to be done as well, is including a > > custom-kernel build into the ci tests. The rebuild tests not > > covering a custom-kernel is the reason you ran into the issue. If > > you decide to send an update of your patch on top of my patches, > > please make that ci change as well. Otherwise let me know if you > > are ok with me taking the review comment and doing all the required > > changes in a v4. > > No problem. Please go ahead. Turns out that is not needed anymore when basing the patches on current next. I will send an update of the series rebased ... and merged ..., it will also include a CI test for custom kernel in the cached case. Henning > Thanks, > Vijai Kumar K > > > > > In case the maintainer is actually reading all this ... did you have > > any other issues with this queue? I know you are including it into a > > rather complex layer. If that was the only finding a v4 might just > > be ready for a merge. > > > > regards, > > Henning > > > > > Thanks, > > > Vijai Kumar K > > > > > > > > > > > > > > > > > > Henning > > > > > > > > > + deb_dl_dir_export "${BUILDCHROOT_DIR}" > > > > > dpkg_undo_mounts > > > > > } > > > > > > > > > > > > > > > > > >