From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6788114222392803328 X-Received: by 2002:a2e:9b94:: with SMTP id z20mr2919450lji.147.1583845270480; Tue, 10 Mar 2020 06:01:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:686:: with SMTP id t6ls1814079lfe.3.gmail; Tue, 10 Mar 2020 06:01:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv/nVdU/4KvQh7DCWDdX4UZ1EwH+DDVBq7HvQy/GHUCNoM5xX24pMb5oODSugxiQt9hdU1o X-Received: by 2002:a19:4c08:: with SMTP id z8mr7224735lfa.95.1583845269814; Tue, 10 Mar 2020 06:01:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583845269; cv=none; d=google.com; s=arc-20160816; b=InWv+p+CTgp0w/0zktYHgHyy+5moTyZO5YgxxGqN9DMyTAlphcDaU2YRckGleIC8kU kkQG9VzzccMVP6sSHNlYxg3xPCKzoRPL9Vh/HQ5CpqYw1VIc8gTqpqcWXPsUUw3kSVuV XXaPyWryz3ROkkdVc18ER/4VV2zTy/nvZthNvFVF/896lHF6BsuqeVK62nxOCf2qCCsj 1+x6TGfykH2/wENKqTB3Lz3C4TVeUW+HYG59B7wff/uI6pDnTXXA4xlmUz8NcF7gzzLy IikcpWN6ZKgMvvT7IISW7aH6pzdg2+5nf0eQOcMr1VakZr5AFJZJGl3SR4qCdbTnO8vp A0cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=ETKQ8Xsyq2CcQ2s1RtkAKjZqJib36GskR7lo6VBGjFY=; b=ViPqzBK6kXu1GYuBGe1dJ2P+T+vvpwccyeSdC18VF4R9dv1SIMl1xazA/JF23VT/Jd qKKwbAB8yvcZPDxKYM1jtCmXZs+FkDrmoTNh2fIfugYeuXc3zvdn0S8AdE94CZKm87rz arlQLR9mC15IEkFYswKmc5dKdVXkKjOOEMEt2wY26szjr7z/XXwf9pCmiI/Wqcv76j4F E4k1msYlYtSSf8RSILwns/7a72SifBClpgl0FEPRn6DrdCjivreuW5iG/EF07JWYx8T6 pVK3NieIFWVzv+83uM+m/htuVFMsIK0DHObsxTArrmqjONlgEW5NAlt1TNKehV1Y0veB 4mTw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id j11si575778lfe.4.2020.03.10.06.01.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2020 06:01:09 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 02AD19F1021123 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Mar 2020 14:01:09 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.205]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 02AD19XY016507; Tue, 10 Mar 2020 14:01:09 +0100 Date: Tue, 10 Mar 2020 14:01:08 +0100 From: Henning Schild To: Baurzhan Ismagulov Cc: Subject: Re: [PATCHv4 00/26] base-apt-rework Message-ID: <20200310140108.2072e5b0@md1za8fc.ad001.siemens.net> In-Reply-To: <20200304232537.rdhqt4udjhyadz25@yssyq.m.ilbers.de> References: <20200131143000.14873-1-henning.schild@siemens.com> <20200304232537.rdhqt4udjhyadz25@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Cw0dzU0SaEUI On Thu, 5 Mar 2020 00:25:37 +0100 Baurzhan Ismagulov wrote: > Hello Henning, > > On Fri, Jan 31, 2020 at 03:29:34PM +0100, Henning Schild wrote: > > Rebased/merged onto current next and added p26. The custom kernel > > caching that was missing in v2 is not required on next anymore. > > Thanks for the series. Took some time, since I had CI failures before > the machine was made public, sorry for the delay. > > Two issues: Thanks for the review, i will look into folding those into a v5. I think i will add your signed-offs to the ones you touched as well. > > 1. [PATCHv4 01/26] repository: new class to deal with repos > > On Mon, Nov 25, 2019 at 01:03:50PM +0100, Henning Schild wrote: > > > I suggest to keep modifying distributions.in and avoid > > > hard-coding architectures and components that are specific to > > > the current Debian. > > > > Same comment as before. As far as i know this is not a visible > > interface and was never meant to be changed by i.e. a layer. > > Distributing the code over multiple files, with just one place > > that uses it, is a layer of abstraction that just makes the code > > less readable. > > Adding riscv64 should not require editing a bbclass. Currently, > the code and the configuration are separated. I don't see why we > should break that and suggest to keep it that way. I'll send a > reworked patch. I have a rebased version here, but fair enough, i will proceed with yours. > > 2. [PATCHv4 08/26] meta: split all apt-get invocations into download > and execution > > On Fri, Jan 31, 2020 at 03:29:42PM +0100, Henning Schild wrote: > ... > > diff --git a/meta/recipes-devtools/buildchroot/files/deps.sh > > b/meta/recipes-devtools/buildchroot/files/deps.sh > ... > > +if [ "$3" != "-download-only" ]; then > ... > > +if [ "$3" = "--download-only" ]; then > > In v1, both had two dashes. I assume "--download-only" is the > intended one? Good catch. > > What is your plan regarding "command not found"? > I already have a fix for that since weeks. That showed some weird errors in CI ... sometimes. I have come to the conclusion that those must be the network connectivity of the machine i was on. I hope i will send a v5 today or tomorrow. Henning > With kind regards, > Baurzhan. >