[PATCH] isar-bootstrap: Remove unwanted sudo calls

[PATCH] isar-bootstrap: Remove unwanted sudo calls

[vijaikumar.kanagarajan]

From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>

Remove unwanted sudo calls inside
|sudo -E -s <<'EOSUDO'
|...
|EOSUDO

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index 5dd571e..16b4395 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -270,7 +270,7 @@ isar_bootstrap() {
                     -e "s#{BASE_DISTRO_CODENAME}#"${BASE_DISTRO_CODENAME}"#g" \
 	            -i ${BASEAPTSRCS}
                 mkdir -p ${ROOTFSDIR}/base-apt
-                sudo mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt
+                mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt
                 install -v -m644 "${BASEAPTSRCS}" \
                                  "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list"
             else
@@ -288,7 +288,7 @@ isar_bootstrap() {
             do
                 kfn="$(basename $keyfile)"
                 cp $keyfile "${ROOTFSDIR}/tmp/$kfn"
-                sudo -E chroot "${ROOTFSDIR}" /usr/bin/apt-key \
+                chroot "${ROOTFSDIR}" /usr/bin/apt-key \
                    --keyring ${THIRD_PARTY_APT_KEYRING} add "/tmp/$kfn"
                 rm "${ROOTFSDIR}/tmp/$kfn"
             done
-- 
2.17.1

Re: [PATCH] isar-bootstrap: Remove unwanted sudo calls

[Baurzhan Ismagulov]

On Tue, Dec 24, 2019 at 10:34:12AM +0530, vijaikumar.kanagarajan@gmail.com wrote:
> Remove unwanted sudo calls inside
> |sudo -E -s <<'EOSUDO'
> |...
> |EOSUDO

I agree those are superfluous, so I've applied that to next, thanks.

That said, I'd personally go the opposite way, prepending every command with
sudo, to prevent a non-sudo command from being inserted in the middle of the
sudo block.

With kind regards,
Baurzhan.

Re: [PATCH] isar-bootstrap: Remove unwanted sudo calls

[Henning Schild]

Merging such low-hanging fruits now causes issues easily rebasing other
pending changes. What is the order we can agree on? My take would be,
first come first serve.

I have got feedback on my long base-apt q, but this merge is not the
only preventing a smooth rebase+rework.

Not happy about that extra work.
Henning 

On Tue, 28 Jan 2020 22:36:03 +0100
Baurzhan Ismagulov <ibr@radix50.net> wrote:

> On Tue, Dec 24, 2019 at 10:34:12AM +0530,
> vijaikumar.kanagarajan@gmail.com wrote:
> > Remove unwanted sudo calls inside
> > |sudo -E -s <<'EOSUDO'
> > |...
> > |EOSUDO  
> 
> I agree those are superfluous, so I've applied that to next, thanks.
> 
> That said, I'd personally go the opposite way, prepending every
> command with sudo, to prevent a non-sudo command from being inserted
> in the middle of the sudo block.
> 
> With kind regards,
> Baurzhan.
> 

Re: [PATCH] isar-bootstrap: Remove unwanted sudo calls

[Baurzhan Ismagulov]

Hello Henning,

On Fri, Jan 31, 2020 at 01:55:11AM +0100, Henning Schild wrote:
> Merging such low-hanging fruits now causes issues easily rebasing other
> pending changes. What is the order we can agree on? My take would be,
> first come first serve.
> 
> I have got feedback on my long base-apt q, but this merge is not the
> only preventing a smooth rebase+rework.
> 
> Not happy about that extra work.

Thanks for the feedback. I'll try to consider this if possible, although not as
a hard rule -- e.g., if anything is broken, it makes sense to fix that ASAP.

With kind regards,
Baurzhan.