From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6798458144026525696 X-Received: by 2002:ac2:5b47:: with SMTP id i7mr123282lfp.181.1583878181225; Tue, 10 Mar 2020 15:09:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b5d9:: with SMTP id g25ls2731774ljn.9.gmail; Tue, 10 Mar 2020 15:09:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtQj1mY2TENwlR5Swid5jheIvsCzDHgTyLnyoqSG52KTJB0zR61QPJfXKJJ6JD0pk4BqM1F X-Received: by 2002:a2e:a173:: with SMTP id u19mr214465ljl.20.1583878180600; Tue, 10 Mar 2020 15:09:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583878180; cv=none; d=google.com; s=arc-20160816; b=EbiJ/BtYekmQ+wjkdnWmthgyhRXxE0GT/WV+DOb1D0oRaPfC5z8vtYRglpwrQEpWhC louV0d1TosFxg1w71osSu6eLqqTdGibbFcRuS/aWzfHIQaAJyaqKuxZFILWZdIH4h1FW FvpAUG2LGcfSNwmxp9ub733wd3SeIll7dKC66pn9ys7MdsB+I69maQMYqSJkoGhmZ4r6 wmxcfE+jJ2Iu/yfXz+Ip5Nq9kUMklXFW6Z6Jig3cENkb02v2n7e+5ix2cRKMcHXMxQMq gqegBKVgEnGb+2H2tyat3Dl+UdlQT2oJpfVHV6smuFOBAcSSFaEIEtSsXauxnZwCuW0b K6yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=6f2CbST2X8xfgIx7YwjvPoRAgrz9yd22/PzIqxACBIo=; b=FHWMcT+p/r/otm/OqYe+8PzW5BGB5i/o7b6KxuhjWFreZvzFdjbMvUyZhky3HaLLW0 LdB7a+yhCRU0BPb0+tpwviQOU1s3OnYii6a8+1vuycHkUErmZxhP/T+10nnFIJ0SxNfP MXhRfU7qt4wnnIegAZ2ZN1sB4AI/5LfbIG0di8GthJBOXqUIKL/SwIjgwx+2XEemXemq DJ9ORgGMZEmN/KRgvhSrKg+i4Kufn8j1hHDwhtA0ilqfTGkt+MY4vyEGunEcW7sCdM/V S5ThICFX5YTHJvdVzOclTIYsEaxegR1nRwDDKrqeQ9jCJR51HO7b5442/O9UWXa9y2cj GeNA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id p14si10808lfo.0.2020.03.10.15.09.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2020 15:09:40 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 02AM9dh3024592 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 10 Mar 2020 23:09:39 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.36.172]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 02AM9dmL022903; Tue, 10 Mar 2020 23:09:39 +0100 Date: Tue, 10 Mar 2020 23:09:35 +0100 From: Henning Schild To: "Q. Gylstorff" Cc: Subject: Re: [PATCH v2] isar-bootstrap: Remove apt-transport-https Message-ID: <20200310230935.683dd29d@md1za8fc.ad001.siemens.net> In-Reply-To: <20200310160704.7974-1-Quirin.Gylstorff@siemens.com> References: <20200310150204.0f64916b@md1za8fc.ad001.siemens.net> <20200310160704.7974-1-Quirin.Gylstorff@siemens.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: JRadtLaX3THs On Tue, 10 Mar 2020 17:07:04 +0100 "Q. Gylstorff" wrote: > From: Quirin Gylstorff > > Since apt 1.5 apt-transport-https is part of apt. This > package is no longer needed. For distribution < buster > append the Distro configuration with: > DISTRO_BOOTSTRAP_BASE_PACKAGES_append = ",apt-transport-https" I think that commit comment might be wrong now. > Signed-off-by: Quirin Gylstorff > --- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > 16b4395..1aea973 100644 --- > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -27,7 +27,7 > @@ THIRD_PARTY_APT_KEYFILES = "" DEPLOY_ISAR_BOOTSTRAP ?= "" > DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales" > DISTRO_BOOTSTRAP_BASE_PACKAGES_append_gnupg = ",gnupg" > -DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = > ",apt-transport-https,ca-certificates" > +DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = > "${@https_support(d)}" HOST_DISTRO_APT_SOURCES += > "conf/distro/${HOST_DISTRO}.list" python () { > @@ -161,6 +161,12 @@ def get_distro_primary_source_entry(d, > is_host=False): def get_distro_have_https_source(d, is_host=False): > return any(source[2].startswith("https://") for source in > generate_distro_sources(d, is_host)) > +def https_support(d, is_host=False): > + if get_distro_suite(d, is_host) == "stretch": > + return ",apt-transport-https,ca-certificates" > + else: > + return ",ca-certificates" > + That works, given "stretch" is the only Debian/Raspbian suite that still needs that package. So it is good to merge. I still like the idea of eventually supporting Ubuntu/Mint or other Debian-based distros. Matching on a Debian name would be wrong in that context but is fine here. Can we find the difference based on the version instead of a suite-name? It is not too relevant, but that spot might be hard to find if we ever support other distros. Henning > def get_distro_needs_https_support(d, is_host=False): > if get_distro_have_https_source(d, is_host): > return "https-support"