Re: [PATCH 1/3] sshd-regen-keys: correct dependency on ssh daemon service

[Henning Schild <henning.schild@siemens.com>]

On Wed, 11 Mar 2020 10:32:40 +0100
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> On 11.03.20 09:34, Henning Schild wrote:
> > One fun fact on the version bump here. All our "on first boot"
> > recipes use a trick where the postinst enables them, and their run
> > disables them again.
> > 
> > That pattern is broken in the face of package updates, where the
> > service will be enabled again and we do a second round. Meaning all
> > packages using that pattern need code that can be run multiple
> > times.
> > 
> > In fact the pattern should probably be improved, where the "enable"
> > in postinst becomes conditional if the packages was installed
> > before and the service is already disabled.
> > 
> > Taking Jan in as well, since he established that pattern.  
> 
> Yeah, but without considering a package update case at all. I suppose 
> some other post-inst scripts we have, e.g. in customization packages, 
> are not really upgrade-friendly. Simply wasn't a priority so far, but
> we can always do better of course.

I know the history and a lot of people will not do package updates. At
the same time i suggest to keep that issue in mind and provide a clean
solution for the Isar core.

Henning

> Jan
> 
> > 
> > Henning
> > 
> > On Tue, 10 Mar 2020 17:04:32 +0100
> > Cedric Hombourger <Cedric_Hombourger@mentor.com> wrote:
> >   
> >> The name of the SSH daemon service is ssh.service, not sshd.service
> >> This fixes some (sporadic) failures to generate host-specific ssh
> >> keys on first boot.
> >>
> >> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> >> ---
> >>   .../sshd-regen-keys/files/sshd-regen-keys.service
> >> | 2 +- .../{sshd-regen-keys_0.2.bb => sshd-regen-keys_0.3.bb}
> >>     | 0 2 files changed, 1 insertion(+), 1 deletion(-)
> >>   rename
> >> meta/recipes-support/sshd-regen-keys/{sshd-regen-keys_0.2.bb =>
> >> sshd-regen-keys_0.3.bb} (100%)  
> >>
> >> diff --git
> >> a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service
> >> b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service
> >> index a05e1a9..f50d34c 100644 ---
> >> a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service
> >> +++
> >> b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service
> >> @@ -3,7 +3,7 @@ Description=Regenerate sshd host keys
> >> DefaultDependencies=no Conflicts=shutdown.target
> >> After=systemd-remount-fs.service -Before=shutdown.target
> >> sshd.service +Before=shutdown.target ssh.service
> >> ConditionPathIsReadWrite=/etc 
> >>   [Service]
> >> diff --git
> >> a/meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.2.bb
> >> b/meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.3.bb
> >> similarity index 100% rename from
> >> meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.2.bb rename
> >> to meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.3.bb  
> >   
>