From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6803364431668445184 X-Received: by 2002:adf:b317:: with SMTP id j23mr11981054wrd.413.1584031719302; Thu, 12 Mar 2020 09:48:39 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:4441:: with SMTP id x1ls3271974wrr.4.gmail; Thu, 12 Mar 2020 09:48:38 -0700 (PDT) X-Google-Smtp-Source: ADFU+vugXuV/Xy5DWSfo7H0dlny2agg9Hnr/zPBwS+kyJ0gPo19+lRPjN4wTFKs19xm3pXJ3WFq7 X-Received: by 2002:adf:e447:: with SMTP id t7mr12196318wrm.374.1584031718818; Thu, 12 Mar 2020 09:48:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584031718; cv=none; d=google.com; s=arc-20160816; b=UV05jZ6JrKrspbxQMMF5da4T1cWVdvswHFRK/wc8mHFr00vtiCF8H0yVvdMzFTQmjB qcH3Rn47PzJOcB2NjKLo4jQcWGDItrW+U+dMFY8XlwbY6Wjvyh7A2XDymiaBst1o7Hgb NUFi+Ni5Ny3kcxKEaFDDoylIqkeqv+JDUQ+zGx8AnnhkCLdQ8+uqk7b07ymXqrgP+f5R O9LJ9+U3wCm3gC7NHNX8E8HWnyCboE9O8mTwnfVrQwQQs/M/PLQuH/1dFkfkXaHjExdd rqvQ6U1RT+sOB3SvT0MxMJyjgsJzWng4T7MDv2+wU9G+qGanb6UnwQQRqQOSRSGgznOk MoIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=6TvtPNy9+FhvU24UFw+K5QrV/TKXcduuge0Rcb/4JV0=; b=nUa1jUpAO9KdVUkdfS7U4hafeEmjy8m36BLg1Xlb/30jZWlk0YXTjB4+Wt9N/3Smsd /TUTvX91qUYJ+MNWMvqdwZTwHMndS+36X92V8jUtO4JQOoz+FVibqzFkrDyJjhMFvTcB e9HiJ7SU5WHz/4robaVk78uJtRxfo2DMWhpTkPvYn1vHVnwOSqt9TFdcSOunlCVFKe6b AQ/ObR+Dl6fZZkynoYqTr7PcVrRKHYQvEvmS3V+v/ZDYDT+zqEJ9JeoC55JS1fX3r+uj BGHwLea+ThRid0RR3y4kHdAnXxGGpCzuh3yercmQ/1BXe7kAAQWxO9E6UWjnXpI8kITH sEOw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=Quirin.Gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id l13si298822wrp.2.2020.03.12.09.48.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Mar 2020 09:48:38 -0700 (PDT) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=Quirin.Gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 02CGmcrf030659 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 17:48:38 +0100 Received: from md2dvrtc.ad001.siemens.net ([139.25.68.236]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 02CGmccP012036; Thu, 12 Mar 2020 17:48:38 +0100 From: "Q. Gylstorff" To: isar-users@googlegroups.com, henning.schild@siemens.com, Cedric_Hombourger@mentor.com Cc: Quirin Gylstorff Subject: [PATCH] sshd-regen-keys: fix race condition Date: Thu, 12 Mar 2020 17:48:37 +0100 Message-Id: <20200312164837.20377-1-Quirin.Gylstorff@siemens.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: 2rXq25bDXA6P From: Quirin Gylstorff Systemd waits with starting service until a oneshot is finished this leads to a race condition if you try to restart a service in a oneshot. "Behavior of oneshot is similar to simple; however, the service manager will consider the unit started after the main process exits. It will then start follow-up units. RemainAfterExit= is particularly useful for this type of service. Type=oneshot is the implied default if neither Type= nor ExecStart= are specified."[1] [1]: man systemd.service Signed-off-by: Quirin Gylstorff --- .../sshd-regen-keys/files/sshd-regen-keys.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service index a05e1a9..4c4dc0e 100644 --- a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service +++ b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service @@ -7,7 +7,7 @@ Before=shutdown.target sshd.service ConditionPathIsReadWrite=/etc [Service] -Type=oneshot +Type=simple RemainAfterExit=yes Environment=DEBIAN_FRONTEND=noninteractive ExecStart=/usr/sbin/sshd-regen-keys.sh -- 2.20.1