From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6802611076497145856 X-Received: by 2002:adf:f40f:: with SMTP id g15mr26160139wro.213.1584362377501; Mon, 16 Mar 2020 05:39:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:660a:: with SMTP id a10ls6635128wmc.0.gmail; Mon, 16 Mar 2020 05:39:37 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtcxssEjPSTkRHFe4a1isN8vdGRzESb3PPsUPpsgvS02kxTGmvwc5itAetu2oRwHHCL7I9c X-Received: by 2002:a1c:8097:: with SMTP id b145mr21493118wmd.159.1584362376992; Mon, 16 Mar 2020 05:39:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584362376; cv=none; d=google.com; s=arc-20160816; b=uUjcg4N8shYJnUpuK2cly8AWmcdNBl/JT0EkmBVM49+yPPgtbBx5UavaS07/4wUuwX cF6su54AkpIOb0aoehPtz5tlneBN2wZKX3DfRRJmpXOJwekO8BUT3OWj3rjk2uZ/seA4 XIjdtN8H/Y9EWDNiKWgPfvITcPgIj8Noj2ro+NL4zMYSgxmNZa5WJd6OmTEXlxpUhEUv thEnP5n2EXjXwGVX8/kjXbIRCLBeU85yFk06M3ROVOgjBjJzJ+k2fyNWLOUD4or7YwQg nDfSxxLqvUw6otaa3ZYdkAf8DeIq+i2L332hzIpHIEPVe3zEP8oTquZbkcBm5+HvxwKD YMEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=+wKdD6LNywRFGMTnbD5qMp1+4ghwNgfByI4RCZRCEs8=; b=t+gWeAhULd9/lRo7NWu892TAnrfuTc+v77RJPN7UNug9IejTjeY/sLIrtSWE9Kda66 PQ/rUzKf/fHzmqRUKXU0EysifQOvMDoOD2LQCQI9WRBRB0btVsaYamlYTbeob4RYRomt 3fMtMeMp+4wXFb3Uqn5nbgUDNUkrpyUBcBpSIhDNjzFwleiURs6zpWeshAf6TmhsbPrC y/0ZwhwlWa6qzyz+P7bqlcBkyTsNaWKIX07/AgQ7jMPiGkVscoT77pBwGRXIip9FNMTN ImU19N8bZzs22XQmfvuu5vnudXE6AZ8WLUN5NSrdOu6DUf/7k9uSg1Yb8S+anzQO3X35 yl4g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id n7si952188wmc.1.2020.03.16.05.39.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Mar 2020 05:39:36 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 02GCdaje028322 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2020 13:39:36 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.45.13]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 02GCdaM2024938; Mon, 16 Mar 2020 13:39:36 +0100 Date: Mon, 16 Mar 2020 13:39:34 +0100 From: Henning Schild To: Gylstorff Quirin Cc: Cedric Hombourger , Subject: Re: [PATCH 1/3] sshd-regen-keys: correct dependency on ssh daemon service Message-ID: <20200316133934.223e4a0b@md1za8fc.ad001.siemens.net> In-Reply-To: <7b509345-adfb-4cee-a02b-c0555863320a@siemens.com> References: <1583856274-254-1-git-send-email-Cedric_Hombourger@mentor.com> <1583856274-254-2-git-send-email-Cedric_Hombourger@mentor.com> <7b509345-adfb-4cee-a02b-c0555863320a@siemens.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: gamSNo/u+fo8 I would still like to keep the rename to not rely on the symlink. Cedric can you send it again with a fresh commit message? Henning On Thu, 12 Mar 2020 14:50:43 +0100 Gylstorff Quirin wrote: > On 3/10/20 5:04 PM, Cedric Hombourger wrote: > > The name of the SSH daemon service is ssh.service, not sshd.service > > This fixes some (sporadic) failures to generate host-specific ssh > > keys on first boot. > > > > Signed-off-by: Cedric Hombourger > > --- > > .../sshd-regen-keys/files/sshd-regen-keys.service | > > 2 +- .../{sshd-regen-keys_0.2.bb => sshd-regen-keys_0.3.bb} > > | 0 2 files changed, 1 insertion(+), 1 deletion(-) > > rename > > meta/recipes-support/sshd-regen-keys/{sshd-regen-keys_0.2.bb => > > sshd-regen-keys_0.3.bb} (100%) > > > > diff --git > > a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service > > b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service > > index a05e1a9..f50d34c 100644 --- > > a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service > > +++ > > b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.service > > @@ -3,7 +3,7 @@ Description=Regenerate sshd host keys > > DefaultDependencies=no Conflicts=shutdown.target > > After=systemd-remount-fs.service -Before=shutdown.target > > sshd.service +Before=shutdown.target ssh.service > > > This should not be necessary as Debian generates a link from > /etc/systemd/system/sshd.service to /lib/systemd/system/ssh.service. > Therefore both sshd.service and ssh.service are equivalent. > > Also I have a freeze during sshd-regen-keys but the patch has no > impact on it. > > Quirin > > ConditionPathIsReadWrite=/etc > > > > [Service] > > diff --git > > a/meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.2.bb > > b/meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.3.bb > > similarity index 100% rename from > > meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.2.bb rename > > to meta/recipes-support/sshd-regen-keys/sshd-regen-keys_0.3.bb