Re: [PATCH] linux-custom: Install config and map file to /boot

[Henning Schild <henning.schild@siemens.com>]

On Wed, 18 Mar 2020 11:23:24 +0530
vijai kumar <vijaikumar.kanagarajan@gmail.com> wrote:

> On Tue, Mar 17, 2020 at 11:02 PM Jan Kiszka <jan.kiszka@siemens.com>
> wrote:
> >
> > On 17.03.20 18:14, Vijai Kumar K wrote:  
> > > Align with upstream debian linux-image package. Install the
> > > config and System.map file to /boot directory. Skip installation
> > > for User Mode Linux.
> > >
> > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> > > ---
> > >   .../linux/files/debian/isar/install.tmpl           | 14
> > > ++++++++++++++ 1 file changed, 14 insertions(+)
> > >
> > > diff --git
> > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index
> > > 12d592d..4e1f850 100644 ---
> > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++
> > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@
> > > -37,6 +37,8 @@ do_install() { set -x
> > >
> > >       install_image

Looks like the "um" guard could move here to only have it once.

> > > +    install_config
> > > +    install_map
> > >       install_hooks
> > >       install_dtbs
> > >       install_kmods
> > > @@ -69,6 +71,18 @@ install_image() {
> > >       install_image_debug
> > >   }
> > >
> > > +install_config() {
> > > +    if [ "${ARCH}" != "um" ]; then
> > > +        cp ${O}/.config ${deb_img_dir}/$(dirname
> > > ${kimage_path})/config-${krel}
> > > +    fi
> > > +}
> > > +
> > > +install_map() {
> > > +    if [ "${ARCH}" != "um" ]; then
> > > +        cp ${O}/System.map ${deb_img_dir}/$(dirname
> > > ${kimage_path})/System.map-${krel}
> > > +    fi
> > > +}
> > > +
> > >   install_image_debug() {
> > >       # Different tools want the image in different locations
> > >       # perf
> > >  
> >
> > I think this should be made configurable. Not every embedded system
> > may need or even want these. Can be on be default nevertheless,
> > specifically if that is Debian behavior.  
> 
> Sure. I believe that can be investigated and done as a separate patch.
> We are now trying to match the contents wrt Debian upstream/ the
> previous Linux build procedure as some of our downstream test cases
> rely on the config file in /boot.

If the system under test has CONFIG_IKCONFIG_PROC and is running the
kernel, /proc/config.gz is probably the better source.
For the config i really do not see a point to not ship it, its not too
big. Some security gurus might argue that they do not want to ship it
for obfuscation ... but i would not listen to them.

I think your test should try /proc /boot and finally skip the test
instead of fail it ;).

Henning

> Thanks,
> Vijai Kumar K
> 
> >
> > That said, we may also look into shrinking the dtb installations,
> > only packaging what the target actually needs. Unrelated to this
> > patch, for sure.
> >
> > Jan
> >
> > --
> > Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> > Corporate Competence Center Embedded Linux  
>