From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 X-Received: by 2002:a1c:9e85:: with SMTP id h127mr3476662wme.145.1584516898304; Wed, 18 Mar 2020 00:34:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:548b:: with SMTP id h11ls12243813wrv.9.gmail; Wed, 18 Mar 2020 00:34:57 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs2bpr786hU0JXonZly9xQ6APitM1k2NW/LRYU/QZcgyrWQvCd8NLZl/PPEAgActfqlgrZV X-Received: by 2002:adf:f00f:: with SMTP id j15mr3864978wro.413.1584516897648; Wed, 18 Mar 2020 00:34:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584516897; cv=none; d=google.com; s=arc-20160816; b=HlIaHkB2inaHkB8aVBPPzblMKImItAwqhjFDLs8fdhe+N32Ud/CKpie6CbHXgNv6wa q4rT3GVHX7kmBk6PoaNhPBPFla8WQ4wQynaTV3z2p++lz+ibgPo0Yjwz80CIq0DrJ923 t4wXgTlen77MYVIbjtvw8N8/zcX7Gx3WnV7fC11cBu0oK0Ko7o7slxDPFXwAUPGYJj8M 56tB5z1fzcuTnnaNWy+rqBbmTNxC+GCeDhB+zvTOhwYOGBwP5sW0vrCbhxIEaEne6pom RGqPBtN+jcIbxwOwbGM+A0O8DKCe1SUPNBBMWvw3oHYgi8+QCDt3Gx5dpiwHfd2l85fp Cvjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=uLLHM2rbL23fRnySu6cC3bhMCbNvrXSvRYuRY6w4vZw=; b=hlR7Vug3Psoe4NBRLSj5WUkHhbFzqE7HjcC0RC8/nlSfcMUJbCx0OjuJurc7AhLy6S WlhJIogdhhZq0XPwmdMPhvkon/wns96VUFMAUavD2rEbgVmiZIz/feg4RJUBvUU9hkMG d+QynUKqQ/PCei4766RMWIwzrA5xeox5VtHprTUSQIQolPwgJwkhOobEOa9kbpANdN0w ulNQ38saF+q8MPJay4E+bs91pVg8ifeAEMj1mIvbvBhq33vK5z+li++X1jnAmdIUtFdR zM7l375IizqMxkAkyq1FUxQYVScIU4KpLYJam/IMiC9dssn60FjbWVXEqwAvL9sBrWS5 PPwQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id d16si233117wrv.4.2020.03.18.00.34.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2020 00:34:57 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 02I7YuJ1009219 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Mar 2020 08:34:56 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.5.68]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 02I7YscH017594; Wed, 18 Mar 2020 08:34:55 +0100 Date: Wed, 18 Mar 2020 08:34:43 +0100 From: Henning Schild To: vijai kumar Cc: Jan Kiszka , isar-users , Vijai Kumar K Subject: Re: [PATCH] linux-custom: Install config and map file to /boot Message-ID: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20200317171455.17840-1-Vijaikumar_Kanagarajan@mentor.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: HU22tk5PKVTx On Wed, 18 Mar 2020 11:23:24 +0530 vijai kumar wrote: > On Tue, Mar 17, 2020 at 11:02 PM Jan Kiszka > wrote: > > > > On 17.03.20 18:14, Vijai Kumar K wrote: > > > Align with upstream debian linux-image package. Install the > > > config and System.map file to /boot directory. Skip installation > > > for User Mode Linux. > > > > > > Signed-off-by: Vijai Kumar K > > > --- > > > .../linux/files/debian/isar/install.tmpl | 14 > > > ++++++++++++++ 1 file changed, 14 insertions(+) > > > > > > diff --git > > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > > > 12d592d..4e1f850 100644 --- > > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > > > -37,6 +37,8 @@ do_install() { set -x > > > > > > install_image Looks like the "um" guard could move here to only have it once. > > > + install_config > > > + install_map > > > install_hooks > > > install_dtbs > > > install_kmods > > > @@ -69,6 +71,18 @@ install_image() { > > > install_image_debug > > > } > > > > > > +install_config() { > > > + if [ "${ARCH}" != "um" ]; then > > > + cp ${O}/.config ${deb_img_dir}/$(dirname > > > ${kimage_path})/config-${krel} > > > + fi > > > +} > > > + > > > +install_map() { > > > + if [ "${ARCH}" != "um" ]; then > > > + cp ${O}/System.map ${deb_img_dir}/$(dirname > > > ${kimage_path})/System.map-${krel} > > > + fi > > > +} > > > + > > > install_image_debug() { > > > # Different tools want the image in different locations > > > # perf > > > > > > > I think this should be made configurable. Not every embedded system > > may need or even want these. Can be on be default nevertheless, > > specifically if that is Debian behavior. > > Sure. I believe that can be investigated and done as a separate patch. > We are now trying to match the contents wrt Debian upstream/ the > previous Linux build procedure as some of our downstream test cases > rely on the config file in /boot. If the system under test has CONFIG_IKCONFIG_PROC and is running the kernel, /proc/config.gz is probably the better source. For the config i really do not see a point to not ship it, its not too big. Some security gurus might argue that they do not want to ship it for obfuscation ... but i would not listen to them. I think your test should try /proc /boot and finally skip the test instead of fail it ;). Henning > Thanks, > Vijai Kumar K > > > > > That said, we may also look into shrinking the dtb installations, > > only packaging what the target actually needs. Unrelated to this > > patch, for sure. > > > > Jan > > > > -- > > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > > Corporate Competence Center Embedded Linux >