From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6788114222392803328 X-Received: by 2002:a05:600c:214f:: with SMTP id v15mr15267275wml.110.1584779525575; Sat, 21 Mar 2020 01:32:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:4b07:: with SMTP id y7ls387691wma.2.canary-gmail; Sat, 21 Mar 2020 01:32:05 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuvbKPpQemgk5CelQSiMZ7mmJUagFRtTCqY8qAkoT6rRGzCB6Twpct64ebUjRYpwX9ePCi0 X-Received: by 2002:a1c:9d41:: with SMTP id g62mr15559666wme.131.1584779524895; Sat, 21 Mar 2020 01:32:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584779524; cv=none; d=google.com; s=arc-20160816; b=zIuo2jFWD2Vz8Wjb4u0AmShb5YUfgS2Noqegi6fJ4odL0/9LTeahdgHwTG/G0sjbts FekYB49lGbzCDmK5zZKX1Vz9/ezISJ4Anw4sgUg+NvRWlyCa5868Uu4rta9cA+O2E9y/ QZLj2afG62lY4+ToCNE6oMWoF5VljnCNecrQup4pzpWy0vWriOsAn8rdhnIq1uf1tc0t mHFDlOBoxFikMkMJbegdqDBwXNAJDhO/EB2F4zN7a5yCfPbKx7XYvLnp8d3tohrHvw+y 6edV3fVn8u+sAtgoYlBGPqTran8pqgd/Vm3Ft9ki3VCOm3z+J7LxIECI/VASTBnAq61g 7NFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=x1qI2TH2pVVkpMDlN7b5zQqlVbGjH3V+2yyjvXgC4zI=; b=kpnRsonVqQZVH3Q3TXvqq8uIyBlkOXrsMSIRe8nmLhnhKXs6751SwfbCphgRpLMzoK 2qUJ0Phhm18WDXj9MaSHlGGvzHYJ+cE9CotHtl6vtfHFt+qH4t3OaqNj3881XuMcJ14f JC9nVWZrGk8Q2WXfzea3aIoIS4A4ifcae02WJQ9hsONVufq3YV3ZbKA3aJ4Vz/teqnjQ JElS5+txECUAbqcupRpdpRREpY7s9lWJ/lVIlqqjCqk+k8w4J9zBx071xlz6VKyiGhbR I9IevQWS2k+Ro1LcI/3YBky4/21HMglhwCrgispZs3cD/rvc9QLmanAiTRNAG8gQSQQD ntkQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id x12si536666wmk.1.2020.03.21.01.32.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Mar 2020 01:32:04 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 02L8W4GY011721 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Mar 2020 09:32:04 +0100 Received: from localhost.localdomain ([139.22.32.253]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 02L8VuGU021533; Sat, 21 Mar 2020 09:32:03 +0100 From: Henning Schild To: isar-users@googlegroups.com Cc: Vijai Kumar K , Baurzhan Ismagulov , Jan Kiszka , Henning Schild Subject: [PATCHv7 16/29] base-apt: move class "base-apt-helper" into only user Date: Sat, 21 Mar 2020 09:31:35 +0100 Message-Id: <20200321083148.26160-17-henning.schild@siemens.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200321083148.26160-1-henning.schild@siemens.com> References: <20200321083148.26160-1-henning.schild@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: R7FIW6whpHTK From: Henning Schild There is only one place we use that code, move it there instead of having an extra class. Signed-off-by: Henning Schild --- meta/classes/base-apt-helper.bbclass | 60 ---------------------- meta/classes/image-cache-extension.bbclass | 55 +++++++++++++++++++- 2 files changed, 54 insertions(+), 61 deletions(-) delete mode 100644 meta/classes/base-apt-helper.bbclass diff --git a/meta/classes/base-apt-helper.bbclass b/meta/classes/base-apt-helper.bbclass deleted file mode 100644 index 7ed28595..00000000 --- a/meta/classes/base-apt-helper.bbclass +++ /dev/null @@ -1,60 +0,0 @@ -# This software is a part of ISAR. -# Copyright (C) 2018 ilbers GmbH -# Copyright (C) 2020 Siemens AG -# -# SPDX-License-Identifier: MIT - -inherit repository - -compare_pkg_md5sums() { - pkg1=$1 - pkg2=$2 - - md1=$(md5sum $pkg1 | cut -d ' ' -f 1) - md2=$(md5sum $pkg2 | cut -d ' ' -f 1) - - [ "$md1" = "$md2" ] -} - -populate_base_apt() { - find "${DEBDIR}"/"${DISTRO}" -name '*\.deb' | while read package; do - # NOTE: due to packages stored by reprepro are not modified, we can - # use search by filename to check if package is already in repo. In - # addition, md5sums are compared to ensure that the package is the - # same and should not be overwritten. This method is easier and more - # robust than querying reprepro by name. - - # Check if this package is taken from Isar-apt, if so - ignore it. - base_name=${package##*/} - isar_apt_p=$(find ${REPO_ISAR_DIR}/${DISTRO} -name $base_name) - if [ -n "$isar_apt_p" ]; then - # Check if MD5 sums are identical. This helps to avoid the case - # when packages is overridden from another repo. - compare_pkg_md5sums "$package" "$isar_apt_p" && continue - fi - - # Check if this package is already in base-apt - base_apt_p=$(find ${REPO_BASE_DIR}/${BASE_DISTRO} -name $base_name) - if [ -n "$base_apt_p" ]; then - compare_pkg_md5sums "$package" "$base_apt_p" && continue - - # md5sum differs, so remove the package from base-apt - repo_del_package "${REPO_BASE_DIR}"/"${BASE_DISTRO}" \ - "${REPO_BASE_DB_DIR}"/"${BASE_DISTRO}" \ - "${BASE_DISTRO_CODENAME}" \ - "${base_apt_p}" - fi - - repo_add_packages "${REPO_BASE_DIR}"/"${BASE_DISTRO}" \ - "${REPO_BASE_DB_DIR}"/"${BASE_DISTRO}" \ - "${BASE_DISTRO_CODENAME}" \ - "${package}" - done - - find "${DEBSRCDIR}"/"${DISTRO}" -name '*\.dsc' | while read package; do - repo_add_srcpackage "${REPO_BASE_DIR}"/"${BASE_DISTRO}" \ - "${REPO_BASE_DB_DIR}"/"${BASE_DISTRO}" \ - "${BASE_DISTRO_CODENAME}" \ - "${package}" - done -} diff --git a/meta/classes/image-cache-extension.bbclass b/meta/classes/image-cache-extension.bbclass index 7945e8bc..c3ee7b83 100644 --- a/meta/classes/image-cache-extension.bbclass +++ b/meta/classes/image-cache-extension.bbclass @@ -5,7 +5,60 @@ # # This class extends the image.bbclass to supply the creation of cache repositories -inherit base-apt-helper +inherit repository + +compare_pkg_md5sums() { + pkg1=$1 + pkg2=$2 + + md1=$(md5sum $pkg1 | cut -d ' ' -f 1) + md2=$(md5sum $pkg2 | cut -d ' ' -f 1) + + [ "$md1" = "$md2" ] +} + +populate_base_apt() { + find "${DEBDIR}"/"${DISTRO}" -name '*\.deb' | while read package; do + # NOTE: due to packages stored by reprepro are not modified, we can + # use search by filename to check if package is already in repo. In + # addition, md5sums are compared to ensure that the package is the + # same and should not be overwritten. This method is easier and more + # robust than querying reprepro by name. + + # Check if this package is taken from Isar-apt, if so - ignore it. + base_name=${package##*/} + isar_apt_p=$(find ${REPO_ISAR_DIR}/${DISTRO} -name $base_name) + if [ -n "$isar_apt_p" ]; then + # Check if MD5 sums are identical. This helps to avoid the case + # when packages is overridden from another repo. + compare_pkg_md5sums "$package" "$isar_apt_p" && continue + fi + + # Check if this package is already in base-apt + base_apt_p=$(find ${REPO_BASE_DIR}/${BASE_DISTRO} -name $base_name) + if [ -n "$base_apt_p" ]; then + compare_pkg_md5sums "$package" "$base_apt_p" && continue + + # md5sum differs, so remove the package from base-apt + repo_del_package "${REPO_BASE_DIR}"/"${BASE_DISTRO}" \ + "${REPO_BASE_DB_DIR}"/"${BASE_DISTRO}" \ + "${BASE_DISTRO_CODENAME}" \ + "${base_apt_p}" + fi + + repo_add_packages "${REPO_BASE_DIR}"/"${BASE_DISTRO}" \ + "${REPO_BASE_DB_DIR}"/"${BASE_DISTRO}" \ + "${BASE_DISTRO_CODENAME}" \ + "${package}" + done + + find "${DEBSRCDIR}"/"${DISTRO}" -name '*\.dsc' | while read package; do + repo_add_srcpackage "${REPO_BASE_DIR}"/"${BASE_DISTRO}" \ + "${REPO_BASE_DB_DIR}"/"${BASE_DISTRO}" \ + "${BASE_DISTRO_CODENAME}" \ + "${package}" + done +} do_cache_base_repo[depends] = "base-apt:do_cache_config" do_cache_base_repo[lockfiles] = "${REPO_BASE_DIR}/isar.lock" -- 2.24.1