Re: [PATCH v2] linux-custom: Install config and map file to /boot

[Henning Schild <henning.schild@siemens.com>]

On Mon, 23 Mar 2020 07:12:00 +0100
"[ext] Jan Kiszka" <jan.kiszka@siemens.com> wrote:

> On 18.03.20 14:21, Vijai Kumar K wrote:
> > Align with upstream debian linux-image package. Install the config
> > and System.map file to /boot directory. Skip installation for User
> > Mode Linux.
> > 
> > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> > ---
> > Changes in v2:
> >      - Moved um condition check as per Henning's comment
> > 
> >   .../linux/files/debian/isar/install.tmpl             | 12
> > ++++++++++++ 1 file changed, 12 insertions(+)
> > 
> > diff --git
> > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl
> > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index
> > 12d592d..849da5e 100644 ---
> > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++
> > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6
> > +37,10 @@ do_install() { set -x 
> >       install_image
> > +    if [ "${ARCH}" != "um" ]; then
> > +        install_config
> > +        install_map
> > +    fi
> >       install_hooks
> >       install_dtbs
> >       install_kmods
> > @@ -69,6 +73,14 @@ install_image() {
> >       install_image_debug
> >   }
> >   
> > +install_config() {
> > +    cp ${O}/.config ${deb_img_dir}/$(dirname
> > ${kimage_path})/config-${krel} +}
> > +
> > +install_map() {
> > +    cp ${O}/System.map ${deb_img_dir}/$(dirname
> > ${kimage_path})/System.map-${krel}  
> 
> I think those cp calls should be install with proper modes, no?

I wanted to say that as well, but in fact the whole scripts seems to
use a mix of cp and install and this one does not make things worse.

Henning

> Jan
> 
> > +}
> > +
> >   install_image_debug() {
> >       # Different tools want the image in different locations
> >       # perf
> >   
>