From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 X-Received: by 2002:a5d:4bc1:: with SMTP id l1mr29664096wrt.103.1584946435493; Sun, 22 Mar 2020 23:53:55 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:2250:: with SMTP id a16ls1880525wmm.3.canary-gmail; Sun, 22 Mar 2020 23:53:54 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsDHpVwJO+SGJLPcqCWgsuk34T1pLOkg7uQ9sTgt3K85J6zJokN2q9M7saiYrR8x10JNWlx X-Received: by 2002:a05:600c:d4:: with SMTP id u20mr9946490wmm.83.1584946434934; Sun, 22 Mar 2020 23:53:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584946434; cv=none; d=google.com; s=arc-20160816; b=Y1bnXXzDl1b5XrxabAwHVXtVzG/Bq3xVi0QwQS1v9/kQaQGXqvFPxe1ROlBJokGNYX 4JIs8Urc7YhLxoDWrd8phyHs7Zw/RK+caJuR0TNF9nH7EhyQ+laxFYIcE+Uv6pKaBeSN +KKaweD4juUgNifR5N5lkwJmRXy7kM7cHB33w6WlFI1b6H+3jtHgzLJDuNNhhUWKldVF o0SdXla5zOHio3iSJWP6PYoU5Y11Mm3uqg/Go0zzMUhedAXhiRdSUVGUsp3yGJ30vj9J oQ3ZeObwWHwud3SfdLZijlQB4uTa13Knx1FkSTVTzSXI1uk/lz7v4CoRQV/jp/ezzrSw ye6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=fmGzbSTe7yzmE9ccnJg2zKRLUQmYhZQhiDnsFpEkx+8=; b=QDe4/gf/m/yv9EmrMakUSxu09rCz+32wQRYssY18Mkg1D2RsSePr7DaTN36kKybonS RAfJPMVfEkb45lUocvO33XirDa/HmjND8PXFEdsLwfnOZ/tqZKU0b9SeT4s1nG+VjF6f +cFS9ihdFHlBhlWUS8VedUQrV4P1hc9v8SlXRRpHFeQjdKCuQHmGtrFb4oIglHgZpP2w iGHtimSG6l8zIBwRrBuSTeK7WzVJKgM+AVa3cwnPEGQuow96WlWPyi9D1qetPTU+cko8 hwLWqnNxQIudCouM27Sf7JZWFUChOHFGNttXqgqZH3rGi7knpAAOYx7S4NUfLWMDBt33 MjGw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id q2si334199wrc.2.2020.03.22.23.53.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Mar 2020 23:53:54 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 02N6rsN0015759 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Mar 2020 07:53:54 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.42.139]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 02N6rr8t018963; Mon, 23 Mar 2020 07:53:53 +0100 Date: Mon, 23 Mar 2020 07:53:51 +0100 From: Henning Schild To: "[ext] Jan Kiszka" Cc: Vijai Kumar K , , Vijai Kumar K Subject: Re: [PATCH v2] linux-custom: Install config and map file to /boot Message-ID: <20200323075351.0607ceb8@md1za8fc.ad001.siemens.net> In-Reply-To: <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com> References: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com> <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: IVpGJ6I4NwjA On Mon, 23 Mar 2020 07:12:00 +0100 "[ext] Jan Kiszka" wrote: > On 18.03.20 14:21, Vijai Kumar K wrote: > > Align with upstream debian linux-image package. Install the config > > and System.map file to /boot directory. Skip installation for User > > Mode Linux. > > > > Signed-off-by: Vijai Kumar K > > --- > > Changes in v2: > > - Moved um condition check as per Henning's comment > > > > .../linux/files/debian/isar/install.tmpl | 12 > > ++++++++++++ 1 file changed, 12 insertions(+) > > > > diff --git > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > > 12d592d..849da5e 100644 --- > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 > > +37,10 @@ do_install() { set -x > > install_image > > + if [ "${ARCH}" != "um" ]; then > > + install_config > > + install_map > > + fi > > install_hooks > > install_dtbs > > install_kmods > > @@ -69,6 +73,14 @@ install_image() { > > install_image_debug > > } > > > > +install_config() { > > + cp ${O}/.config ${deb_img_dir}/$(dirname > > ${kimage_path})/config-${krel} +} > > + > > +install_map() { > > + cp ${O}/System.map ${deb_img_dir}/$(dirname > > ${kimage_path})/System.map-${krel} > > I think those cp calls should be install with proper modes, no? I wanted to say that as well, but in fact the whole scripts seems to use a mix of cp and install and this one does not make things worse. Henning > Jan > > > +} > > + > > install_image_debug() { > > # Different tools want the image in different locations > > # perf > > >