From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 X-Received: by 2002:a05:6512:51c:: with SMTP id o28mr4461316lfb.116.1584954813235; Mon, 23 Mar 2020 02:13:33 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9099:: with SMTP id l25ls526022ljg.7.gmail; Mon, 23 Mar 2020 02:13:32 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtNEzfWzt9cw3exlYVEnf7YLQ+vS6FeJpuHYPu/VTe3CrcBZ9382D1wpNjNqvoHPiex1tc8 X-Received: by 2002:a05:651c:1a5:: with SMTP id c5mr3467374ljn.113.1584954812509; Mon, 23 Mar 2020 02:13:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584954812; cv=none; d=google.com; s=arc-20160816; b=ggtvoxKg8l+kMJYryYPAtiRRrs7t7nw/6lv6mOOzfprMB3YySpfeUgKW+z9D5IKi7a 6LFo6hePB62JXC/rFj/7CvU+F7Y5Nbq998mAhZFgFVJBybUoad85kxtbcGZ0JutH4TuK WWta+kSu8aEplzcpcKDPR08gbC+tUIjwMMdEjrKOH8k1ZUehB0/n690818x6OOUplBd1 rdYlvn8m7dtNFWDEOdbalxI07xd9Wlti/jP6p7hMVGO747zoq7ES1a3uCGRc/4gW7oR0 JGSuON0c+8apB1YG6Sj/lv9atwkJWkP1zUoBpANCqx+ZmQXlmq7w+jWTSm1vpW30aEcT Te3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=T2gNmo72Ty14g9HwBjDgnD1pyYiLLY5ydJZbV9mAVW8=; b=L/o4ogfqg/rLFBcVum4tcTKrYxzOZbPXW6QkOY3EM68K9ebbyvBQgV+dwIOD0eTs/3 9+tm3eHH0TxeGMdE0RTFAVVHdApP8YXbqLxx77A0iKxrM+NRAkMW8aZEK9IWzX2UdRLx +meZB4iuVpafzkAY235bdeQ6SGC+8yn5+wafXcWbhwCFy8bR4Qf4zc6bL6/El+qjhEmC AyTIoc5rLLWtLT7WnkQ1ETce/cM6QgIQslENRMGTbenE8o7rz1PS8+n3GoXn6hMGESCX evVLS9LJm3n4SPRDs5+tmzDUFaR5oPVvNYmgLxOX7HjuVGCJFuPcJalBdcHeJkq5Xx1r amIA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id s22si620655ljp.0.2020.03.23.02.13.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2020 02:13:32 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 02N9DSsa024511 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Mar 2020 10:13:28 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.42.139]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 02N9DR4n002270; Mon, 23 Mar 2020 10:13:27 +0100 Date: Mon, 23 Mar 2020 10:13:20 +0100 From: Henning Schild To: Jan Kiszka Cc: Vijai Kumar K , , Vijai Kumar K Subject: Re: [PATCH v2] linux-custom: Install config and map file to /boot Message-ID: <20200323101320.3a4a5774@md1za8fc.ad001.siemens.net> In-Reply-To: <8bfc26fd-627b-bfa8-cbfc-6d1c7614ac47@siemens.com> References: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com> <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com> <20200323075351.0607ceb8@md1za8fc.ad001.siemens.net> <8bfc26fd-627b-bfa8-cbfc-6d1c7614ac47@siemens.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: xBzmyi/sYGoN On Mon, 23 Mar 2020 07:55:58 +0100 Jan Kiszka wrote: > On 23.03.20 07:53, Henning Schild wrote: > > On Mon, 23 Mar 2020 07:12:00 +0100 > > "[ext] Jan Kiszka" wrote: > > > >> On 18.03.20 14:21, Vijai Kumar K wrote: > >>> Align with upstream debian linux-image package. Install the config > >>> and System.map file to /boot directory. Skip installation for User > >>> Mode Linux. > >>> > >>> Signed-off-by: Vijai Kumar K > >>> --- > >>> Changes in v2: > >>> - Moved um condition check as per Henning's comment > >>> > >>> .../linux/files/debian/isar/install.tmpl | 12 > >>> ++++++++++++ 1 file changed, 12 insertions(+) > >>> > >>> diff --git > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > >>> 12d592d..849da5e 100644 --- > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > >>> -37,6 +37,10 @@ do_install() { set -x > >>> install_image > >>> + if [ "${ARCH}" != "um" ]; then > >>> + install_config > >>> + install_map > >>> + fi > >>> install_hooks > >>> install_dtbs > >>> install_kmods > >>> @@ -69,6 +73,14 @@ install_image() { > >>> install_image_debug > >>> } > >>> > >>> +install_config() { > >>> + cp ${O}/.config ${deb_img_dir}/$(dirname > >>> ${kimage_path})/config-${krel} +} > >>> + > >>> +install_map() { > >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname > >>> ${kimage_path})/System.map-${krel} > >> > >> I think those cp calls should be install with proper modes, no? > > > > I wanted to say that as well, but in fact the whole scripts seems to > > use a mix of cp and install and this one does not make things > > worse. > > Yes, there are 2 other cases that should be fixed, separately. I would suggest we ask Vijai to do all on top, instead of changing here and forgetting the 2 cases? Or maybe just the two on top as part of the series? Vijai what do you think? Henning > Jan >