From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6805226701613694976 X-Received: by 2002:a50:f092:: with SMTP id v18mr20542422edl.77.1584960040462; Mon, 23 Mar 2020 03:40:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:c08:: with SMTP id co8ls256423edb.9.gmail; Mon, 23 Mar 2020 03:40:39 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtfuz2StI1S2N1JhN+S2/5nS5bPyR1SVE1Y8tB2ba8RxskPx+KEkskBQxPnGpb/HEM1qgWo X-Received: by 2002:a50:fd15:: with SMTP id i21mr2767815eds.246.1584960039926; Mon, 23 Mar 2020 03:40:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584960039; cv=none; d=google.com; s=arc-20160816; b=Cw603Br4I22rvzdfdD8H5DVuWcwCjOPIc5QmFnYlw+tgWpIq/Mjbdweb2Pf3DQ6XQ4 b2sbl/LQHDJ+dhHzsCN9uNW3D8ruDyWR5jfYduTOdY7dK3/JqeV8q12CI5/Lqn0kY7hM P6A8YY6jyJufddu7n53Meh9th9+HytQb5Sj5gFKiXa6OcyZQZSXeTQptNJTA/Kp86fYV RiEAHmxKaEkLruqpgaJ8rWRY+eObZT5qhXlUTbuOhyP7H38tErNUxTx1HfMarqCw7AQS MTJYnCmJSlZrUu088PBnbmGQYDSXy/rmLRXr+K89qClM5CAMjtsBXitPa0h90xQs5aKR 82+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=IXHFFbhINGBsthl3l1Fzk33Q5v0ezI8TYTpbR3oKtGs=; b=zMLsMnz/Up+kdduN4n3240P/cC+ZNGEXNuSsdubdKju7wBgdLPbQYm4emFsEVxX1QW gg4wC4dNTIx3XswjX0mhW51gjhF9qA9/Yv5J0PvdLxgWkHTydOssTf4/gO61tAuu6LBn /pdlmm+rZA5GU9TrnWR6nvXlZvaG7hU/zaJF2B0i1YeW4HuFadGTcxugsE7IYTTNxf86 Sg6gSBKRXR4V28h4l8010V32KG4hF1txeSMNaMwE8cErTetp5vI9pYDCY2p6XS7S3ebp BSTzCHue3Qyr89Cn9+3Fsq/6CRG+W3rYJsrM2J98BzuzsG/O/flbG2Mdyr4HnaTFs3A1 IgLg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id f2si452456edm.1.2020.03.23.03.40.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2020 03:40:39 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 02NAecT7027201 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Mar 2020 11:40:39 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.18.46]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 02NAec1t022198; Mon, 23 Mar 2020 11:40:38 +0100 Date: Mon, 23 Mar 2020 11:40:30 +0100 From: Henning Schild To: vijai kumar Cc: Jan Kiszka , isar-users , Vijai Kumar K Subject: Re: [PATCH v2] linux-custom: Install config and map file to /boot Message-ID: <20200323114030.0d641afa@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20200318083443.57bfb489@md1za8fc.ad001.siemens.net> <20200318132137.26828-1-Vijaikumar_Kanagarajan@mentor.com> <3c561d87-4082-b25c-2a7d-932ebca37a73@siemens.com> <20200323075351.0607ceb8@md1za8fc.ad001.siemens.net> <8bfc26fd-627b-bfa8-cbfc-6d1c7614ac47@siemens.com> <20200323101320.3a4a5774@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: xiSzN+dRfcCV On Mon, 23 Mar 2020 14:54:05 +0530 vijai kumar wrote: > On Mon, Mar 23, 2020 at 2:43 PM Henning Schild > wrote: > > > > On Mon, 23 Mar 2020 07:55:58 +0100 > > Jan Kiszka wrote: > > > > > On 23.03.20 07:53, Henning Schild wrote: > > > > On Mon, 23 Mar 2020 07:12:00 +0100 > > > > "[ext] Jan Kiszka" wrote: > > > > > > > >> On 18.03.20 14:21, Vijai Kumar K wrote: > > > >>> Align with upstream debian linux-image package. Install the > > > >>> config and System.map file to /boot directory. Skip > > > >>> installation for User Mode Linux. > > > >>> > > > >>> Signed-off-by: Vijai Kumar K > > > >>> --- > > > >>> Changes in v2: > > > >>> - Moved um condition check as per Henning's comment > > > >>> > > > >>> .../linux/files/debian/isar/install.tmpl | 12 > > > >>> ++++++++++++ 1 file changed, 12 insertions(+) > > > >>> > > > >>> diff --git > > > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > >>> index 12d592d..849da5e 100644 --- > > > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > > > >>> -37,6 +37,10 @@ do_install() { set -x > > > >>> install_image > > > >>> + if [ "${ARCH}" != "um" ]; then > > > >>> + install_config > > > >>> + install_map > > > >>> + fi > > > >>> install_hooks > > > >>> install_dtbs > > > >>> install_kmods > > > >>> @@ -69,6 +73,14 @@ install_image() { > > > >>> install_image_debug > > > >>> } > > > >>> > > > >>> +install_config() { > > > >>> + cp ${O}/.config ${deb_img_dir}/$(dirname > > > >>> ${kimage_path})/config-${krel} +} > > > >>> + > > > >>> +install_map() { > > > >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname > > > >>> ${kimage_path})/System.map-${krel} > > > >> > > > >> I think those cp calls should be install with proper modes, > > > >> no? > > > > > > > > I wanted to say that as well, but in fact the whole scripts > > > > seems to use a mix of cp and install and this one does not make > > > > things worse. > > > > > > Yes, there are 2 other cases that should be fixed, separately. > > > > I would suggest we ask Vijai to do all on top, instead of changing > > here and forgetting the 2 cases? > > > > Or maybe just the two on top as part of the series? Vijai what do > > you think? > > Hi Henning, > > We could address the two cases here and rest two cases as a separate > patch. I could update this patch(v3) and can send a separate patch for > the remaining two cases. > > Is this okay for all? If you are willing to do the fix i would suggest to include it into your series instead of sending it alone. Henning > Thanks, > Vijai Kumar K > > > > > Henning > > > > > Jan > > > > >