* [PATCH] linux-custom: Install config and map file to /boot @ 2020-03-17 17:14 Vijai Kumar K 2020-03-17 17:19 ` vijai kumar 2020-03-17 17:32 ` Jan Kiszka 0 siblings, 2 replies; 28+ messages in thread From: Vijai Kumar K @ 2020-03-17 17:14 UTC (permalink / raw) To: isar-users; +Cc: Vijai Kumar K Align with upstream debian linux-image package. Install the config and System.map file to /boot directory. Skip installation for User Mode Linux. Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> --- .../linux/files/debian/isar/install.tmpl | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index 12d592d..4e1f850 100644 --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 +37,8 @@ do_install() { set -x install_image + install_config + install_map install_hooks install_dtbs install_kmods @@ -69,6 +71,18 @@ install_image() { install_image_debug } +install_config() { + if [ "${ARCH}" != "um" ]; then + cp ${O}/.config ${deb_img_dir}/$(dirname ${kimage_path})/config-${krel} + fi +} + +install_map() { + if [ "${ARCH}" != "um" ]; then + cp ${O}/System.map ${deb_img_dir}/$(dirname ${kimage_path})/System.map-${krel} + fi +} + install_image_debug() { # Different tools want the image in different locations # perf -- 2.17.1 ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-03-17 17:14 [PATCH] linux-custom: Install config and map file to /boot Vijai Kumar K @ 2020-03-17 17:19 ` vijai kumar 2020-03-17 17:39 ` Jan Kiszka 2020-03-17 17:32 ` Jan Kiszka 1 sibling, 1 reply; 28+ messages in thread From: vijai kumar @ 2020-03-17 17:19 UTC (permalink / raw) To: isar-users [-- Attachment #1.1: Type: text/plain, Size: 1597 bytes --] I am not sure how to test the um use case in kernel in ISAR. Are there any specific targets in ISAR that I am missing? Thanks, Vijai Kumar K On Tuesday, March 17, 2020 at 10:45:13 PM UTC+5:30, vijai kumar wrote: > > Align with upstream debian linux-image package. Install the config and > System.map file to /boot directory. Skip installation for User Mode Linux. > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > --- > .../linux/files/debian/isar/install.tmpl | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > index 12d592d..4e1f850 100644 > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > @@ -37,6 +37,8 @@ do_install() { > set -x > > install_image > + install_config > + install_map > install_hooks > install_dtbs > install_kmods > @@ -69,6 +71,18 @@ install_image() { > install_image_debug > } > > +install_config() { > + if [ "${ARCH}" != "um" ]; then > + cp ${O}/.config ${deb_img_dir}/$(dirname > ${kimage_path})/config-${krel} > + fi > +} > + > +install_map() { > + if [ "${ARCH}" != "um" ]; then > + cp ${O}/System.map ${deb_img_dir}/$(dirname > ${kimage_path})/System.map-${krel} > + fi > +} > + > install_image_debug() { > # Different tools want the image in different locations > # perf > -- > 2.17.1 > > [-- Attachment #1.2: Type: text/html, Size: 2271 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-03-17 17:19 ` vijai kumar @ 2020-03-17 17:39 ` Jan Kiszka 2020-03-25 7:07 ` cedric_hombourger 0 siblings, 1 reply; 28+ messages in thread From: Jan Kiszka @ 2020-03-17 17:39 UTC (permalink / raw) To: vijai kumar, isar-users, Cedric Hombourger On 17.03.20 18:19, vijai kumar wrote: > I am not sure how to test the um use case in kernel in ISAR. Are there > any specific targets in ISAR that I am missing? > I don't think we had a um use case so far, so there might be things silently broken. Not sure if Cedric tested the um special handling, I surely didn't. Jan > Thanks, > Vijai Kumar K > > On Tuesday, March 17, 2020 at 10:45:13 PM UTC+5:30, vijai kumar wrote: > > Align with upstream debian linux-image package. Install the config and > System.map file to /boot directory. Skip installation for User Mode > Linux. > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com > <mailto:Vijaikumar_Kanagarajan@mentor.com>> > --- > .../linux/files/debian/isar/install.tmpl | 14 > ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > index 12d592d..4e1f850 100644 > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > @@ -37,6 +37,8 @@ do_install() { > set -x > > install_image > + install_config > + install_map > install_hooks > install_dtbs > install_kmods > @@ -69,6 +71,18 @@ install_image() { > install_image_debug > } > > +install_config() { > + if [ "${ARCH}" != "um" ]; then > + cp ${O}/.config ${deb_img_dir}/$(dirname > ${kimage_path})/config-${krel} > + fi > +} > + > +install_map() { > + if [ "${ARCH}" != "um" ]; then > + cp ${O}/System.map ${deb_img_dir}/$(dirname > ${kimage_path})/System.map-${krel} > + fi > +} > + > install_image_debug() { > # Different tools want the image in different locations > # perf > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google > Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to isar-users+unsubscribe@googlegroups.com > <mailto:isar-users+unsubscribe@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com > <https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com?utm_medium=email&utm_source=footer>. -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-03-17 17:39 ` Jan Kiszka @ 2020-03-25 7:07 ` cedric_hombourger 2020-04-03 7:28 ` vijai kumar 0 siblings, 1 reply; 28+ messages in thread From: cedric_hombourger @ 2020-03-25 7:07 UTC (permalink / raw) To: isar-users [-- Attachment #1.1: Type: text/plain, Size: 3174 bytes --] On Tuesday, March 17, 2020 at 6:40:01 PM UTC+1, Jan Kiszka wrote: > > On 17.03.20 18:19, vijai kumar wrote: > > I am not sure how to test the um use case in kernel in ISAR. Are there > > any specific targets in ISAR that I am missing? > > > > I don't think we had a um use case so far, so there might be things > silently broken. Not sure if Cedric tested the um special handling, I > surely didn't. > used "um" for another project (and without Isar). I would recommend we don't bother with it as far as Isar is concerned until we get a request for it > Jan > > > Thanks, > > Vijai Kumar K > > > > On Tuesday, March 17, 2020 at 10:45:13 PM UTC+5:30, vijai kumar wrote: > > > > Align with upstream debian linux-image package. Install the config > and > > System.map file to /boot directory. Skip installation for User Mode > > Linux. > > > > Signed-off-by: Vijai Kumar K <Vijaikumar_...@mentor.com > <javascript:> > > <mailto:Vijaikumar_Kanagarajan@mentor.com <javascript:>>> > > --- > > .../linux/files/debian/isar/install.tmpl | 14 > > ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > index 12d592d..4e1f850 100644 > > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > @@ -37,6 +37,8 @@ do_install() { > > set -x > > > > install_image > > + install_config > > + install_map > > install_hooks > > install_dtbs > > install_kmods > > @@ -69,6 +71,18 @@ install_image() { > > install_image_debug > > } > > > > +install_config() { > > + if [ "${ARCH}" != "um" ]; then > > + cp ${O}/.config ${deb_img_dir}/$(dirname > > ${kimage_path})/config-${krel} > > + fi > > +} > > + > > +install_map() { > > + if [ "${ARCH}" != "um" ]; then > > + cp ${O}/System.map ${deb_img_dir}/$(dirname > > ${kimage_path})/System.map-${krel} > > + fi > > +} > > + > > install_image_debug() { > > # Different tools want the image in different locations > > # perf > > -- > > 2.17.1 > > > > -- > > You received this message because you are subscribed to the Google > > Groups "isar-users" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to isar-...@googlegroups.com <javascript:> > > <mailto:isar-users+unsubscribe@googlegroups.com <javascript:>>. > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com > > < > https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com?utm_medium=email&utm_source=footer>. > > > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > [-- Attachment #1.2: Type: text/html, Size: 6000 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-03-25 7:07 ` cedric_hombourger @ 2020-04-03 7:28 ` vijai kumar 2020-04-03 7:29 ` vijai kumar 0 siblings, 1 reply; 28+ messages in thread From: vijai kumar @ 2020-04-03 7:28 UTC (permalink / raw) To: isar-users [-- Attachment #1.1: Type: text/plain, Size: 3343 bytes --] On Wednesday, March 25, 2020 at 12:37:12 PM UTC+5:30, cedric_h...@mentor.com wrote: > > > > On Tuesday, March 17, 2020 at 6:40:01 PM UTC+1, Jan Kiszka wrote: >> >> On 17.03.20 18:19, vijai kumar wrote: >> > I am not sure how to test the um use case in kernel in ISAR. Are there >> > any specific targets in ISAR that I am missing? >> > >> >> I don't think we had a um use case so far, so there might be things >> silently broken. Not sure if Cedric tested the um special handling, I >> surely didn't. >> > > used "um" for another project (and without Isar). > I would recommend we don't bother with it as far as Isar is concerned > until we get a request for it > Thank you for your input Cedric. > > >> Jan >> >> > Thanks, >> > Vijai Kumar K >> > >> > On Tuesday, March 17, 2020 at 10:45:13 PM UTC+5:30, vijai kumar wrote: >> > >> > Align with upstream debian linux-image package. Install the config >> and >> > System.map file to /boot directory. Skip installation for User Mode >> > Linux. >> > >> > Signed-off-by: Vijai Kumar K <Vijaikumar_...@mentor.com >> > <mailto:Vijaikumar_Kanagarajan@mentor.com>> >> > --- >> > .../linux/files/debian/isar/install.tmpl | 14 >> > ++++++++++++++ >> > 1 file changed, 14 insertions(+) >> > >> > diff --git >> > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> > index 12d592d..4e1f850 100644 >> > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >> > @@ -37,6 +37,8 @@ do_install() { >> > set -x >> > >> > install_image >> > + install_config >> > + install_map >> > install_hooks >> > install_dtbs >> > install_kmods >> > @@ -69,6 +71,18 @@ install_image() { >> > install_image_debug >> > } >> > >> > +install_config() { >> > + if [ "${ARCH}" != "um" ]; then >> > + cp ${O}/.config ${deb_img_dir}/$(dirname >> > ${kimage_path})/config-${krel} >> > + fi >> > +} >> > + >> > +install_map() { >> > + if [ "${ARCH}" != "um" ]; then >> > + cp ${O}/System.map ${deb_img_dir}/$(dirname >> > ${kimage_path})/System.map-${krel} >> > + fi >> > +} >> > + >> > install_image_debug() { >> > # Different tools want the image in different locations >> > # perf >> > -- >> > 2.17.1 >> > >> > -- >> > You received this message because you are subscribed to the Google >> > Groups "isar-users" group. >> > To unsubscribe from this group and stop receiving emails from it, send >> > an email to isar-...@googlegroups.com >> > <mailto:isar-users+unsubscribe@googlegroups.com>. >> > To view this discussion on the web visit >> > >> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com >> > < >> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com?utm_medium=email&utm_source=footer>. >> >> >> >> -- >> Siemens AG, Corporate Technology, CT RDA IOT SES-DE >> Corporate Competence Center Embedded Linux >> > [-- Attachment #1.2: Type: text/html, Size: 5713 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-04-03 7:28 ` vijai kumar @ 2020-04-03 7:29 ` vijai kumar 0 siblings, 0 replies; 28+ messages in thread From: vijai kumar @ 2020-04-03 7:29 UTC (permalink / raw) To: isar-users [-- Attachment #1.1: Type: text/plain, Size: 3619 bytes --] On Friday, April 3, 2020 at 12:58:46 PM UTC+5:30, vijai kumar wrote: > > > > On Wednesday, March 25, 2020 at 12:37:12 PM UTC+5:30, > cedric_h...@mentor.com wrote: >> >> >> >> On Tuesday, March 17, 2020 at 6:40:01 PM UTC+1, Jan Kiszka wrote: >>> >>> On 17.03.20 18:19, vijai kumar wrote: >>> > I am not sure how to test the um use case in kernel in ISAR. Are there >>> > any specific targets in ISAR that I am missing? >>> > >>> >>> I don't think we had a um use case so far, so there might be things >>> silently broken. Not sure if Cedric tested the um special handling, I >>> surely didn't. >>> >> >> used "um" for another project (and without Isar). >> I would recommend we don't bother with it as far as Isar is concerned >> until we get a request for it >> > > Thank you for your input Cedric. > If there are no more review comments, can this be merged? Thanks, Vijai Kumar K > > >> >> >>> Jan >>> >>> > Thanks, >>> > Vijai Kumar K >>> > >>> > On Tuesday, March 17, 2020 at 10:45:13 PM UTC+5:30, vijai kumar wrote: >>> > >>> > Align with upstream debian linux-image package. Install the config >>> and >>> > System.map file to /boot directory. Skip installation for User >>> Mode >>> > Linux. >>> > >>> > Signed-off-by: Vijai Kumar K <Vijaikumar_...@mentor.com >>> > <mailto:Vijaikumar_Kanagarajan@mentor.com>> >>> > --- >>> > .../linux/files/debian/isar/install.tmpl | 14 >>> > ++++++++++++++ >>> > 1 file changed, 14 insertions(+) >>> > >>> > diff --git >>> > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> > index 12d592d..4e1f850 100644 >>> > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> > @@ -37,6 +37,8 @@ do_install() { >>> > set -x >>> > >>> > install_image >>> > + install_config >>> > + install_map >>> > install_hooks >>> > install_dtbs >>> > install_kmods >>> > @@ -69,6 +71,18 @@ install_image() { >>> > install_image_debug >>> > } >>> > >>> > +install_config() { >>> > + if [ "${ARCH}" != "um" ]; then >>> > + cp ${O}/.config ${deb_img_dir}/$(dirname >>> > ${kimage_path})/config-${krel} >>> > + fi >>> > +} >>> > + >>> > +install_map() { >>> > + if [ "${ARCH}" != "um" ]; then >>> > + cp ${O}/System.map ${deb_img_dir}/$(dirname >>> > ${kimage_path})/System.map-${krel} >>> > + fi >>> > +} >>> > + >>> > install_image_debug() { >>> > # Different tools want the image in different locations >>> > # perf >>> > -- >>> > 2.17.1 >>> > >>> > -- >>> > You received this message because you are subscribed to the Google >>> > Groups "isar-users" group. >>> > To unsubscribe from this group and stop receiving emails from it, send >>> > an email to isar-...@googlegroups.com >>> > <mailto:isar-users+unsubscribe@googlegroups.com>. >>> > To view this discussion on the web visit >>> > >>> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com >>> > < >>> https://groups.google.com/d/msgid/isar-users/e1c7b955-185e-4f10-83f5-349ad6847274%40googlegroups.com?utm_medium=email&utm_source=footer>. >>> >>> >>> >>> -- >>> Siemens AG, Corporate Technology, CT RDA IOT SES-DE >>> Corporate Competence Center Embedded Linux >>> >> [-- Attachment #1.2: Type: text/html, Size: 6254 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-03-17 17:14 [PATCH] linux-custom: Install config and map file to /boot Vijai Kumar K 2020-03-17 17:19 ` vijai kumar @ 2020-03-17 17:32 ` Jan Kiszka 2020-03-18 5:53 ` vijai kumar 1 sibling, 1 reply; 28+ messages in thread From: Jan Kiszka @ 2020-03-17 17:32 UTC (permalink / raw) To: Vijai Kumar K, isar-users; +Cc: Vijai Kumar K On 17.03.20 18:14, Vijai Kumar K wrote: > Align with upstream debian linux-image package. Install the config and > System.map file to /boot directory. Skip installation for User Mode Linux. > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > --- > .../linux/files/debian/isar/install.tmpl | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > index 12d592d..4e1f850 100644 > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > @@ -37,6 +37,8 @@ do_install() { > set -x > > install_image > + install_config > + install_map > install_hooks > install_dtbs > install_kmods > @@ -69,6 +71,18 @@ install_image() { > install_image_debug > } > > +install_config() { > + if [ "${ARCH}" != "um" ]; then > + cp ${O}/.config ${deb_img_dir}/$(dirname ${kimage_path})/config-${krel} > + fi > +} > + > +install_map() { > + if [ "${ARCH}" != "um" ]; then > + cp ${O}/System.map ${deb_img_dir}/$(dirname ${kimage_path})/System.map-${krel} > + fi > +} > + > install_image_debug() { > # Different tools want the image in different locations > # perf > I think this should be made configurable. Not every embedded system may need or even want these. Can be on be default nevertheless, specifically if that is Debian behavior. That said, we may also look into shrinking the dtb installations, only packaging what the target actually needs. Unrelated to this patch, for sure. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-03-17 17:32 ` Jan Kiszka @ 2020-03-18 5:53 ` vijai kumar 2020-03-18 7:34 ` Henning Schild 0 siblings, 1 reply; 28+ messages in thread From: vijai kumar @ 2020-03-18 5:53 UTC (permalink / raw) To: Jan Kiszka; +Cc: isar-users, Vijai Kumar K On Tue, Mar 17, 2020 at 11:02 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: > > On 17.03.20 18:14, Vijai Kumar K wrote: > > Align with upstream debian linux-image package. Install the config and > > System.map file to /boot directory. Skip installation for User Mode Linux. > > > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > > --- > > .../linux/files/debian/isar/install.tmpl | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > index 12d592d..4e1f850 100644 > > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > @@ -37,6 +37,8 @@ do_install() { > > set -x > > > > install_image > > + install_config > > + install_map > > install_hooks > > install_dtbs > > install_kmods > > @@ -69,6 +71,18 @@ install_image() { > > install_image_debug > > } > > > > +install_config() { > > + if [ "${ARCH}" != "um" ]; then > > + cp ${O}/.config ${deb_img_dir}/$(dirname ${kimage_path})/config-${krel} > > + fi > > +} > > + > > +install_map() { > > + if [ "${ARCH}" != "um" ]; then > > + cp ${O}/System.map ${deb_img_dir}/$(dirname ${kimage_path})/System.map-${krel} > > + fi > > +} > > + > > install_image_debug() { > > # Different tools want the image in different locations > > # perf > > > > I think this should be made configurable. Not every embedded system may > need or even want these. Can be on be default nevertheless, specifically > if that is Debian behavior. Sure. I believe that can be investigated and done as a separate patch. We are now trying to match the contents wrt Debian upstream/ the previous Linux build procedure as some of our downstream test cases rely on the config file in /boot. Thanks, Vijai Kumar K > > That said, we may also look into shrinking the dtb installations, only > packaging what the target actually needs. Unrelated to this patch, for sure. > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-03-18 5:53 ` vijai kumar @ 2020-03-18 7:34 ` Henning Schild 2020-03-18 13:03 ` vijai kumar 2020-03-18 13:21 ` [PATCH v2] " Vijai Kumar K 0 siblings, 2 replies; 28+ messages in thread From: Henning Schild @ 2020-03-18 7:34 UTC (permalink / raw) To: vijai kumar; +Cc: Jan Kiszka, isar-users, Vijai Kumar K On Wed, 18 Mar 2020 11:23:24 +0530 vijai kumar <vijaikumar.kanagarajan@gmail.com> wrote: > On Tue, Mar 17, 2020 at 11:02 PM Jan Kiszka <jan.kiszka@siemens.com> > wrote: > > > > On 17.03.20 18:14, Vijai Kumar K wrote: > > > Align with upstream debian linux-image package. Install the > > > config and System.map file to /boot directory. Skip installation > > > for User Mode Linux. > > > > > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > > > --- > > > .../linux/files/debian/isar/install.tmpl | 14 > > > ++++++++++++++ 1 file changed, 14 insertions(+) > > > > > > diff --git > > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > > > 12d592d..4e1f850 100644 --- > > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > > > -37,6 +37,8 @@ do_install() { set -x > > > > > > install_image Looks like the "um" guard could move here to only have it once. > > > + install_config > > > + install_map > > > install_hooks > > > install_dtbs > > > install_kmods > > > @@ -69,6 +71,18 @@ install_image() { > > > install_image_debug > > > } > > > > > > +install_config() { > > > + if [ "${ARCH}" != "um" ]; then > > > + cp ${O}/.config ${deb_img_dir}/$(dirname > > > ${kimage_path})/config-${krel} > > > + fi > > > +} > > > + > > > +install_map() { > > > + if [ "${ARCH}" != "um" ]; then > > > + cp ${O}/System.map ${deb_img_dir}/$(dirname > > > ${kimage_path})/System.map-${krel} > > > + fi > > > +} > > > + > > > install_image_debug() { > > > # Different tools want the image in different locations > > > # perf > > > > > > > I think this should be made configurable. Not every embedded system > > may need or even want these. Can be on be default nevertheless, > > specifically if that is Debian behavior. > > Sure. I believe that can be investigated and done as a separate patch. > We are now trying to match the contents wrt Debian upstream/ the > previous Linux build procedure as some of our downstream test cases > rely on the config file in /boot. If the system under test has CONFIG_IKCONFIG_PROC and is running the kernel, /proc/config.gz is probably the better source. For the config i really do not see a point to not ship it, its not too big. Some security gurus might argue that they do not want to ship it for obfuscation ... but i would not listen to them. I think your test should try /proc /boot and finally skip the test instead of fail it ;). Henning > Thanks, > Vijai Kumar K > > > > > That said, we may also look into shrinking the dtb installations, > > only packaging what the target actually needs. Unrelated to this > > patch, for sure. > > > > Jan > > > > -- > > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > > Corporate Competence Center Embedded Linux > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] linux-custom: Install config and map file to /boot 2020-03-18 7:34 ` Henning Schild @ 2020-03-18 13:03 ` vijai kumar 2020-03-18 13:21 ` [PATCH v2] " Vijai Kumar K 1 sibling, 0 replies; 28+ messages in thread From: vijai kumar @ 2020-03-18 13:03 UTC (permalink / raw) To: Henning Schild; +Cc: Jan Kiszka, isar-users, Vijai Kumar K On Wed, Mar 18, 2020 at 1:04 PM Henning Schild <henning.schild@siemens.com> wrote: > > On Wed, 18 Mar 2020 11:23:24 +0530 > vijai kumar <vijaikumar.kanagarajan@gmail.com> wrote: > > > On Tue, Mar 17, 2020 at 11:02 PM Jan Kiszka <jan.kiszka@siemens.com> > > wrote: > > > > > > On 17.03.20 18:14, Vijai Kumar K wrote: > > > > Align with upstream debian linux-image package. Install the > > > > config and System.map file to /boot directory. Skip installation > > > > for User Mode Linux. > > > > > > > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > > > > --- > > > > .../linux/files/debian/isar/install.tmpl | 14 > > > > ++++++++++++++ 1 file changed, 14 insertions(+) > > > > > > > > diff --git > > > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > > > > 12d592d..4e1f850 100644 --- > > > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > > > > -37,6 +37,8 @@ do_install() { set -x > > > > > > > > install_image > > Looks like the "um" guard could move here to only have it once. Yes. It could. I will send a v2. > > > > > + install_config > > > > + install_map > > > > install_hooks > > > > install_dtbs > > > > install_kmods > > > > @@ -69,6 +71,18 @@ install_image() { > > > > install_image_debug > > > > } > > > > > > > > +install_config() { > > > > + if [ "${ARCH}" != "um" ]; then > > > > + cp ${O}/.config ${deb_img_dir}/$(dirname > > > > ${kimage_path})/config-${krel} > > > > + fi > > > > +} > > > > + > > > > +install_map() { > > > > + if [ "${ARCH}" != "um" ]; then > > > > + cp ${O}/System.map ${deb_img_dir}/$(dirname > > > > ${kimage_path})/System.map-${krel} > > > > + fi > > > > +} > > > > + > > > > install_image_debug() { > > > > # Different tools want the image in different locations > > > > # perf > > > > > > > > > > I think this should be made configurable. Not every embedded system > > > may need or even want these. Can be on be default nevertheless, > > > specifically if that is Debian behavior. > > > > Sure. I believe that can be investigated and done as a separate patch. > > We are now trying to match the contents wrt Debian upstream/ the > > previous Linux build procedure as some of our downstream test cases > > rely on the config file in /boot. > > If the system under test has CONFIG_IKCONFIG_PROC and is running the > kernel, /proc/config.gz is probably the better source. > For the config i really do not see a point to not ship it, its not too > big. Some security gurus might argue that they do not want to ship it > for obfuscation ... but i would not listen to them. This is something we are considering. For now, we are relying on /boot/config*. I believe boards supported in CIP already have these configs enabled. So it should not be a problem for us to enable it for our boards too. Thanks, Vijai Kumar K > > I think your test should try /proc /boot and finally skip the test > instead of fail it ;). > > Henning > > > Thanks, > > Vijai Kumar K > > > > > > > > That said, we may also look into shrinking the dtb installations, > > > only packaging what the target actually needs. Unrelated to this > > > patch, for sure. > > > > > > Jan > > > > > > -- > > > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > > > Corporate Competence Center Embedded Linux > > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v2] linux-custom: Install config and map file to /boot 2020-03-18 7:34 ` Henning Schild 2020-03-18 13:03 ` vijai kumar @ 2020-03-18 13:21 ` Vijai Kumar K 2020-03-23 6:12 ` Jan Kiszka 1 sibling, 1 reply; 28+ messages in thread From: Vijai Kumar K @ 2020-03-18 13:21 UTC (permalink / raw) To: isar-users; +Cc: Vijai Kumar K Align with upstream debian linux-image package. Install the config and System.map file to /boot directory. Skip installation for User Mode Linux. Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> --- Changes in v2: - Moved um condition check as per Henning's comment .../linux/files/debian/isar/install.tmpl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index 12d592d..849da5e 100644 --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 +37,10 @@ do_install() { set -x install_image + if [ "${ARCH}" != "um" ]; then + install_config + install_map + fi install_hooks install_dtbs install_kmods @@ -69,6 +73,14 @@ install_image() { install_image_debug } +install_config() { + cp ${O}/.config ${deb_img_dir}/$(dirname ${kimage_path})/config-${krel} +} + +install_map() { + cp ${O}/System.map ${deb_img_dir}/$(dirname ${kimage_path})/System.map-${krel} +} + install_image_debug() { # Different tools want the image in different locations # perf -- 2.17.1 ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] linux-custom: Install config and map file to /boot 2020-03-18 13:21 ` [PATCH v2] " Vijai Kumar K @ 2020-03-23 6:12 ` Jan Kiszka 2020-03-23 6:53 ` Henning Schild 0 siblings, 1 reply; 28+ messages in thread From: Jan Kiszka @ 2020-03-23 6:12 UTC (permalink / raw) To: Vijai Kumar K, isar-users; +Cc: Vijai Kumar K On 18.03.20 14:21, Vijai Kumar K wrote: > Align with upstream debian linux-image package. Install the config and > System.map file to /boot directory. Skip installation for User Mode Linux. > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > --- > Changes in v2: > - Moved um condition check as per Henning's comment > > .../linux/files/debian/isar/install.tmpl | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > index 12d592d..849da5e 100644 > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > @@ -37,6 +37,10 @@ do_install() { > set -x > > install_image > + if [ "${ARCH}" != "um" ]; then > + install_config > + install_map > + fi > install_hooks > install_dtbs > install_kmods > @@ -69,6 +73,14 @@ install_image() { > install_image_debug > } > > +install_config() { > + cp ${O}/.config ${deb_img_dir}/$(dirname ${kimage_path})/config-${krel} > +} > + > +install_map() { > + cp ${O}/System.map ${deb_img_dir}/$(dirname ${kimage_path})/System.map-${krel} I think those cp calls should be install with proper modes, no? Jan > +} > + > install_image_debug() { > # Different tools want the image in different locations > # perf > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] linux-custom: Install config and map file to /boot 2020-03-23 6:12 ` Jan Kiszka @ 2020-03-23 6:53 ` Henning Schild 2020-03-23 6:55 ` Jan Kiszka 0 siblings, 1 reply; 28+ messages in thread From: Henning Schild @ 2020-03-23 6:53 UTC (permalink / raw) To: [ext] Jan Kiszka; +Cc: Vijai Kumar K, isar-users, Vijai Kumar K On Mon, 23 Mar 2020 07:12:00 +0100 "[ext] Jan Kiszka" <jan.kiszka@siemens.com> wrote: > On 18.03.20 14:21, Vijai Kumar K wrote: > > Align with upstream debian linux-image package. Install the config > > and System.map file to /boot directory. Skip installation for User > > Mode Linux. > > > > Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > > --- > > Changes in v2: > > - Moved um condition check as per Henning's comment > > > > .../linux/files/debian/isar/install.tmpl | 12 > > ++++++++++++ 1 file changed, 12 insertions(+) > > > > diff --git > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > > 12d592d..849da5e 100644 --- > > a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 > > +37,10 @@ do_install() { set -x > > install_image > > + if [ "${ARCH}" != "um" ]; then > > + install_config > > + install_map > > + fi > > install_hooks > > install_dtbs > > install_kmods > > @@ -69,6 +73,14 @@ install_image() { > > install_image_debug > > } > > > > +install_config() { > > + cp ${O}/.config ${deb_img_dir}/$(dirname > > ${kimage_path})/config-${krel} +} > > + > > +install_map() { > > + cp ${O}/System.map ${deb_img_dir}/$(dirname > > ${kimage_path})/System.map-${krel} > > I think those cp calls should be install with proper modes, no? I wanted to say that as well, but in fact the whole scripts seems to use a mix of cp and install and this one does not make things worse. Henning > Jan > > > +} > > + > > install_image_debug() { > > # Different tools want the image in different locations > > # perf > > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] linux-custom: Install config and map file to /boot 2020-03-23 6:53 ` Henning Schild @ 2020-03-23 6:55 ` Jan Kiszka 2020-03-23 7:49 ` vijai kumar 2020-03-23 9:13 ` Henning Schild 0 siblings, 2 replies; 28+ messages in thread From: Jan Kiszka @ 2020-03-23 6:55 UTC (permalink / raw) To: Henning Schild; +Cc: Vijai Kumar K, isar-users, Vijai Kumar K On 23.03.20 07:53, Henning Schild wrote: > On Mon, 23 Mar 2020 07:12:00 +0100 > "[ext] Jan Kiszka" <jan.kiszka@siemens.com> wrote: > >> On 18.03.20 14:21, Vijai Kumar K wrote: >>> Align with upstream debian linux-image package. Install the config >>> and System.map file to /boot directory. Skip installation for User >>> Mode Linux. >>> >>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> >>> --- >>> Changes in v2: >>> - Moved um condition check as per Henning's comment >>> >>> .../linux/files/debian/isar/install.tmpl | 12 >>> ++++++++++++ 1 file changed, 12 insertions(+) >>> >>> diff --git >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index >>> 12d592d..849da5e 100644 --- >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 >>> +37,10 @@ do_install() { set -x >>> install_image >>> + if [ "${ARCH}" != "um" ]; then >>> + install_config >>> + install_map >>> + fi >>> install_hooks >>> install_dtbs >>> install_kmods >>> @@ -69,6 +73,14 @@ install_image() { >>> install_image_debug >>> } >>> >>> +install_config() { >>> + cp ${O}/.config ${deb_img_dir}/$(dirname >>> ${kimage_path})/config-${krel} +} >>> + >>> +install_map() { >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname >>> ${kimage_path})/System.map-${krel} >> >> I think those cp calls should be install with proper modes, no? > > I wanted to say that as well, but in fact the whole scripts seems to > use a mix of cp and install and this one does not make things worse. Yes, there are 2 other cases that should be fixed, separately. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] linux-custom: Install config and map file to /boot 2020-03-23 6:55 ` Jan Kiszka @ 2020-03-23 7:49 ` vijai kumar 2020-03-23 9:13 ` Henning Schild 1 sibling, 0 replies; 28+ messages in thread From: vijai kumar @ 2020-03-23 7:49 UTC (permalink / raw) To: Jan Kiszka; +Cc: Henning Schild, isar-users, Vijai Kumar K On Mon, Mar 23, 2020 at 12:26 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: > > On 23.03.20 07:53, Henning Schild wrote: > > On Mon, 23 Mar 2020 07:12:00 +0100 > > "[ext] Jan Kiszka" <jan.kiszka@siemens.com> wrote: > > > >> On 18.03.20 14:21, Vijai Kumar K wrote: > >>> Align with upstream debian linux-image package. Install the config > >>> and System.map file to /boot directory. Skip installation for User > >>> Mode Linux. > >>> > >>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > >>> --- > >>> Changes in v2: > >>> - Moved um condition check as per Henning's comment > >>> > >>> .../linux/files/debian/isar/install.tmpl | 12 > >>> ++++++++++++ 1 file changed, 12 insertions(+) > >>> > >>> diff --git > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > >>> 12d592d..849da5e 100644 --- > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 > >>> +37,10 @@ do_install() { set -x > >>> install_image > >>> + if [ "${ARCH}" != "um" ]; then > >>> + install_config > >>> + install_map > >>> + fi > >>> install_hooks > >>> install_dtbs > >>> install_kmods > >>> @@ -69,6 +73,14 @@ install_image() { > >>> install_image_debug > >>> } > >>> > >>> +install_config() { > >>> + cp ${O}/.config ${deb_img_dir}/$(dirname > >>> ${kimage_path})/config-${krel} +} > >>> + > >>> +install_map() { > >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname > >>> ${kimage_path})/System.map-${krel} > >> > >> I think those cp calls should be install with proper modes, no? > > > > I wanted to say that as well, but in fact the whole scripts seems to > > use a mix of cp and install and this one does not make things worse. > > Yes, there are 2 other cases that should be fixed, separately. > > Jan I believe the permissions should be 644. Please correct me if I am wrong. Will send v3 with the install command. Thanks, Vijai Kumar K > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] linux-custom: Install config and map file to /boot 2020-03-23 6:55 ` Jan Kiszka 2020-03-23 7:49 ` vijai kumar @ 2020-03-23 9:13 ` Henning Schild 2020-03-23 9:24 ` vijai kumar 1 sibling, 1 reply; 28+ messages in thread From: Henning Schild @ 2020-03-23 9:13 UTC (permalink / raw) To: Jan Kiszka; +Cc: Vijai Kumar K, isar-users, Vijai Kumar K On Mon, 23 Mar 2020 07:55:58 +0100 Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 23.03.20 07:53, Henning Schild wrote: > > On Mon, 23 Mar 2020 07:12:00 +0100 > > "[ext] Jan Kiszka" <jan.kiszka@siemens.com> wrote: > > > >> On 18.03.20 14:21, Vijai Kumar K wrote: > >>> Align with upstream debian linux-image package. Install the config > >>> and System.map file to /boot directory. Skip installation for User > >>> Mode Linux. > >>> > >>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > >>> --- > >>> Changes in v2: > >>> - Moved um condition check as per Henning's comment > >>> > >>> .../linux/files/debian/isar/install.tmpl | 12 > >>> ++++++++++++ 1 file changed, 12 insertions(+) > >>> > >>> diff --git > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > >>> 12d592d..849da5e 100644 --- > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > >>> -37,6 +37,10 @@ do_install() { set -x > >>> install_image > >>> + if [ "${ARCH}" != "um" ]; then > >>> + install_config > >>> + install_map > >>> + fi > >>> install_hooks > >>> install_dtbs > >>> install_kmods > >>> @@ -69,6 +73,14 @@ install_image() { > >>> install_image_debug > >>> } > >>> > >>> +install_config() { > >>> + cp ${O}/.config ${deb_img_dir}/$(dirname > >>> ${kimage_path})/config-${krel} +} > >>> + > >>> +install_map() { > >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname > >>> ${kimage_path})/System.map-${krel} > >> > >> I think those cp calls should be install with proper modes, no? > > > > I wanted to say that as well, but in fact the whole scripts seems to > > use a mix of cp and install and this one does not make things > > worse. > > Yes, there are 2 other cases that should be fixed, separately. I would suggest we ask Vijai to do all on top, instead of changing here and forgetting the 2 cases? Or maybe just the two on top as part of the series? Vijai what do you think? Henning > Jan > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] linux-custom: Install config and map file to /boot 2020-03-23 9:13 ` Henning Schild @ 2020-03-23 9:24 ` vijai kumar 2020-03-23 10:40 ` Henning Schild 0 siblings, 1 reply; 28+ messages in thread From: vijai kumar @ 2020-03-23 9:24 UTC (permalink / raw) To: Henning Schild; +Cc: Jan Kiszka, isar-users, Vijai Kumar K On Mon, Mar 23, 2020 at 2:43 PM Henning Schild <henning.schild@siemens.com> wrote: > > On Mon, 23 Mar 2020 07:55:58 +0100 > Jan Kiszka <jan.kiszka@siemens.com> wrote: > > > On 23.03.20 07:53, Henning Schild wrote: > > > On Mon, 23 Mar 2020 07:12:00 +0100 > > > "[ext] Jan Kiszka" <jan.kiszka@siemens.com> wrote: > > > > > >> On 18.03.20 14:21, Vijai Kumar K wrote: > > >>> Align with upstream debian linux-image package. Install the config > > >>> and System.map file to /boot directory. Skip installation for User > > >>> Mode Linux. > > >>> > > >>> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> > > >>> --- > > >>> Changes in v2: > > >>> - Moved um condition check as per Henning's comment > > >>> > > >>> .../linux/files/debian/isar/install.tmpl | 12 > > >>> ++++++++++++ 1 file changed, 12 insertions(+) > > >>> > > >>> diff --git > > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index > > >>> 12d592d..849da5e 100644 --- > > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > > >>> -37,6 +37,10 @@ do_install() { set -x > > >>> install_image > > >>> + if [ "${ARCH}" != "um" ]; then > > >>> + install_config > > >>> + install_map > > >>> + fi > > >>> install_hooks > > >>> install_dtbs > > >>> install_kmods > > >>> @@ -69,6 +73,14 @@ install_image() { > > >>> install_image_debug > > >>> } > > >>> > > >>> +install_config() { > > >>> + cp ${O}/.config ${deb_img_dir}/$(dirname > > >>> ${kimage_path})/config-${krel} +} > > >>> + > > >>> +install_map() { > > >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname > > >>> ${kimage_path})/System.map-${krel} > > >> > > >> I think those cp calls should be install with proper modes, no? > > > > > > I wanted to say that as well, but in fact the whole scripts seems to > > > use a mix of cp and install and this one does not make things > > > worse. > > > > Yes, there are 2 other cases that should be fixed, separately. > > I would suggest we ask Vijai to do all on top, instead of changing here > and forgetting the 2 cases? > > Or maybe just the two on top as part of the series? Vijai what do you > think? Hi Henning, We could address the two cases here and rest two cases as a separate patch. I could update this patch(v3) and can send a separate patch for the remaining two cases. Is this okay for all? Thanks, Vijai Kumar K > > Henning > > > Jan > > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v2] linux-custom: Install config and map file to /boot 2020-03-23 9:24 ` vijai kumar @ 2020-03-23 10:40 ` Henning Schild 2020-03-23 13:40 ` [PATCH v3 1/2] " Vijai Kumar K 0 siblings, 1 reply; 28+ messages in thread From: Henning Schild @ 2020-03-23 10:40 UTC (permalink / raw) To: vijai kumar; +Cc: Jan Kiszka, isar-users, Vijai Kumar K On Mon, 23 Mar 2020 14:54:05 +0530 vijai kumar <vijaikumar.kanagarajan@gmail.com> wrote: > On Mon, Mar 23, 2020 at 2:43 PM Henning Schild > <henning.schild@siemens.com> wrote: > > > > On Mon, 23 Mar 2020 07:55:58 +0100 > > Jan Kiszka <jan.kiszka@siemens.com> wrote: > > > > > On 23.03.20 07:53, Henning Schild wrote: > > > > On Mon, 23 Mar 2020 07:12:00 +0100 > > > > "[ext] Jan Kiszka" <jan.kiszka@siemens.com> wrote: > > > > > > > >> On 18.03.20 14:21, Vijai Kumar K wrote: > > > >>> Align with upstream debian linux-image package. Install the > > > >>> config and System.map file to /boot directory. Skip > > > >>> installation for User Mode Linux. > > > >>> > > > >>> Signed-off-by: Vijai Kumar K > > > >>> <Vijaikumar_Kanagarajan@mentor.com> --- > > > >>> Changes in v2: > > > >>> - Moved um condition check as per Henning's comment > > > >>> > > > >>> .../linux/files/debian/isar/install.tmpl | 12 > > > >>> ++++++++++++ 1 file changed, 12 insertions(+) > > > >>> > > > >>> diff --git > > > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > >>> index 12d592d..849da5e 100644 --- > > > >>> a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ > > > >>> b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ > > > >>> -37,6 +37,10 @@ do_install() { set -x > > > >>> install_image > > > >>> + if [ "${ARCH}" != "um" ]; then > > > >>> + install_config > > > >>> + install_map > > > >>> + fi > > > >>> install_hooks > > > >>> install_dtbs > > > >>> install_kmods > > > >>> @@ -69,6 +73,14 @@ install_image() { > > > >>> install_image_debug > > > >>> } > > > >>> > > > >>> +install_config() { > > > >>> + cp ${O}/.config ${deb_img_dir}/$(dirname > > > >>> ${kimage_path})/config-${krel} +} > > > >>> + > > > >>> +install_map() { > > > >>> + cp ${O}/System.map ${deb_img_dir}/$(dirname > > > >>> ${kimage_path})/System.map-${krel} > > > >> > > > >> I think those cp calls should be install with proper modes, > > > >> no? > > > > > > > > I wanted to say that as well, but in fact the whole scripts > > > > seems to use a mix of cp and install and this one does not make > > > > things worse. > > > > > > Yes, there are 2 other cases that should be fixed, separately. > > > > I would suggest we ask Vijai to do all on top, instead of changing > > here and forgetting the 2 cases? > > > > Or maybe just the two on top as part of the series? Vijai what do > > you think? > > Hi Henning, > > We could address the two cases here and rest two cases as a separate > patch. I could update this patch(v3) and can send a separate patch for > the remaining two cases. > > Is this okay for all? If you are willing to do the fix i would suggest to include it into your series instead of sending it alone. Henning > Thanks, > Vijai Kumar K > > > > > Henning > > > > > Jan > > > > > ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-03-23 10:40 ` Henning Schild @ 2020-03-23 13:40 ` Vijai Kumar K 2020-03-23 13:40 ` [PATCH v3 2/2] meta/recipes-kernel: Replace cp with install Vijai Kumar K 2020-04-17 15:05 ` [PATCH v3 1/2] linux-custom: Install config and map file to /boot Baurzhan Ismagulov 0 siblings, 2 replies; 28+ messages in thread From: Vijai Kumar K @ 2020-03-23 13:40 UTC (permalink / raw) To: isar-users; +Cc: Vijai Kumar K Align with upstream debian linux-image package. Install the config and System.map file to /boot directory. Skip installation for User Mode Linux. Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> --- Changes in v3: - Used install instead of cp in p1 - Introduced p2 which replaces cp with install for kernel image copy Changes in v2: - Moved um condition check as per Henning's comment .../linux/files/debian/isar/install.tmpl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index 12d592d..eae3f6b 100644 --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -37,6 +37,10 @@ do_install() { set -x install_image + if [ "${ARCH}" != "um" ]; then + install_config + install_map + fi install_hooks install_dtbs install_kmods @@ -69,6 +73,14 @@ install_image() { install_image_debug } +install_config() { + install -m 644 ${O}/.config ${deb_img_dir}/$(dirname ${kimage_path})/config-${krel} +} + +install_map() { + install -m 644 ${O}/System.map ${deb_img_dir}/$(dirname ${kimage_path})/System.map-${krel} +} + install_image_debug() { # Different tools want the image in different locations # perf -- 2.17.1 ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v3 2/2] meta/recipes-kernel: Replace cp with install 2020-03-23 13:40 ` [PATCH v3 1/2] " Vijai Kumar K @ 2020-03-23 13:40 ` Vijai Kumar K 2020-04-17 15:05 ` [PATCH v3 1/2] linux-custom: Install config and map file to /boot Baurzhan Ismagulov 1 sibling, 0 replies; 28+ messages in thread From: Vijai Kumar K @ 2020-03-23 13:40 UTC (permalink / raw) To: isar-users; +Cc: Vijai Kumar K Use install to copy the kernel image with necessary permissions instead of using plain cp. Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> --- meta/recipes-kernel/linux/files/debian/isar/install.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl index eae3f6b..8eca4c7 100644 --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl @@ -62,7 +62,7 @@ EOF install_image() { install -m 755 -d ${deb_img_dir}/$(dirname ${kimage_path}) - cp ${O}/${kimage} ${deb_img_dir}/${kimage_path} + install -m 644 ${O}/${kimage} ${deb_img_dir}/${kimage_path} # Make sure arm64 and riscv kernels are decompressed if [ "${ARCH}" = "arm64" -o "${ARCH}" = "riscv" ]; then @@ -85,7 +85,7 @@ install_image_debug() { # Different tools want the image in different locations # perf mkdir -p ${deb_dbg_dir}/usr/lib/debug/lib/modules/${krel}/ - cp ${O}/vmlinux ${deb_dbg_dir}/usr/lib/debug/lib/modules/${krel}/ + install -m 644 ${O}/vmlinux ${deb_dbg_dir}/usr/lib/debug/lib/modules/${krel}/ # systemtap mkdir -p ${deb_dbg_dir}/usr/lib/debug/boot/ ln -s ../lib/modules/$version/vmlinux ${deb_dbg_dir}/usr/lib/debug/boot/vmlinux-${krel} -- 2.17.1 ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-03-23 13:40 ` [PATCH v3 1/2] " Vijai Kumar K 2020-03-23 13:40 ` [PATCH v3 2/2] meta/recipes-kernel: Replace cp with install Vijai Kumar K @ 2020-04-17 15:05 ` Baurzhan Ismagulov 2020-04-17 18:44 ` vijai kumar 1 sibling, 1 reply; 28+ messages in thread From: Baurzhan Ismagulov @ 2020-04-17 15:05 UTC (permalink / raw) To: isar-users On Mon, Mar 23, 2020 at 07:10:31PM +0530, Vijai Kumar K wrote: > Align with upstream debian linux-image package. Install the config and > System.map file to /boot directory. Skip installation for User Mode Linux. Applied to next, thanks. With kind regards, Baurzhan. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-04-17 15:05 ` [PATCH v3 1/2] linux-custom: Install config and map file to /boot Baurzhan Ismagulov @ 2020-04-17 18:44 ` vijai kumar 2020-04-17 18:59 ` vijai kumar 0 siblings, 1 reply; 28+ messages in thread From: vijai kumar @ 2020-04-17 18:44 UTC (permalink / raw) To: isar-users, Baurzhan Ismagulov On Fri, Apr 17, 2020 at 8:35 PM Baurzhan Ismagulov <ibr@radix50.net> wrote: > > On Mon, Mar 23, 2020 at 07:10:31PM +0530, Vijai Kumar K wrote: > > Align with upstream debian linux-image package. Install the config and > > System.map file to /boot directory. Skip installation for User Mode Linux. > > Applied to next, thanks. Hi Baurzhan, Just checked the next branch, these commit's author name has my personal email id instead of official one.Signed-off & author email don't match now. I do send the patches via my gmail(easier) but the author has always been my official email address. Ah, one more older commit of mine too has the same issue. Not sure why. https://github.com/ilbers/isar/commit/b3e7b4eae3a0e41abd525b01ceb9484d199b3cc5 Thanks, Vijai Kumar K > > With kind regards, > Baurzhan. > > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20200417150529.fdli36qgg5mb6qw5%40yssyq.m.ilbers.de. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-04-17 18:44 ` vijai kumar @ 2020-04-17 18:59 ` vijai kumar 2020-04-20 9:28 ` Baurzhan Ismagulov 0 siblings, 1 reply; 28+ messages in thread From: vijai kumar @ 2020-04-17 18:59 UTC (permalink / raw) To: isar-users, Baurzhan Ismagulov On Sat, Apr 18, 2020 at 12:14 AM vijai kumar <vijaikumar.kanagarajan@gmail.com> wrote: > > On Fri, Apr 17, 2020 at 8:35 PM Baurzhan Ismagulov <ibr@radix50.net> wrote: > > > > On Mon, Mar 23, 2020 at 07:10:31PM +0530, Vijai Kumar K wrote: > > > Align with upstream debian linux-image package. Install the config and > > > System.map file to /boot directory. Skip installation for User Mode Linux. > > > > Applied to next, thanks. > > Hi Baurzhan, > > Just checked the next branch, these commit's author name has my > personal email id instead of official one.Signed-off & author email > don't match now. > I do send the patches via my gmail(easier) but the author has always > been my official email address. > > Ah, one more older commit of mine too has the same issue. Not sure why. > > https://github.com/ilbers/isar/commit/b3e7b4eae3a0e41abd525b01ceb9484d199b3cc5 > My gitconfig is missing the from entry I had earlier. That should be the root-cause for this issue I guess. > > Thanks, > Vijai Kumar K > > > > > With kind regards, > > Baurzhan. > > > > -- > > You received this message because you are subscribed to the Google Groups "isar-users" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20200417150529.fdli36qgg5mb6qw5%40yssyq.m.ilbers.de. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-04-17 18:59 ` vijai kumar @ 2020-04-20 9:28 ` Baurzhan Ismagulov 2020-04-20 10:07 ` vijai kumar 0 siblings, 1 reply; 28+ messages in thread From: Baurzhan Ismagulov @ 2020-04-20 9:28 UTC (permalink / raw) To: isar-users Hello Vijai Kumar, On Sat, Apr 18, 2020 at 12:29:50AM +0530, vijai kumar wrote: > My gitconfig is missing the from entry I had earlier. That should be > the root-cause for this issue I guess. Yes, e.g. https://groups.google.com/d/msg/isar-users/knMKY-9b5Nw/aDIpgN1MCQAJ has From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com> as the first line, and the latter patches don't. With kind regards, Baurzhan. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-04-20 9:28 ` Baurzhan Ismagulov @ 2020-04-20 10:07 ` vijai kumar 2020-04-20 16:03 ` Baurzhan Ismagulov 2020-04-20 19:51 ` Henning Schild 0 siblings, 2 replies; 28+ messages in thread From: vijai kumar @ 2020-04-20 10:07 UTC (permalink / raw) To: isar-users [-- Attachment #1.1: Type: text/plain, Size: 665 bytes --] On Monday, April 20, 2020 at 2:58:18 PM UTC+5:30, Baurzhan Ismagulov wrote: > > Hello Vijai Kumar, > > On Sat, Apr 18, 2020 at 12:29:50AM +0530, vijai kumar wrote: > > My gitconfig is missing the from entry I had earlier. That should be > > the root-cause for this issue I guess. > > Yes, e.g. > https://groups.google.com/d/msg/isar-users/knMKY-9b5Nw/aDIpgN1MCQAJ > has From: Vijai Kumar K <Vijaikumar_...@mentor.com <javascript:>> as the > first line, > and the latter patches don't. > Yes. Sorry about that. I have fixed my configuration. Here after it should come with a proper from. Thanks, Vijai Kumar K > > With kind regards, > Baurzhan. > [-- Attachment #1.2: Type: text/html, Size: 1598 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-04-20 10:07 ` vijai kumar @ 2020-04-20 16:03 ` Baurzhan Ismagulov 2020-04-20 19:46 ` Henning Schild 2020-04-20 19:51 ` Henning Schild 1 sibling, 1 reply; 28+ messages in thread From: Baurzhan Ismagulov @ 2020-04-20 16:03 UTC (permalink / raw) To: isar-users On Mon, Apr 20, 2020 at 03:07:29AM -0700, vijai kumar wrote: > > Yes, e.g. > > https://groups.google.com/d/msg/isar-users/knMKY-9b5Nw/aDIpgN1MCQAJ > > has From: Vijai Kumar K <Vijaikumar_...@mentor.com <javascript:>> as the > > first line, > > and the latter patches don't. > > Yes. Sorry about that. I have fixed my configuration. Here after it should > come with a proper from. No problem! Just an explanation how one could verify that by looking at the patch on the list. With kind regards, Baurzhan. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-04-20 16:03 ` Baurzhan Ismagulov @ 2020-04-20 19:46 ` Henning Schild 0 siblings, 0 replies; 28+ messages in thread From: Henning Schild @ 2020-04-20 19:46 UTC (permalink / raw) To: Baurzhan Ismagulov; +Cc: isar-users Am Mon, 20 Apr 2020 18:03:16 +0200 schrieb Baurzhan Ismagulov <ibr@radix50.net>: > On Mon, Apr 20, 2020 at 03:07:29AM -0700, vijai kumar wrote: > > > Yes, e.g. > > > https://groups.google.com/d/msg/isar-users/knMKY-9b5Nw/aDIpgN1MCQAJ > > > has From: Vijai Kumar K <Vijaikumar_...@mentor.com <javascript:>> > > > as the first line, > > > and the latter patches don't. > > > > Yes. Sorry about that. I have fixed my configuration. Here after it > > should come with a proper from. > > No problem! Just an explanation how one could verify that by looking > at the patch on the list. That is not the duty of the maintainer. If contributors get their email wrong its their problem. If weird IT of contributors prevents them from sending raw emails, that is a problem of those companies. Because their contributions will not show up in i.e. "git shortlog -sne | grep company" ... so they might not get the "credits" ... whatever that means to those companies should not be the maintainers business. It might be a nice finding and the maintainer could comment on it, but you should not waste your time. On the list you will see the "From" header of the mail, an override would be an addition "From" in the body. If the "From" in the mail is not the "Signed-off" that would be an indication. Once you "git am" you can see the same "problem" in your git. Henning > With kind regards, > Baurzhan. > ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 1/2] linux-custom: Install config and map file to /boot 2020-04-20 10:07 ` vijai kumar 2020-04-20 16:03 ` Baurzhan Ismagulov @ 2020-04-20 19:51 ` Henning Schild 1 sibling, 0 replies; 28+ messages in thread From: Henning Schild @ 2020-04-20 19:51 UTC (permalink / raw) To: vijai kumar; +Cc: isar-users Am Mon, 20 Apr 2020 03:07:29 -0700 schrieb vijai kumar <vijaikumar.kanagarajan@gmail.com>: > On Monday, April 20, 2020 at 2:58:18 PM UTC+5:30, Baurzhan Ismagulov > wrote: > > > > Hello Vijai Kumar, > > > > On Sat, Apr 18, 2020 at 12:29:50AM +0530, vijai kumar wrote: > > > My gitconfig is missing the from entry I had earlier. That should > > > be the root-cause for this issue I guess. > > > > Yes, e.g. > > https://groups.google.com/d/msg/isar-users/knMKY-9b5Nw/aDIpgN1MCQAJ > > has From: Vijai Kumar K <Vijaikumar_...@mentor.com <javascript:>> > > as the first line, > > and the latter patches don't. > > > > Yes. Sorry about that. I have fixed my configuration. Here after it > should come with a proper from. I configured my git client to always include the additional "From" and even patched it to even include it if it was the original "From". https://github.com/henning-schild/git/commit/ca44f026a31537477e66559f0bf0f3acd2deecdf Henning > Thanks, > Vijai Kumar K > > > > > > With kind regards, > > Baurzhan. > > > ^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2020-04-20 19:51 UTC | newest] Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-17 17:14 [PATCH] linux-custom: Install config and map file to /boot Vijai Kumar K 2020-03-17 17:19 ` vijai kumar 2020-03-17 17:39 ` Jan Kiszka 2020-03-25 7:07 ` cedric_hombourger 2020-04-03 7:28 ` vijai kumar 2020-04-03 7:29 ` vijai kumar 2020-03-17 17:32 ` Jan Kiszka 2020-03-18 5:53 ` vijai kumar 2020-03-18 7:34 ` Henning Schild 2020-03-18 13:03 ` vijai kumar 2020-03-18 13:21 ` [PATCH v2] " Vijai Kumar K 2020-03-23 6:12 ` Jan Kiszka 2020-03-23 6:53 ` Henning Schild 2020-03-23 6:55 ` Jan Kiszka 2020-03-23 7:49 ` vijai kumar 2020-03-23 9:13 ` Henning Schild 2020-03-23 9:24 ` vijai kumar 2020-03-23 10:40 ` Henning Schild 2020-03-23 13:40 ` [PATCH v3 1/2] " Vijai Kumar K 2020-03-23 13:40 ` [PATCH v3 2/2] meta/recipes-kernel: Replace cp with install Vijai Kumar K 2020-04-17 15:05 ` [PATCH v3 1/2] linux-custom: Install config and map file to /boot Baurzhan Ismagulov 2020-04-17 18:44 ` vijai kumar 2020-04-17 18:59 ` vijai kumar 2020-04-20 9:28 ` Baurzhan Ismagulov 2020-04-20 10:07 ` vijai kumar 2020-04-20 16:03 ` Baurzhan Ismagulov 2020-04-20 19:46 ` Henning Schild 2020-04-20 19:51 ` Henning Schild
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox