Re: [PATCH 1/2] meta-isar: example-raw: Fix misuse of ${S}

[Henning Schild <henning.schild@siemens.com>]

Am Fri, 3 Apr 2020 17:02:56 +0200
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> We shall install into ${D}, not ${S}. This will break once dpkg-raw
> makes both deviate.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta-isar/recipes-app/example-raw/example-raw_0.3.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.3.bb
> b/meta-isar/recipes-app/example-raw/example-raw_0.3.bb index
> e4921709..21664642 100644 ---
> a/meta-isar/recipes-app/example-raw/example-raw_0.3.bb +++
> b/meta-isar/recipes-app/example-raw/example-raw_0.3.bb @@ -35,10
> +35,10 @@ do_install() { bbnote "A HOME entry for everyone ...
> created after this is installed" echo "hello skel" >
> ${WORKDIR}/${PN}-isar-skel.txt install -v -d ${D}/etc/skel/
> -	install -v -m 644 ${WORKDIR}/${PN}-isar-skel.txt
> ${S}/etc/skel/
> +	install -v -m 644 ${WORKDIR}/${PN}-isar-skel.txt
> ${D}/etc/skel/ 
>  	bbnote "A user-specific HOME entry"
>  	echo "hello isar" > ${WORKDIR}/${PN}-isar.txt
>  	install -v -d ${D}/var/lib/isar/
> -	install -v -m 644 ${WORKDIR}/${PN}-isar.txt
> ${S}/var/lib/isar/
> +	install -v -m 644 ${WORKDIR}/${PN}-isar.txt
> ${D}/var/lib/isar/ }

While this is correct it strongly suggests we will see similar problems
in downstream layers once the other patch gets applied.

We do not actually change the API, but i think an entry in the
changelog might still be a good idea.

Henning