From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6811501080263786496 X-Received: by 2002:a50:ce58:: with SMTP id k24mr19022673edj.218.1586847741669; Tue, 14 Apr 2020 00:02:21 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c818:: with SMTP id a24ls2126209edt.4.gmail; Tue, 14 Apr 2020 00:02:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKE/Zx8T63kdckVYHrBomGWNZERz8tlCShZX9qPvYYxDv+RwRVgDo2EqG7C+An3zbSSr64G X-Received: by 2002:a50:af85:: with SMTP id h5mr19493634edd.300.1586847741141; Tue, 14 Apr 2020 00:02:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586847741; cv=none; d=google.com; s=arc-20160816; b=rn/6gf+KPOD+Fzg6VRwfPeTwN3aagqYKk7wbL4US4JsZfJ4ZNmh39jPqrk8q84xnHn 7jEC0Ks0wR7xtLR0gi17I76XuHUsGbeiN7/4muSOxVRrzMzLaIifpSgTTF3fgu0Br3Va gUjxBkUVc3+Nv4Dm2LiGM0PGnAddyvXnte+rvqM9dZAxCQj543MAxbT2+PfmtRhKfNVy 6JtADjg3kZsQK4evWpASCBdE2PWum9V/9Zl2k1uYN0+ZrV5k/1+eYzgiF4XCC1BhtPrG 1r1kPfNql9cif2PvyIdp+G0d9IlStptSIA3h1WxfRXR4ewoH5u60AG94bx87t1LnFkeo f71Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=fAM15aIoP3TFRD3U0E9A6F92i0aC6DEHroLHoa35RXE=; b=tAvtWPI8OyUYvHUgcOnMm3+o4NTc6MBzYYLNXiTlcLdUQOJgAS0xc/aUzgDlxkca9G QIV21k+EB2yAFIlnhrAuqRzsP2jI9IrIYjAF8v+H2rFGUfciauNy9FLPqBXBjhIa17Ns LgLAVZ8QZjQcjELOFfSv8IT7VAtwX7zrqpANHsDS/Eq4drAvyFIseEZfqXHsltuLjCP3 R5bx9I+WaBoORL/bL5qraT834s3wxAPty2iIMMQGIZJPqHd+rkStlUqqJhR9K91aewCi y6HYBsOCZdlLU+7GzizvffkqzWqMjy4lPQIwpI5hnT4Tm7iNYhLIMQecmKGskCQ85qat aWeA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id i2si348799edn.2.2020.04.14.00.02.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2020 00:02:21 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 03E72Khb020982 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Apr 2020 09:02:20 +0200 Received: from md1za8fc.ad001.siemens.net ([139.22.36.226]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 03E72I9U009498; Tue, 14 Apr 2020 09:02:19 +0200 Date: Tue, 14 Apr 2020 09:02:12 +0200 From: Henning Schild To: Jan Kiszka Cc: isar-users , , Subject: Re: [PATCH 1/2] meta-isar: example-raw: Fix misuse of ${S} Message-ID: <20200414090212.57b9d9cf@md1za8fc.ad001.siemens.net> In-Reply-To: <492d3274ed96f0fe39ff50a3c8ddd9ad45f66830.1585926177.git.jan.kiszka@siemens.com> References: <492d3274ed96f0fe39ff50a3c8ddd9ad45f66830.1585926177.git.jan.kiszka@siemens.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: j3jymeRb44hy Am Fri, 3 Apr 2020 17:02:56 +0200 schrieb Jan Kiszka : > From: Jan Kiszka > > We shall install into ${D}, not ${S}. This will break once dpkg-raw > makes both deviate. > > Signed-off-by: Jan Kiszka > --- > meta-isar/recipes-app/example-raw/example-raw_0.3.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.3.bb > b/meta-isar/recipes-app/example-raw/example-raw_0.3.bb index > e4921709..21664642 100644 --- > a/meta-isar/recipes-app/example-raw/example-raw_0.3.bb +++ > b/meta-isar/recipes-app/example-raw/example-raw_0.3.bb @@ -35,10 > +35,10 @@ do_install() { bbnote "A HOME entry for everyone ... > created after this is installed" echo "hello skel" > > ${WORKDIR}/${PN}-isar-skel.txt install -v -d ${D}/etc/skel/ > - install -v -m 644 ${WORKDIR}/${PN}-isar-skel.txt > ${S}/etc/skel/ > + install -v -m 644 ${WORKDIR}/${PN}-isar-skel.txt > ${D}/etc/skel/ > bbnote "A user-specific HOME entry" > echo "hello isar" > ${WORKDIR}/${PN}-isar.txt > install -v -d ${D}/var/lib/isar/ > - install -v -m 644 ${WORKDIR}/${PN}-isar.txt > ${S}/var/lib/isar/ > + install -v -m 644 ${WORKDIR}/${PN}-isar.txt > ${D}/var/lib/isar/ } While this is correct it strongly suggests we will see similar problems in downstream layers once the other patch gets applied. We do not actually change the API, but i think an entry in the changelog might still be a good idea. Henning