Re: [PATCHv8 05/29] base-apt: add deb-src packages as well

[Henning Schild <henning.schild@siemens.com>]

On Tue, 14 Apr 2020 14:40:18 +0530
vijai kumar <vijaikumar.kanagarajan@gmail.com> wrote:

> On Tue, Apr 14, 2020 at 12:24 PM Henning Schild
> <henning.schild@siemens.com> wrote:
> >
> > Am Fri, 10 Apr 2020 20:31:27 +0530
> > schrieb vijai kumar <vijaikumar.kanagarajan@gmail.com>:
> >  
> > > On Thu, Mar 26, 2020 at 7:13 PM Henning Schild
> > > <henning.schild@siemens.com> wrote:  
> > > >
> > > > From: Henning Schild <henning.schild@siemens.com>
> > > >
> > > > So far the deb-src packages downloaded via "apt://" where not
> > > > cached. This commit fixes that and includes those packages into
> > > > the cache.
> > > >
> > > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > > ---
> > > >  meta/classes/base-apt-helper.bbclass       |  7 +++++++
> > > >  meta/classes/image-cache-extension.bbclass |  4 ++++
> > > >  meta/classes/repository.bbclass            | 14 ++++++++++++++
> > > >  3 files changed, 25 insertions(+)  
> > >  
> > > > +    reprepro -b "${dir}" --dbdir "${dbdir}" -C main -P source \
> > > > +        includedsc "${codename}" \  
> > >
> > >
> > > Hi Henning,
> > >
> > > Any specific issue you faced which prompted you to use -P source?
> > > Just trying to understand why priority is source here.  
> 
> I had an issue with section, wanted to know
> >
> > I honestly do not remember why that is there. Just looking at the
> > manpage its seems there will be some guessing going on for "section"
> > and "priority" if they are not given. Maybe i ran into a case where
> > the prio could not be guessed or was incorrect ... but i am really
> > just guessing myself.
> >
> > Is that prio incorrect or does it differ from what other repos have?
> >
> > If we are talking about
> > https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities
> >
> > "source" does not seem to be a valid value.
> >
> > You probably ran into some sort if issue and did not just stumble
> > over this line. Maybe you explaining your initial problem will help
> > understand how to proceed here.  
> 
> Hi Henning,
> 
> Yes. I had an issue with adding an source package(makedev) to repo. It
> complains of not able to find a valid Section. Then I looked back at
> the man page, which says it is guessing the Section and Priority.
> Looking at the code, seems like you have taken care of overriding
> Priority.
> 
> I believe you have taken that input from the 'Debian repository
> format' wiki[1]? which suggests to use 'source' as an alternative. For
> section there is no such recommendation though.

It is possible that i took the same path and came up with the
implementation we have, i do not remember anymore.

> So, I am thinking to use either the value 'source' or '-' as in [2].
> Since those are optional fields, right now, I am planning to skip
> looking into provisions to extract them from the dsc file (something
> like dscextract). I don't find any issue in these values for section
> and priority, do you see any?

I would suggest you play with possible values for your case. Later run
them against CI. In a next step find why a certain implementation works
and why others do not. That will hopefully lead to a correct
implementation and a meaningful justification (commit message).

Henning

> [1] https://wiki.debian.org/DebianRepository/Format
> [2]
> https://www.debian.org/doc/debian-policy/ch-controlfields.html#files
> 
> Thanks,
> Vijai Kumar K
> 
> 
> >
> > Henning
> >  
> > > Thanks,
> > > Vijai Kumar K
> > >
> > >  
> > > > You received this message because you are subscribed to the
> > > > Google Groups "isar-users" group. To unsubscribe from this
> > > > group and stop receiving emails from it, send an email to
> > > > isar-users+unsubscribe@googlegroups.com. To view this
> > > > discussion on the web visit
> > > > https://groups.google.com/d/msgid/isar-users/20200326134325.8672-6-henning.schild%40siemens.com.
> > > >  
> >