Re: [RFC PATCH 1/1] image-postproc-extension: remove ssh-host-keys

[Baurzhan Ismagulov <ibr@radix50.net>]

Hello Quirin,

On Fri, Mar 13, 2020 at 02:40:28PM +0100, Q. Gylstorff wrote:
> Add the option to remove all ssh_host_keys during image_postprocessing.
> This ensures that images with read-only rootfs or overlays use the
> keys generated during the image generation.
> 
> sshd-regen-keys: create new ssh keys if the keys do not exit

The change makes sense to me. Normally I prefer static generation, but this
isn't possible, since the image should be flashed to multiple devices. In that
case, keeping keys in the image doesn't make sense.

Given that, should this be an IMAGE_FEATURE? Does anything speak against always
removing the sshd keys during the image generation? Opinions welcome.

If it remains an IMAGE_FEATURE, I think we should describe it in the user
manual.

Regarding the patch: We've fixed the following issues, I'll send a v2
suggestion.

* Commit comment: "exit" -> "exist".

* Inconsistent indentation in meta/classes/image-postproc-extension.bbclass:
  Fixed to 4.

* meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh: echo "Removing
  keys ..." doesn't apply anymore: Removed.

With kind regards,
Baurzhan.