From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6802611076497145856 X-Received: by 2002:a2e:4942:: with SMTP id b2mr2582361ljd.135.1587137408394; Fri, 17 Apr 2020 08:30:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b883:: with SMTP id r3ls532866ljp.2.gmail; Fri, 17 Apr 2020 08:30:07 -0700 (PDT) X-Google-Smtp-Source: APiQypIDVfz5IF67DU3KtzeuhbPl2HMe0sSP8ljKKP8iGTQircr6tBUfO4s/iS2ncHl7u+uO7eE0 X-Received: by 2002:a2e:96c4:: with SMTP id d4mr2617365ljj.19.1587137407553; Fri, 17 Apr 2020 08:30:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587137407; cv=none; d=google.com; s=arc-20160816; b=fvon3IdkYDAWmeEOCcT9jERbv6cxZjElH7uTCX6EAqFm4AOgpgHrbtvl3MlyGYyGTV GsBkSEfxeXiIGItGJTTF6vA5P/EeszJU4Fp6MFB3SjYhxfJgWu/tKf4PNmy3qpgMAgo2 iLnvR1zgalPr6DCWDWbdSSdo0ZlkpNOvQJA8oorHHQmIBT274tm+Xn9jBxcKmgySeKoK 7nDtCbl4LF0nc5Z2i8uUu20fYQMe9nj0rgVba7HkJSRat2CIylnC9XEN/59mHE/O7xdC zj4QDgz2GfuTVIc8K3imBmzGvIDAFhNvT9Fa81FDKrZQy1lK7m0OZ2+2Lh5IGqbiM3Yg lfDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=kbAuQ40ohawtPBG/gCUdhel0jumTeWNCDUG5xW0hSKo=; b=qVWQTPQVgx6UcN8+dvaUxTApbEPP4GzeWT0fdNdgs2BQ4F+nekPVu7HndSSYn/BVl5 PRHCNW1VQRVg5cLUPgWnEwQ4ukY4DuiXbydt2Ugc13ngLv8sPdYvgfSB0kT74ThIwobZ grDZs38aXSh1pm3Mvk2t+S0EXP0JKKL7tXHHJY9ULGRryy8NI2dAEjvUTnV53vy3YXJt BbOaLHbiizw+zv90OmLrK43B9cbYkWikR84oqsQBx/n6+HJTmb2Htpg39Bamnr0BcBqO tVRVhLppLfoDaodNPvWSFTEkwIg9gbqHR9JELW6HWul2CfwR+B14N3M5S/Ddw3y0owcW vqfw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id f25si1294171lfc.3.2020.04.17.08.30.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Apr 2020 08:30:07 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 03HFU3eb022751 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 Apr 2020 17:30:06 +0200 Date: Fri, 17 Apr 2020 17:30:03 +0200 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [[PATCH v2] 3/3] dpkg-raw: make sure templates are processed before do_install Message-ID: <20200417153003.ho7ymnq3gpbneav3@yssyq.m.ilbers.de> Mail-Followup-To: isar-users@googlegroups.com References: <20200316133934.223e4a0b@md1za8fc.ad001.siemens.net> <1584363352-866-1-git-send-email-Cedric_Hombourger@mentor.com> <1584363352-866-4-git-send-email-Cedric_Hombourger@mentor.com> <20200410121132.oaaxohphxq7qlqze@yssyq.m.ilbers.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: rq1BPvoo7E85 Hello Jan, On Tue, Apr 14, 2020 at 08:02:56AM +0200, Jan Kiszka wrote: > > > --- a/meta/classes/dpkg-raw.bbclass ... > > > +inherit template > > > +addtask do_transform_template after do_unpack before do_install > > > > How does this relate to "addtask do_transform_template after do_unpack" in > > meta/classes/template.bbclass? Is one of them superfluous? If yes, would > > modifying template.bbclass be better? > > do_install is dpkg-raw only, so you can't do that in template.bbclass. Indeed. > But I > would rather model this via the addtask of install which is under this > class' control already. > > Also, that inherit is redundant because it's already part of the base class, > thus every other class. Do I understand correctly, you suggest: 1. Keep both addtasks in template.bbclass and dpkg-raw.bbclass. 2. Remove "inherit template". Right? With kind regards, Baurzhan.