From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6816610675337461760 X-Received: by 2002:a19:c8cf:: with SMTP id y198mr15389595lff.197.1587539742841; Wed, 22 Apr 2020 00:15:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9397:: with SMTP id g23ls218254ljh.7.gmail; Wed, 22 Apr 2020 00:15:42 -0700 (PDT) X-Google-Smtp-Source: APiQypIhQ1GfgDSeuEEk4nuyBKoukygqtO3CPcD2P+nWI5F6RqnHGPXJ09dNnzhha9FqmsHtU2Ul X-Received: by 2002:a2e:b888:: with SMTP id r8mr15593636ljp.128.1587539742198; Wed, 22 Apr 2020 00:15:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587539742; cv=none; d=google.com; s=arc-20160816; b=nqhuta36JvE9ROm14YjFTgeSblHi73Or2tgi8cQBb+ZFitSZBo4EFTWcExlAeRCebH iHxxFdeqXGvJRoOQKcfn8cihi4bTapEuImflA2yRqmLUZ9PLvqV++NV+ch62ZUYbmuYu 9SZQquZgoL63j0S191ZieKvVd2cvMur74W6yX7yyKp4P4vLzwWFX9TynuZ325cbVLYUr g5MXWtT91iRQUPj+xUyz6wfJr268+dzSskHFt3bq6fqlmKZhL4gDFXI+Ky+bpKbFXd/G tMiLwgodfW1KrraB4hvpkHYbq0tV2QsQYxPLoA/qeM7vfImLlrCrP0olMouyLaowQhS5 Fgbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=PY3Qo5z+H5c4PfLovdLWs3Vb06eHIRKChaXLz30GpVQ=; b=edjkNNiKak6thvwUa+HJ5d1W63hdwksFrPlSyF4yrZnKpS8jJVK3K+L7rT2ovHhkvO W3ViCKtceR/pRygUXAsX/Djex0R+lFn5/HfjgTNKU7A8NYSVCWbLT56RGLyIARhOEvbk F59jPBiSOIs/lnRqJLA9sVftwJAIbxmm2z1rypXeWCPyW3vqSpEaq7EqIrZTUHriWQNi +2fn1GZjddz2nWYojQvCNklj74j7CptJv9LRJuW21AwIaqsCn4TqWtuTs7dzHFjWxzTV lB47Qo1hjnlfPGiLhPZBM1kQXPrDjwOjqgnknog522aeKD2bVI17SBSV6MGXrZuH/Fcw E7IA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id k13si339222lfg.5.2020.04.22.00.15.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Apr 2020 00:15:42 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 03M7FeDO030438 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Apr 2020 09:15:40 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.23.203]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 03M7FeRP001379; Wed, 22 Apr 2020 09:15:40 +0200 Date: Wed, 22 Apr 2020 09:15:39 +0200 From: Henning Schild To: Vijai Kumar K Cc: , , , Vijai Kumar K Subject: Re: [PATCH v5 04/13] deb-dl-dir: Make debsrc_download faster Message-ID: <20200422091539.76f52aaf@md1za8fc.ad001.siemens.net> In-Reply-To: <20200417093040.15130-5-Vijaikumar_Kanagarajan@mentor.com> References: <20200417093040.15130-1-Vijaikumar_Kanagarajan@mentor.com> <20200417093040.15130-5-Vijaikumar_Kanagarajan@mentor.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: MVMgtS13VAj0 On Fri, 17 Apr 2020 15:00:31 +0530 Vijai Kumar K wrote: > Eventhough apt-get source skips redownloading of files, it is still > slow and takes a lot of time. Instead, lookup if the dsc file is > already present in the cache and skip based on it. > > Signed-off-by: Vijai Kumar K > --- > meta/classes/deb-dl-dir.bbclass | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/classes/deb-dl-dir.bbclass > b/meta/classes/deb-dl-dir.bbclass index 472b9fe..9399741 100644 > --- a/meta/classes/deb-dl-dir.bbclass > +++ b/meta/classes/deb-dl-dir.bbclass > @@ -32,6 +32,9 @@ EOSUDO > if [ -z "${src}" ];then > src="$( dpkg-deb --show --showformat '${Package}' > "${package}" )" fi > + # Strip epoch, if any, from version. > + local dscfile=$(find "${DEBSRCDIR}"/"${rootfs_distro}" -name > "${src}_${version#*:}.dsc") Is that reliable, or might you end up exiting too early. You process that "version" quite a bit, it needs to remain a unique identifier. So you do not skip "foo-1.2.3_r1@deb~42" only because "foo-1.2.3" was there. I made that up but such a version is allowed to have all sorts of funny chars. > + [ -z "$dscfile" ] || continue I personally would say "-n" && continue, might be a matter of taste. Henning > sudo -E chroot --userspec=$( id -u ):$( id -g ) ${rootfs} \ > sh -c ' mkdir -p "/deb-src/${1}/${2}" && cd > "/deb-src/${1}/${2}" && apt-get -y --download-only --only-source > source "$2"="$3" ' download-src "${rootfs_distro}" "${src}" > "${version}"