From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6812695221159067648 X-Received: by 2002:adf:e2c2:: with SMTP id d2mr18735194wrj.55.1588879575327; Thu, 07 May 2020 12:26:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:4088:: with SMTP id n130ls17086884wma.2.canary-gmail; Thu, 07 May 2020 12:26:14 -0700 (PDT) X-Google-Smtp-Source: APiQypL9CCvQbGD4xKiRYXUAC3Rd3ZGQXPR+EM8IFbd+K81E0Q0+5oGgClpkbYOqOsQB5MXhKcYi X-Received: by 2002:a7b:cc0f:: with SMTP id f15mr12649443wmh.78.1588879574790; Thu, 07 May 2020 12:26:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588879574; cv=none; d=google.com; s=arc-20160816; b=peCoEWCBi1YTU140fSc/pdBFvdG7v6I95Z6nIafiQIXor3S8iVfH3c3dvSMsIko+Qn OexBbGDYUNYJKxyg3HgYPHZRWLaaE08l4Gs7izhTB0lcsSOLPHcr4vKeAxA2HeefiRZP SFnan3jQvgFferVECIWpL/yQkJIGnC4ElhsiXLNGyDbp5EplvJpqOx3zjqIADUE//eC4 J6v6wIFra3HowbPWBRvhzvFiILKs8LriAA4nwauPE4l32aQVg6sZVrG/ErY+v2W7/rCK IhXgjfUyE5FqB03UkqRROD5jFsD8jVbq5l7vQR/sujKacc3UP0dGPwaJHqGT2S34/Whb NGkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=9U4ZpTckPDxNZU5jsEieyHqCSgLNRj1CgEtOqqVEWW0=; b=IPocx9veK11PNXFBUHSpoDtGn486Xo98gHs/zC7dMQs77tdw9ljSmtjQk9q0beHjOD Kz2ooYI6aA/ua4+RYOgbpAsuJOdT7KmEVdcLv2xWzgnmonQt4wtXtysnAJ0iN+AAuoUN 5l6TAivERMTZTw+3KaTtGr92wHY26bVTOliKvhUw5/lJ2pDtszzTmh9BsQK+lzrpMbvv PYnaFIQx7cU5TE7l0e72kgAsmSz6xsAx0HCaplNdJW+iCIQ6Iu5BD4xiO9ntKmiWcpBT qrDklf1//7YLsgMYKYyr2HErWF48banyx/35nV1rVCFLCP0A+9pjOaW/rSKXgwUHYHwz InsQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id q17si453687wmg.1.2020.05.07.12.26.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 May 2020 12:26:14 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (dslb-002-207-018-045.002.207.pools.vodafone-ip.de [2.207.18.45]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 047JPcRM010526 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 7 May 2020 21:26:13 +0200 Date: Thu, 7 May 2020 21:25:33 +0200 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH 3/3] CI: test the exclude-path feature of wic Message-ID: <20200507192533.lr3odtnsoozrcrfc@yssyq.m.ilbers.de> Mail-Followup-To: isar-users@googlegroups.com References: <20200406201648.26945-1-henning.schild@siemens.com> <20200406201648.26945-4-henning.schild@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200406201648.26945-4-henning.schild@siemens.com> User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: M8LAeqvhN6Bh Hello Henning, On Mon, Apr 06, 2020 at 10:16:48PM +0200, Henning Schild wrote: > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh ... > @@ -193,3 +193,10 @@ echo -e "do_fetch_append() {\n\n}" >> "${ISARROOT}/meta/classes/dpkg-base.bbclas ... > +cp -a "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks.ci-backup" > +sed -i -e 's/part \/ /part \/ --exclude-path usr /g' "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" > + > +bitbake $BB_ARGS mc:qemuamd64-stretch:isar-image-base The series looks good to me. Please help me, why would this test case fail when the other patches were not applied? As a side note, pylint complains about the upstream's choice of except Exception, because catching a specific one like OSError here and failing completely on unexpected stuff would be better (especially if copying happens to work, in which case space and performance would silently degrade). But that is a completely different task, I'd also stick to the upstream code unless we identify a specific problem. With kind regards, Baurzhan.