From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6824111115797004288 X-Received: by 2002:a17:906:17c1:: with SMTP id u1mr13545927eje.47.1588875249900; Thu, 07 May 2020 11:14:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:bc54:: with SMTP id s20ls1808950ejv.4.gmail; Thu, 07 May 2020 11:14:09 -0700 (PDT) X-Google-Smtp-Source: APiQypLVBXKvzpX6JWoz33Sed8saWS7Ggo8zm8kFapWCjjKDnqpt6Ksqu3W72Pn7QIRf7B+r/p+9 X-Received: by 2002:a17:906:7c42:: with SMTP id g2mr13679002ejp.328.1588875249285; Thu, 07 May 2020 11:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588875249; cv=none; d=google.com; s=arc-20160816; b=joDnaNzhbWop5uvS1/GTWWF+OjvWrK7vlMxK72/H4+193/SU+sBYG2X3ZSAu8yMwmE kM2HLnV+IwDccrlbHqifgZ0ABMvdKYimxktlzYyQsU4GJb4ciA11tN917tcooz8Wq03e vjPrffNFuu7+YR27a/psz8SDVoF8v3jVLg6OWugYdax9l/iQcltn72iLI09Q8eH4+H6U 3Pdc1gRosM5DyA94Vc0otQ38kas/GOHhYoZnBiO2zsycdXXThuchNgedapkQHTocEDa9 hKflS0MdcpGmphRMpBuMrLkEYmb1YbRSFgskzC0SUQ+ErRQ3uWTMl4/opZs6nhTuxwvJ 8I9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=rhxPimSZ0JUA8zBrbzz/zg6w5eBcrCKOMIuCQ6uM3wY=; b=XvVd1iR7tjUM+0pqlhZfkVle7KcxkVxqvkVZ8nwSLA3w2ccsLdZ4z9Ve41rbAxp7z0 ZLqLJRGIf5j4XRFyo2KI06e/vi4uPKIlr/HK1o1RZkLsbnGpyynqfJMyATiSMv04mkwx s/Jq7zQCT4MFPt+65isqupyY50fWgD+qvZXQC1wTeg/tvUkOFPL7ScBARRUG5goQj+MR fy3AH9OBXy00QHkMOUp+97HQx1iyr1ncF0KCZrbsD18XCn5WrGCohWKR4NpaeJGhh/AG q8i+7tRf3C6svZCkANVsErVqdcErnWJaEGl+gPJkP0RIu1xnjteXPH/8GMaOLC+qDcHj CcLA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id a3si419037edn.1.2020.05.07.11.14.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2020 11:14:09 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 047IE8qY018563 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 7 May 2020 20:14:08 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.10.6]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 047IE8rH028874; Thu, 7 May 2020 20:14:08 +0200 Date: Thu, 7 May 2020 20:13:57 +0200 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [RFC][PATCH] rootfs: Retry downloads 3 times Message-ID: <20200507201357.5d24f91b@md1za8fc.ad001.siemens.net> In-Reply-To: <1d96541b-1263-773c-d340-35b0c73cb257@siemens.com> References: <1d96541b-1263-773c-d340-35b0c73cb257@siemens.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 8LqtwRzsRuMT The idea is good but the patch is incomplete. To find all places where we download you might want to look at bitbake fetchers in general - do they have a retry count? Is there a variable controlling that? After that look at all debian downloaders. You will find them when looking for "download-only", "apt-get update" any maybe more. They should use the central bitbake count or switch if available. Your patch found one of many "download-only" and ignores bitbake. Might be the most likely ... but we should try to be consistent. Henning Am Thu, 7 May 2020 16:36:18 +0200 schrieb Jan Kiszka : > From: Jan Kiszka > > Avoids failing a complete rootfs installation in case of a short > hick-up. > > Signed-off-by: Jan Kiszka > --- > > Does something like this make sense? Do we have more places? > We have a retry of 2 on wget bitbake fetches, e.g. (via > FETCHCMD_wget). > > meta/classes/rootfs.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 806e824c..afec1cbc 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -123,7 +123,7 @@ rootfs_install_pkgs_download[weight] = "600" > rootfs_install_pkgs_download[isar-apt-lock] = "release-after" > rootfs_install_pkgs_download() { > sudo -E chroot '${ROOTFSDIR}' \ > - /usr/bin/apt-get ${ROOTFS_APT_ARGS} --download-only > ${ROOTFS_PACKAGES} > + /usr/bin/apt-get ${ROOTFS_APT_ARGS} -o Acquire::Retries=3 > --download-only ${ROOTFS_PACKAGES} } > > ROOTFS_INSTALL_COMMAND_BEFORE_EXPORT ??= ""