From: Henning Schild <henning.schild@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH 3/3] CI: test the exclude-path feature of wic
Date: Thu, 7 May 2020 22:13:11 +0200 [thread overview]
Message-ID: <20200507221311.281f4ebb@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20200507192533.lr3odtnsoozrcrfc@yssyq.m.ilbers.de>
Am Thu, 7 May 2020 21:25:33 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:
> Hello Henning,
>
> On Mon, Apr 06, 2020 at 10:16:48PM +0200, Henning Schild wrote:
> > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
> ...
> > @@ -193,3 +193,10 @@ echo -e "do_fetch_append() {\n\n}" >>
> > "${ISARROOT}/meta/classes/dpkg-base.bbclas
> ...
> > +cp -a
> > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks"
> > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks.ci-backup"
> > +sed -i -e 's/part \/ /part \/ --exclude-path usr /g'
> > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks"
> > + +bitbake $BB_ARGS mc:qemuamd64-stretch:isar-image-base
>
> The series looks good to me. Please help me, why would this test case
> fail when the other patches were not applied?
The "--exclude-path" is the real diff. It is a wic feature that never
worked in isar because of bind-mounts that oe does not use. It is an
important feature when splitting a rootfs into multiple partitions.
Say you want a seperate home, you would add that and need to exclude
home from root. Same goes for other directories people like to have in
separate partitions, in fact boot is where i found it.
> As a side note, pylint complains about the upstream's choice of except
> Exception, because catching a specific one like OSError here and
> failing completely on unexpected stuff would be better (especially if
> copying happens to work, in which case space and performance would
> silently degrade). But that is a completely different task, I'd also
> stick to the upstream code unless we identify a specific problem.
Not sure whether my upstream patch introduces that. Upstream merged it
and it was here for review as well. If you see a need to fix that
upstream now, go for it.
Henning
> With kind regards,
> Baurzhan.
>
next prev parent reply other threads:[~2020-05-07 20:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 20:16 [PATCH 0/3] fix and test wic exclude-path Henning Schild
2020-04-06 20:16 ` [PATCH 1/3] oe.path: Add copyhardlink() helper function Henning Schild
2020-04-06 20:16 ` [PATCH 2/3] lib/oe/path: try hardlinking instead of guessing when it might fail Henning Schild
2020-04-06 20:16 ` [PATCH 3/3] CI: test the exclude-path feature of wic Henning Schild
2020-05-07 19:25 ` Baurzhan Ismagulov
2020-05-07 20:13 ` Henning Schild [this message]
2020-09-01 19:54 ` [PATCH v2 " Baurzhan Ismagulov
2020-09-02 5:30 ` vijaikumar....@gmail.com
2020-09-02 10:10 ` Henning Schild
2020-04-06 20:18 ` [PATCH 0/3] fix and test wic exclude-path Henning Schild
2020-06-10 15:26 ` Henning Schild
2020-06-12 6:55 ` Baurzhan Ismagulov
2020-06-12 15:17 ` Jan Kiszka
2020-06-12 18:11 ` Henning Schild
2020-06-12 18:17 ` Henning Schild
2020-06-12 18:44 ` Jan Kiszka
2020-06-12 18:22 ` Henning Schild
2020-06-12 18:46 ` Jan Kiszka
2020-06-12 18:03 ` Henning Schild
2020-09-01 19:53 ` Baurzhan Ismagulov
2020-09-02 5:24 ` vijaikumar....@gmail.com
2020-09-02 10:04 ` Henning Schild
2020-09-14 13:36 ` Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507221311.281f4ebb@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox