From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6812695221159067648 X-Received: by 2002:a1c:9852:: with SMTP id a79mr11841859wme.27.1588882404546; Thu, 07 May 2020 13:13:24 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:438c:: with SMTP id i12ls8740907wrq.6.gmail; Thu, 07 May 2020 13:13:24 -0700 (PDT) X-Google-Smtp-Source: APiQypLjkG8sMnEIE3nQABbbLkopxoPcCfJwl4JTbxZMTWfQohxN0b2Lh4MBjUU1vDFDjuINDqwQ X-Received: by 2002:a5d:4b4d:: with SMTP id w13mr13924525wrs.178.1588882404068; Thu, 07 May 2020 13:13:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588882404; cv=none; d=google.com; s=arc-20160816; b=bBPRkwMcdRPJ6PySMD/uavjPXSU0NDeFYogIk/ljAk8m8j2eo3R0Po6d+tDVIRYnOX /n+LBs+aRelL/Rvze2Zb1By0HoeCEndLA+S0uHkE/B7EfHApkgXQC5Z0/zT6y9SxRvD4 sq+vtGUgVNYjsRDfwryMaiUTf/5jFv/uy2sSglo0RzM+kIzX44vxDIvzTsj+0eQEzz2Q VAiiwTxM1LKkl20TVb7JEM87Ku5/tI8PsnTep28cVZl/prU7S2EXt9LZQfX2qqNLsBNJ kB4I/kx5TRZ3g8Q2buyEaK7fzkUHqdkUieCNVqfZ+xWy+SVMQaCvAcMWhNZ2oilfLS+L fRPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=1OS5ll4MN37TqWCV2xZNAe2e06HcFAqbiqJz1mlHE6w=; b=Faj+CKOXNQMYfZbmA1Iz4N4MSJ0eDBzpXUM7AQyFeGb7y3YJ8sD2EZ696qbZFiOKjK 4YQJJ6CYpGwjUGvTnB1lS4KaU9ONzXI4LClIBDQHZjYzJ8f2rV5RUARJkGFUVtc8pm1L us0v3722DxvC/QVjHwHYOHXxNwRHfsNBzerA1kIYREL6UrUwiZbyiN3YkMADuA9dHGwE USGgghAneoj6plcB39Wz0moAVQgBeLFoKMga6tKoBBBdVepAGsbWb2D1RJS0MEbFwEgL gMTnHCwFlyzVhJI9mOjNsGZflcxvNJxu+8u8HXkp9OUjisbderHqjPBj6I801uTl7f3o ETwg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id h8si373893wro.3.2020.05.07.13.13.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2020 13:13:24 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 047KDNwa029594 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 May 2020 22:13:23 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.10.6]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 047KDM0o023144; Thu, 7 May 2020 22:13:23 +0200 Date: Thu, 7 May 2020 22:13:11 +0200 From: Henning Schild To: Baurzhan Ismagulov Cc: isar-users@googlegroups.com Subject: Re: [PATCH 3/3] CI: test the exclude-path feature of wic Message-ID: <20200507221311.281f4ebb@md1za8fc.ad001.siemens.net> In-Reply-To: <20200507192533.lr3odtnsoozrcrfc@yssyq.m.ilbers.de> References: <20200406201648.26945-1-henning.schild@siemens.com> <20200406201648.26945-4-henning.schild@siemens.com> <20200507192533.lr3odtnsoozrcrfc@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Njfg4CCl3Dmw Am Thu, 7 May 2020 21:25:33 +0200 schrieb Baurzhan Ismagulov : > Hello Henning, > > On Mon, Apr 06, 2020 at 10:16:48PM +0200, Henning Schild wrote: > > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh > ... > > @@ -193,3 +193,10 @@ echo -e "do_fetch_append() {\n\n}" >> > > "${ISARROOT}/meta/classes/dpkg-base.bbclas > ... > > +cp -a > > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" > > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks.ci-backup" > > +sed -i -e 's/part \/ /part \/ --exclude-path usr /g' > > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" > > + +bitbake $BB_ARGS mc:qemuamd64-stretch:isar-image-base > > The series looks good to me. Please help me, why would this test case > fail when the other patches were not applied? The "--exclude-path" is the real diff. It is a wic feature that never worked in isar because of bind-mounts that oe does not use. It is an important feature when splitting a rootfs into multiple partitions. Say you want a seperate home, you would add that and need to exclude home from root. Same goes for other directories people like to have in separate partitions, in fact boot is where i found it. > As a side note, pylint complains about the upstream's choice of except > Exception, because catching a specific one like OSError here and > failing completely on unexpected stuff would be better (especially if > copying happens to work, in which case space and performance would > silently degrade). But that is a completely different task, I'd also > stick to the upstream code unless we identify a specific problem. Not sure whether my upstream patch introduces that. Upstream merged it and it was here for review as well. If you see a need to fix that upstream now, go for it. Henning > With kind regards, > Baurzhan. >