* [PATCH] debianize: Use weak defaults
@ 2020-05-18 10:05 Vijai Kumar K
0 siblings, 0 replies; 3+ messages in thread
From: Vijai Kumar K @ 2020-05-18 10:05 UTC (permalink / raw)
To: isar-users; +Cc: Vijai Kumar K
We use default assignments(?=) in an include file. If the the dpkg
class is inherited before this assignment then we get the wrong default
value defined in the debianze class.
Use weak defaults in the class so that defaults in the include file are
honoured.
Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
meta/classes/debianize.bbclass | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
index 764477c..1197f3d 100644
--- a/meta/classes/debianize.bbclass
+++ b/meta/classes/debianize.bbclass
@@ -3,12 +3,12 @@
#
# SPDX-License-Identifier: MIT
-CHANGELOG_V ?= "${PV}"
+CHANGELOG_V ??= "${PV}"
DPKG_ARCH ??= "any"
-DEBIAN_BUILD_DEPENDS ?= ""
-DEBIAN_DEPENDS ?= ""
-DESCRIPTION ?= "must not be empty"
-MAINTAINER ?= "Unknown maintainer <unknown@example.com>"
+DEBIAN_BUILD_DEPENDS ??= ""
+DEBIAN_DEPENDS ??= ""
+DESCRIPTION ??= "must not be empty"
+MAINTAINER ??= "Unknown maintainer <unknown@example.com>"
deb_add_changelog() {
changelog_v="${CHANGELOG_V}"
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] debianize: Use weak defaults
@ 2020-05-18 8:59 Vijai Kumar K
2020-05-28 19:45 ` Baurzhan Ismagulov
0 siblings, 1 reply; 3+ messages in thread
From: Vijai Kumar K @ 2020-05-18 8:59 UTC (permalink / raw)
To: isar-users; +Cc: Vijai Kumar K
We use default assignments(?=) in an include file. If the the dpkg
class is inherited before this assignment then we get the wrong default
value defined in the debianze class.
Use weak defaults in the class so that defaults in the include file are
honoured.
Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
meta/classes/debianize.bbclass | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
index 764477c..1197f3d 100644
--- a/meta/classes/debianize.bbclass
+++ b/meta/classes/debianize.bbclass
@@ -3,12 +3,12 @@
#
# SPDX-License-Identifier: MIT
-CHANGELOG_V ?= "${PV}"
+CHANGELOG_V ??= "${PV}"
DPKG_ARCH ??= "any"
-DEBIAN_BUILD_DEPENDS ?= ""
-DEBIAN_DEPENDS ?= ""
-DESCRIPTION ?= "must not be empty"
-MAINTAINER ?= "Unknown maintainer <unknown@example.com>"
+DEBIAN_BUILD_DEPENDS ??= ""
+DEBIAN_DEPENDS ??= ""
+DESCRIPTION ??= "must not be empty"
+MAINTAINER ??= "Unknown maintainer <unknown@example.com>"
deb_add_changelog() {
changelog_v="${CHANGELOG_V}"
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] debianize: Use weak defaults
2020-05-18 8:59 Vijai Kumar K
@ 2020-05-28 19:45 ` Baurzhan Ismagulov
0 siblings, 0 replies; 3+ messages in thread
From: Baurzhan Ismagulov @ 2020-05-28 19:45 UTC (permalink / raw)
To: isar-users
On Mon, May 18, 2020 at 02:29:05PM +0530, Vijai Kumar K wrote:
> We use default assignments(?=) in an include file. If the the dpkg
> class is inherited before this assignment then we get the wrong default
> value defined in the debianze class.
>
> Use weak defaults in the class so that defaults in the include file are
> honoured.
Applied with minor commit message updates, thanks.
With kind regards,
Baurzhan.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-28 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 10:05 [PATCH] debianize: Use weak defaults Vijai Kumar K
-- strict thread matches above, loose matches on Subject: below --
2020-05-18 8:59 Vijai Kumar K
2020-05-28 19:45 ` Baurzhan Ismagulov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox