From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] image: Fix evaluation of complex ISAR_RELEASE_CMD values
Date: Mon, 25 May 2020 16:00:18 +0200 [thread overview]
Message-ID: <20200525140018.yi2awak2svtlq5cb@yssyq.m.ilbers.de> (raw)
In-Reply-To: <de2cf580-f3c1-4c86-f607-f758f15682c1@siemens.com>
On Tue, May 05, 2020 at 06:32:33PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> If ISAR_RELEASE_CMD contains a boolean expression make sure to evaluate
> it as a whole. So far, "false || true" was incorrectly be detected as
> unsuccessful.
>
> This allows to handle failing git version extractions gracefully, e.g.
> ISAR_RELEASE_CMD = "git ... describe ... || echo unknown".
Applied with minor commit message changes, thanks.
With kind regards,
Baurzhan.
prev parent reply other threads:[~2020-05-25 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 16:32 Jan Kiszka
2020-05-25 14:00 ` Baurzhan Ismagulov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525140018.yi2awak2svtlq5cb@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox