From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6823398887937540096
X-Received: by 2002:a2e:7f08:: with SMTP id a8mr12551109ljd.332.1590415223712;
        Mon, 25 May 2020 07:00:23 -0700 (PDT)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:a05:651c:1121:: with SMTP id e1ls1518302ljo.2.gmail; Mon, 25
 May 2020 07:00:23 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxvEbI/lzt+w+u2htXEMEMI+QBy/a8k+bD3Sh9XSbXojM0V+AfnL9hSXzO4TEhgXos6LNJC
X-Received: by 2002:a2e:95c5:: with SMTP id y5mr14398615ljh.229.1590415222981;
        Mon, 25 May 2020 07:00:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1590415222; cv=none;
        d=google.com; s=arc-20160816;
        b=Fcqw76jS5a1SGsuVDEG7LOf3bh87bjy5hKc7LlbSsSJBPo3jGpoOJtHtiId6h9dFfv
         MI9TghSQ/sHx/5PXnUskL36Sy01V+/AkQNYS8L2/800nSRK11L2ziGLZgSLU4dtbbGSy
         U3UsvY/SFvFvQPpDIyjjKvt4GJjy6PCoJ+mNLmipT1ojXpRLTn70AfNok1YDc6qY/bFf
         4u1tgLv+gVIwbin4YwHHmYiToaPBRv87kJ+7S4ZHJJuuVhijfjpf8yIlSxTK/Ok0KU4w
         m9WmziGjnQ88J3dlCpdcjWei0xkan0s+Kj0WV9omFptG82UusRdwkgU81yD0zaLREgTP
         N/Cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:to:from:date;
        bh=l+Myj003vymUYvlB4gmfe4ahUBzmema2s50APFgfp74=;
        b=OnZvO9u0jXWhnLky6j7Fwytp3asf5kIhLnIE0HjzVxvUVF5e8AdaEjZbEP94yDMuZ7
         0VR25LWaYB53b/kchcsCz4Gxps8mHOGUBxR27qzsVaGROYaSZ5z9JcmAHqvUC/yyeBGg
         9YynFxkq/rf3d7Gpy4yHAkm7vtDsr6QjRAMIKz9hO1XL6KAbqKDrSNZKxdXLAPdzeqHA
         FgscGPf4B1ed3KOc1+p/6JXAMx/gviZGktq2VZnv7z/X5H10ZqWwx66JXISXl2HsYcGI
         IsX6EW5xz09v5ozlsiCW2U0OjK2dYeayD4v9rDxpsB0S5UQJw0NhSVUMqDCUbLt/dKV5
         xPBg==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Return-Path: <ibr@radix50.net>
Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166])
        by gmr-mx.google.com with ESMTPS id o28si289538lfc.2.2020.05.25.07.00.22
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
        Mon, 25 May 2020 07:00:22 -0700 (PDT)
Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166;
Authentication-Results: gmr-mx.google.com;
       spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net
Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52])
	(authenticated bits=0)
	by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 04PE0INB018361
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)
	for <isar-users@googlegroups.com>; Mon, 25 May 2020 16:00:21 +0200
Date: Mon, 25 May 2020 16:00:18 +0200
From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] image: Fix evaluation of complex ISAR_RELEASE_CMD values
Message-ID: <20200525140018.yi2awak2svtlq5cb@yssyq.m.ilbers.de>
Mail-Followup-To: isar-users <isar-users@googlegroups.com>
References: <de2cf580-f3c1-4c86-f607-f758f15682c1@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <de2cf580-f3c1-4c86-f607-f758f15682c1@siemens.com>
User-Agent: NeoMutt/20180716
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de
X-TUID: rxVWjbHc9Lhf

On Tue, May 05, 2020 at 06:32:33PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> If ISAR_RELEASE_CMD contains a boolean expression make sure to evaluate
> it as a whole. So far, "false || true" was incorrectly be detected as
> unsuccessful.
> 
> This allows to handle failing git version extractions gracefully, e.g.
> ISAR_RELEASE_CMD = "git ... describe ... || echo unknown".

Applied with minor commit message changes, thanks.

With kind regards,
Baurzhan.