public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] devshell: Use different termination test to avoid warnings
Date: Mon, 25 May 2020 18:11:24 +0200	[thread overview]
Message-ID: <20200525161124.h2qsivjotymjcdpv@yssyq.m.ilbers.de> (raw)
In-Reply-To: <3b659fd0-15bb-d74c-8460-ffd67651401f@web.de>

On Sat, May 16, 2020 at 10:00:37AM +0200, Jan Kiszka wrote:
> As we run the terminal via a sudo chroot, OE's way of testing for the
> existence of the target PID does not work. It will rather fail early due
> to missing permissions (user tries to send signal to root process), and
> we will wait in the unmount loop, generating warnings like
> 
> WARNING: mc:qemuamd64-buster:example-raw-0.3-r0 do_devshell: /work/build/tmp/deploy/buildchroot-target/debian-buster-amd64//home/builder/example-raw: Couldn't unmount, retrying...
> 
> This replaces the kill(pid, 0) with a test for the existence of the
> corresponding /proc/<pid> directory.

Applied to next, thanks.

Is there anything against submitting this upstream, too?

With kind regards,
Baurzhan.

  reply	other threads:[~2020-05-25 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16  8:00 Jan Kiszka
2020-05-25 16:11 ` Baurzhan Ismagulov [this message]
2020-05-25 16:13   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200525161124.h2qsivjotymjcdpv@yssyq.m.ilbers.de \
    --to=ibr@radix50.net \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox