From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6787079713742389248 X-Received: by 2002:adf:a350:: with SMTP id d16mr19539511wrb.237.1590479465087; Tue, 26 May 2020 00:51:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:9e15:: with SMTP id h21ls5719594wme.0.canary-gmail; Tue, 26 May 2020 00:51:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXyu8SkgyjDSzAcezJrippT0c6f19lJ4LHtruReqYVNTTsHnkZZNc9oM+iudpZ1241GeFc X-Received: by 2002:a1c:4009:: with SMTP id n9mr169548wma.104.1590479464570; Tue, 26 May 2020 00:51:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590479464; cv=none; d=google.com; s=arc-20160816; b=zUUIxks9KEZcBsbOhNpfTd6f9Xzcc2fn18K51gSaubo/09kjMAJBkG+z1gYKEoGnOb 8R88CfoPAbmIeQ/ZK8tjHv1K8VUZ6SNP37XOSL3Y2e6ZbLinAUujBYubGCGOeT78bCht b+Ogs+EuUJhzJAhNBEcGM5vfQ1eINH/x9CTterpdgMMCQYVr0AoONw0jEoMIJf87uDXn 4rZTys8j/gQ3z/QdpaTNMGobScB23bM2zCowZlSixN/r5rxTmzaRnjzw7jd4uzR1rnjC Sxx0r4z1bth4iu6YtjO2vjFu9eLN6Kr7lBj7BL7ZdtFt/Ub2Wvlwo7OlMeIbkofR/kf/ BxOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=trZrYgbOX4u5qofQ+YfGoE69WjI7t3NgZNKLBfk4OX8=; b=Ak7FZmCMMM5Pmyqp+hSxKCmwmUZQ9eZC6U6GzhnQ1f4vEiYY1m+ktmizMePdKXBtMv sqo4JFMOcPivTcUeJ+YtpQx1VzUtmhEqjt3oLE8jeC9BE+PqvXjmnn9yuTJ74RtLhuoh EIYe2C+J/VlBbH15pC9rOjjbPqjwVZpHICx8clEU3vpq6X8nBVDe4OnmoydHdQfFcYGA DSNOAwbDq86Hps+9endecmRlAsEZSIZVVkbQvhmH5IEfHydbMyzhRQxnzeS0Dk59MsY8 n0EeGFInGQnHY9wvyhYqZnAecnaL4jsJj+YLB6ZlO9Xgq+oB2cyZIXPOy8OoAvE56umy jjfA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id f16si560610wrq.5.2020.05.26.00.51.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 May 2020 00:51:04 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 04Q7p1N9021517 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 26 May 2020 09:51:03 +0200 Date: Tue, 26 May 2020 09:51:01 +0200 From: Baurzhan Ismagulov To: isar-users Subject: Re: [PATCH v3] Replace ISARROOT with more relevant variables Message-ID: <20200526075101.4iipq63ke245qrpn@yssyq.m.ilbers.de> Mail-Followup-To: isar-users References: <20200427102837.1755-1-Vijaikumar_Kanagarajan@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: YN6OOrLlDgKz Hello Vijai Kumar, On Mon, May 25, 2020 at 07:54:57PM -0700, vijai kumar wrote: > Any review comments on this? This looks good to me, sorry for the delay. I had held this because it happens to conflict with the hardlinking series which arrived earlier. However, we've newly discovered that the latter seems to have problems with its test case, so I tend to pick the one that could be applied first. With kind regards, Baurzhan. > On Monday, April 27, 2020 at 3:59:07 PM UTC+5:30, vijai kumar wrote: > > > > From: Vijai Kumar K > > > > When switching between two ISAR workspaces in the same shell > > session, the ISARROOT setting of the previous workspace would be > > picked up for the new workspace resulting in an incorrect > > configuration. The user had to manually unset ISARROOT to avoid > > any issues. > > > > As like OEROOT in OE, let us unset ISARROOT at the end of the > > initialization script. This helps us to avoid the above issue > > and also preserves support for passing ISARROOT from a caller > > script as in OE. > > > > ISARROOT is used mostly to derive the location of bitbake, scripts, > > testsuite, meta and meta-isar directories. > > > > Layers like meta, meta-isar already have their paths in LAYERDIR_core > > and LAYERDIR_isar which can be used. For other directories introduce > > dedicated variables BITBAKEDIR, SCRIPTSDIR and TESTSUITEDIR. > > > > Signed-off-by: Vijai Kumar K > > --- > > Changes in v3: > > - Send patch using proper send. > > Changes in v2: > > - Approach using dedicated variables for each commonly used > > directories. > > > > isar-init-build-env | 1 + > > meta/classes/image-sdk-extension.bbclass | 2 +- > > meta/classes/wic-img.bbclass | 31 ++++++++++++------------ > > scripts/ci_build.sh | 12 +++++---- > > scripts/isar-buildenv-internal | 7 ++++-- > > 5 files changed, 30 insertions(+), 23 deletions(-)