From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl
Date: Thu, 28 May 2020 22:04:47 +0200 [thread overview]
Message-ID: <20200528200446.3zlpkejasd2gex4r@yssyq.m.ilbers.de> (raw)
In-Reply-To: <289568e6-46d2-e2e3-9771-7668cd10bc01@web.de>
On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote:
> .PHONY is not needed (and wasn't consistently used anyway). And that
> missing && before the last export was apparently not critical as well.
Wow, export A=a export B=b is accepted at least by bash. The && fix is still
needed if there is an error in A=a, thanks for the catch.
Regarding .PHONY, could you please comment why it is not needed? Usually it's a
safeguard against the case when a file with the name of a target exists (e.g.,
override_dh_auto_clean). In that case, the target is not built, and .PHONY
enforces building. If there are no other reasons, I'd rather go towards making
it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install).
With kind regards,
Baurzhan.
next prev parent reply other threads:[~2020-05-28 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 9:43 Jan Kiszka
2020-05-28 20:04 ` Baurzhan Ismagulov [this message]
2020-05-29 5:53 ` Jan Kiszka
2020-06-22 7:36 ` Jan Kiszka
2020-08-31 16:29 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528200446.3zlpkejasd2gex4r@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox