From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6830344030104059904 X-Received: by 2002:a2e:89cb:: with SMTP id c11mr2371623ljk.97.1590696297101; Thu, 28 May 2020 13:04:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9042:: with SMTP id n2ls765513ljg.4.gmail; Thu, 28 May 2020 13:04:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLi8O7ZjLBRpgOIrpKuGFkQ1wEDdUYvbOXGTNUkNN2seVnRufiJ7NXQBRS/g3sDahn575k X-Received: by 2002:a2e:b8c2:: with SMTP id s2mr2546203ljp.368.1590696296362; Thu, 28 May 2020 13:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590696296; cv=none; d=google.com; s=arc-20160816; b=GcnwINDX6RFeQFZyp5CgjFPM+SGHPXuUmyZrtxnebybIVw86+61W2R0+4Y+wsRPbX5 mQPg3VN0DaLq+r+vPU0kBgqp82U4EcQ6u70DOKdlLw/hmsE2pmKpqSd/qPPcv5JLViMj p2X0kKDGXB4hY/OgEi8oYeRUcsx2A7OIGcyDL1dhe78ZAQ9aWYPzQOZMYUXsOq8qpqtI DHAAyWHFUfDuP5CqNiwbcmnxhCGq/vhJuwhf7qhWXmfV8vf95wide4uStMQcChsZwPZT soLwNXCJHieHyalCopGgZgEoq0axJ6Wajo6DVq1kOJA1LFiF9zyIvh/8WXLBKlGFSn6J 9Cqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=RV+AvWZGtxp1xcGfSuWxL64vTNedXOu6qmynja1KQc8=; b=zWgwLL9u4eJOQRx5w3fxyh9n7Zq/7GjfkSmE6iPqx8891uSV8GW0qIhPKTfnBd1op9 bxV0gaYJ/rxqoiqldci7jsMrhKZooWt8rkJ5iOCdNekPEUp+yiXj7PywXPZdUnWQgsNq Uf8QaobSlkSk/T6zGgMf/N2wWL1WXu/uVvzukij/H2vdEZ0VUHPlbSOvw9FeS24hBRUL rFUqhppV3h1Dlgj2L47CboQTIqVPc/zk0BQI31r5MX+QSPQ+vyYsBGAWHe/eaFP3+uuq pW1OiNtbrJhzpLqBQrLjZ9qi9/tQi1kF5WOMjoDbkW4GeIp1G8Mtqt899Nfk/spvyAEY hoeQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id r21si436795ljp.0.2020.05.28.13.04.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 May 2020 13:04:56 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.156.166 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (dslb-084-058-239-149.084.058.pools.vodafone-ip.de [84.58.239.149]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 04SK4q8p031807 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 28 May 2020 22:04:55 +0200 Date: Thu, 28 May 2020 22:04:47 +0200 From: Baurzhan Ismagulov To: isar-users Subject: Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl Message-ID: <20200528200446.3zlpkejasd2gex4r@yssyq.m.ilbers.de> Mail-Followup-To: isar-users References: <289568e6-46d2-e2e3-9771-7668cd10bc01@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <289568e6-46d2-e2e3-9771-7668cd10bc01@web.de> User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: f3vGXt7UGSpC On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote: > .PHONY is not needed (and wasn't consistently used anyway). And that > missing && before the last export was apparently not critical as well. Wow, export A=a export B=b is accepted at least by bash. The && fix is still needed if there is an error in A=a, thanks for the catch. Regarding .PHONY, could you please comment why it is not needed? Usually it's a safeguard against the case when a file with the name of a target exists (e.g., override_dh_auto_clean). In that case, the target is not built, and .PHONY enforces building. If there are no other reasons, I'd rather go towards making it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install). With kind regards, Baurzhan.