Re: [PATCH] expand-on-first-boot: Allow expanding extended MBR partitions

[Baurzhan Ismagulov <ibr@radix50.net>]

On Wed, Jun 10, 2020 at 02:50:40PM +0200, Jan Kiszka wrote:
> >     While probably a very uncommon layout, I am not sure how this
> >     would behave when the EBR is not the last partition, but
> >     somewhere in between.  I am a bit worried it would silently wreak
> >     havoc ...
> 
> We should probably throw some test patterns at that. Could be done
> against a disk image file as well, I suppose.

That would be great.


> >  sfdisk -d "${BOOT_DEV}" 2>/dev/null | grep -v last-lba | \
> > -	sed 's|\('"${LAST_PART}"' .*, \)size=[^,]*, |\1|' | \
> > +	sed 's|^\(.*, \)size=[^,]*, type=[f5]$|\1type=5|' | \
> > +	sed 's|^\('"${LAST_PART}"' .*, \)size=[^,]*, |\1|' | \
> 
> Would it make things worse or better to combine both sed expressions
> into the same sed call?

>From the performance PoV, yes. However, they tend to become less readable.
Perhaps we could assign them to three vars and use those... or anything else
without sacrificing any of both.


With kind regards,
Baurzhan.