Re: [PATCH 0/3] fix and test wic exclude-path

[Henning Schild <henning.schild@siemens.com>]

Am Fri, 12 Jun 2020 08:55:22 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> Hello Henning,
> 
> On Wed, Jun 10, 2020 at 05:26:27PM +0200, Henning Schild wrote:
> > Still having to work around that in a downstream layer. Any more
> > comments or questions?  
> 
> I'd like to look at the following issues:
> 
> 1. I'd like to understand what exactly is failing when the fix is not
> applied.

You have the code for that. Just revert the fix and you will see.

> 2. The test case is failing with the fix applied.

Just apply the changes and you will see ;).

> 
> Regarding (1), you responded:
> 
> > The "--exclude-path" is the real diff. It is a wic feature that
> > never worked in isar because of bind-mounts that oe does not use.
> > It is an important feature when splitting a rootfs into multiple
> > partitions. Say you want a seperate home, you would add that and
> > need to exclude home from root. Same goes for other directories
> > people like to have in separate partitions, in fact boot is where i
> > found it.  
> 
> Thanks for the explanation. The concept is already clear from your
> patch description. Do you have an example of a failing ln command and
> which filesystems the source and the destination are on, for the test
> case you added?

Yes, use the exclude feature today.

> Because I interpret --exclude-path usr as "don't copy usr", but
> meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks contains only /
> and /boot. If it complained about / and /boot, then I'd expect it to
> fail also without --exclude-path usr.

With / it also contains /usr. You need the exclude if you want to put a
folder into another partition and not still have it in / as well.

For a real wks you would add another partition with /usr and exlude usr
from /. The test is more basic ... making sure the exclude will work in
isar.

Henning

> 
> With kind regards,
> Baurzhan.
>