From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6812695221159067648 X-Received: by 2002:a17:906:4554:: with SMTP id s20mr14009063ejq.241.1591985018515; Fri, 12 Jun 2020 11:03:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:8483:: with SMTP id m3ls3047341ejx.7.gmail; Fri, 12 Jun 2020 11:03:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6b/B8bIZWJ7Z/Z4WgDYv+mxI742THoSqJGiZ2IlMIRHLbbeLNf1XmMFO5IAf2OjNqNFPG X-Received: by 2002:a17:906:ca54:: with SMTP id jx20mr15270692ejb.549.1591985017903; Fri, 12 Jun 2020 11:03:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591985017; cv=none; d=google.com; s=arc-20160816; b=Hud9AERDgOoaaV+dLsoN3+0rLlVMy62K1CxVZ60uAx0tCq5kp9IsjuF9a1uxhQAvxd Da23BPAexllPNkoJU+VQZt83nD7osADzTsNpY8apQ9IkQ83u7V870FP+VAAM4DdiyzOg pNkv7s0O05/hdajlwAHKuer6xYxWWqbnawLfLo92kpqcj8VESPcNZrlDE64be+wSUxeP OEsp1BELaI7jWBxdBq7itYKRfSbsrADBwkIvAvjJhg+DQGhsCCfiOlhehVks/hQuK6Ck V/FSrPxBfGpRPl+dpYbOIZe4qWHCsN2W6JPKcuxKW7brwpBrSrrntD3GGQDaR1HmZ1a7 Hcig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=GeE8bQf9c+hTFRmjU7MEhqfz4fCvylujM6Nvy91aY2w=; b=ZSnrrFNXZZYvLaigKiYf84Z+n04y/L0D6TpYKjpJljhd+hgdD39jUJ643SSsoyrZog LfcPXRvZof4YtyOazpwx6Vkdhv5GmWYngk/4PwS6Jv95D5WKAiZGFg9hhXZAdeiTajn2 tJqAor7XIXRGJ9ygP2ZtUZmVHd6qwU0qSDzv5jskRxjZ42ZsUy/DpENZK5P2WnWLLH2K 2EnwLe8qjGkt7HefvwSvYNC/BgRGhNeZGZgSdzaQyD84EQs+oJ0mf9CDbH2VNcNYupq+ ICEuJotpmeXQ19dOjlLK8oCS4TdCKFz1t8cfO3ERzcX1w7agaM+HRy2zDFJXhi+g7Xvo uSyg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id b6si333010edr.3.2020.06.12.11.03.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jun 2020 11:03:37 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 05CI3bXF027900 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jun 2020 20:03:37 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.27.206]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 05CI3b0X009838; Fri, 12 Jun 2020 20:03:37 +0200 Date: Fri, 12 Jun 2020 20:03:35 +0200 From: Henning Schild To: Baurzhan Ismagulov Cc: isar-users@googlegroups.com Subject: Re: [PATCH 0/3] fix and test wic exclude-path Message-ID: <20200612200335.0ad5c340@md1za8fc.ad001.siemens.net> In-Reply-To: <20200612065522.GP5077@yssyq.m.ilbers.de> References: <20200406201648.26945-1-henning.schild@siemens.com> <20200610172627.09cfb239@md1za8fc.ad001.siemens.net> <20200612065522.GP5077@yssyq.m.ilbers.de> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 1b4CZxdoTsw2 Am Fri, 12 Jun 2020 08:55:22 +0200 schrieb Baurzhan Ismagulov : > Hello Henning, > > On Wed, Jun 10, 2020 at 05:26:27PM +0200, Henning Schild wrote: > > Still having to work around that in a downstream layer. Any more > > comments or questions? > > I'd like to look at the following issues: > > 1. I'd like to understand what exactly is failing when the fix is not > applied. You have the code for that. Just revert the fix and you will see. > 2. The test case is failing with the fix applied. Just apply the changes and you will see ;). > > Regarding (1), you responded: > > > The "--exclude-path" is the real diff. It is a wic feature that > > never worked in isar because of bind-mounts that oe does not use. > > It is an important feature when splitting a rootfs into multiple > > partitions. Say you want a seperate home, you would add that and > > need to exclude home from root. Same goes for other directories > > people like to have in separate partitions, in fact boot is where i > > found it. > > Thanks for the explanation. The concept is already clear from your > patch description. Do you have an example of a failing ln command and > which filesystems the source and the destination are on, for the test > case you added? Yes, use the exclude feature today. > Because I interpret --exclude-path usr as "don't copy usr", but > meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks contains only / > and /boot. If it complained about / and /boot, then I'd expect it to > fail also without --exclude-path usr. With / it also contains /usr. You need the exclude if you want to put a folder into another partition and not still have it in / as well. For a real wks you would add another partition with /usr and exlude usr from /. The test is more basic ... making sure the exclude will work in isar. Henning > > With kind regards, > Baurzhan. >