From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6842309179660566528 X-Received: by 2002:a7b:c043:: with SMTP id u3mr4606387wmc.185.1593103705420; Thu, 25 Jun 2020 09:48:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:9a81:: with SMTP id c123ls3143813wme.1.canary-gmail; Thu, 25 Jun 2020 09:48:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMZ0Khlo/UHyrlqP35rbEx00FWU6xJQMSsxCYbrTPt6Inx8zwVJ5WEyIyfdRu4Db915oDS X-Received: by 2002:a7b:cb51:: with SMTP id v17mr4626104wmj.17.1593103704963; Thu, 25 Jun 2020 09:48:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593103704; cv=none; d=google.com; s=arc-20160816; b=vOR6fLoFcZtbOiM/yk5J1zW3+8yY9FL+zqtP5aMrdfqL0A/j+FO5t7bbPEkRK1a+1d diifzkcdbrxB2eMqpCnjbymbR0wdBdDdbTBQ+oV4DK8xI212BiKnDmzkmOcTVw7kP93F +TmO4bhCr9jFh6LQeBtZ7Pw2LoTzPPyEWbXlEW3PPBfOEZaBMOi9UT9QWa9wkyoXazRJ mePNGLYYWsD8s8t1BJNG/tMHa7+vLDOlxE3lBW7kkRbZedYJnsvBrM48IwbsEx4jMFHv nzteWXiPATmka8I9IYyGf91G6zQzO7HSvmQeavzSYmJwiphcl3iwwA/s92hss9CqBftd xiEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=LUksQFCu6r91NRWXzSQHnGkl1XnxkMmrnoWeXZhrPpE=; b=caaxrhOg2q99mKtznXrI0uQ0U5g69ZACAYyeVyqZFp49L3A4oICsIeAWqy/Kd9fzXU Ao5K9m7YWIfpkr21TPxVN8sqTFFdBaa82QG3AxBq0MdZrr6NQjxEPXWCVwaPCsuokoS9 v/nE3y5mZAf6zvkrom8w5qRofJIxfc+1SfsuWPYiawT0UdyQf4JbJN/qTBCO0EiP6o4E /XtFKSbXCSe1wpU6N16b5iRYcK60B+4wPYKLW7O78/sGoIA3diauiJdqayE3q+E/5ZKZ EvySH2905rR4B/uSQ+ltFUtolV/cDiZ28D5Skyb2EUcEggeUJzM8kf0HDQvAkdBb193i 7I0A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id g14si448884wmh.3.2020.06.25.09.48.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jun 2020 09:48:24 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 05PGmO3Y023447 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jun 2020 18:48:24 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.33.82]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 05PGmNe3018740; Thu, 25 Jun 2020 18:48:23 +0200 Date: Thu, 25 Jun 2020 18:48:22 +0200 From: Henning Schild To: Harald Seiler Cc: isar-users@googlegroups.com, Claudius Heine Subject: Re: [PATCH] image: Run copy_boot_files after rootfs postprocessing Message-ID: <20200625184822.236ff069@md1za8fc.ad001.siemens.net> In-Reply-To: <20200625153351.3402179-1-hws@denx.de> References: <20200625153351.3402179-1-hws@denx.de> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: QV6WW6BF+M+E Hi Harald, can you elaborate on those cases? The postprocessing is hacky, if the problem is coming from your layer you should probably keep this patch in you layer. Maybe you can point out an issue in isar itself, or explain how you got into this situation? We can then see if your change is generic enough for upstream. You could also provide the error-case from your layer as an upstream feature, if that is generic enough. Henning Am Thu, 25 Jun 2020 17:33:51 +0200 schrieb Harald Seiler : > In some cases, postprocessing might trigger an update of the initramfs > which would not appear in the deployed version. Fix this by running > copy_boot_files only after all postprocessing completed. > > Signed-off-by: Harald Seiler > --- > meta/classes/image.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 0150f2718573..21d634a8f34f 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -153,7 +153,7 @@ do_copy_boot_files() { > cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/" > done > } > -addtask copy_boot_files before do_rootfs_postprocess after > do_rootfs_install +addtask copy_boot_files before do_rootfs after > do_rootfs_postprocess > python do_image_tools() { > """Virtual task"""