From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
To: <isar-users@googlegroups.com>
Cc: Paul Barker <paul@betafive.co.uk>,
Ross Burton <ross.burton@intel.com>,
Richard Purdie <richard.purdie@linuxfoundation.org>,
Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
Subject: [RFC PATCH 04/10] oe.path: Add copyhardlink() helper function
Date: Mon, 24 Aug 2020 14:57:44 +0530 [thread overview]
Message-ID: <20200824092750.19642-5-Vijaikumar_Kanagarajan@mentor.com> (raw)
In-Reply-To: <20200824092750.19642-1-Vijaikumar_Kanagarajan@mentor.com>
From: Paul Barker <paul@betafive.co.uk>
This function creates hard links if possible, falling back to copying
the file if the destination is on a different volume to the source.
The docstring for copyhardlinktree() is also updated to make the
difference between the two functions a little clearer.
Signed-off-by: Paul Barker <paul@betafive.co.uk>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
[Vijai: Imported from OE-core 5437efa16f9bec914e417c6c939a39c247084f52]
Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
meta/lib/oe/path.py | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/meta/lib/oe/path.py b/meta/lib/oe/path.py
index 90c87f5..c6bb604 100644
--- a/meta/lib/oe/path.py
+++ b/meta/lib/oe/path.py
@@ -94,7 +94,7 @@ def copytree(src, dst):
subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT)
def copyhardlinktree(src, dst):
- """ Make the hard link when possible, otherwise copy. """
+ """Make a tree of hard links when possible, otherwise copy."""
bb.utils.mkdirhier(dst)
if os.path.isdir(src) and not len(os.listdir(src)):
return
@@ -118,6 +118,17 @@ def copyhardlinktree(src, dst):
else:
copytree(src, dst)
+def copyhardlink(src, dst):
+ """Make a hard link when possible, otherwise copy."""
+
+ # We need to stat the destination directory as the destination file probably
+ # doesn't exist yet.
+ dstdir = os.path.dirname(dst)
+ if os.stat(src).st_dev == os.stat(dstdir).st_dev:
+ os.link(src, dst)
+ else:
+ shutil.copy(src, dst)
+
def remove(path, recurse=True):
"""
Equivalent to rm -f or rm -rf
--
2.17.1
next prev parent reply other threads:[~2020-08-24 9:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:27 [RFC PATCH 00/10] WIC update Vijai Kumar K
2020-08-24 9:27 ` [RFC PATCH 01/10] wic: Update to the latest wic from openembedded core Vijai Kumar K
2020-08-24 9:27 ` [RFC PATCH 02/10] wic/plugins: Fix wic plugins to work with the latest wic Vijai Kumar K
2020-08-24 9:27 ` [RFC PATCH 03/10] wic-img: Satisfy the quirks of " Vijai Kumar K
2020-08-24 9:27 ` Vijai Kumar K [this message]
2020-08-24 10:59 ` [RFC PATCH 05/10] lib/oe/path: try hardlinking instead of guessing when it might fail Vijai Kumar K
2020-08-24 10:59 ` [RFC PATCH 06/10] wic_fakeroot: Handle standalone pseudo invocations Vijai Kumar K
2020-08-24 10:59 ` [RFC PATCH 07/10] meta-isar/conf: Add provision to debug WIC Vijai Kumar K
2020-08-24 10:59 ` [RFC PATCH 08/10] debian-common: Add tar as a dependency for wic Vijai Kumar K
2020-08-24 10:59 ` [RFC PATCH 09/10] scripts/lib/wic: Add /bin to the list of searchpaths Vijai Kumar K
2020-08-24 11:02 ` [RFC PATCH 10/10] meta-isar/canned-wks: Remove /boot mountpoint Vijai Kumar K
2020-08-31 14:03 ` [RFC PATCH 00/10] WIC update Jan Kiszka
2020-08-31 14:57 ` vijaikumar....@gmail.com
2020-09-01 16:53 ` vijaikumar....@gmail.com
2020-09-01 16:57 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824092750.19642-5-Vijaikumar_Kanagarajan@mentor.com \
--to=vijaikumar_kanagarajan@mentor.com \
--cc=isar-users@googlegroups.com \
--cc=paul@betafive.co.uk \
--cc=richard.purdie@linuxfoundation.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox