public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>
Cc: isar-users@googlegroups.com, vijaikumar.kanagarajan@gmail.com
Subject: Re: [PATCH 0/3] fix and test wic exclude-path
Date: Wed, 2 Sep 2020 12:04:20 +0200	[thread overview]
Message-ID: <20200902120420.6924e4f6@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20200901195313.GJ11779@yssyq.m.ilbers.de>

Am Tue, 1 Sep 2020 21:53:14 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> Hello Henning,
> 
> On Fri, Jun 12, 2020 at 08:03:35PM +0200, Henning Schild wrote:
> > > 1. I'd like to understand what exactly is failing when the fix is
> > > not applied.  
> > 
> > You have the code for that. Just revert the fix and you will see.  
> 
> Fair enough -- just thought it would speed up things.

Using the exclude will cause our wic to raise an exception

> 
> > > 2. The test case is failing with the fix applied.  
> > 
> > Just apply the changes and you will see ;).  
> 
> I meant that your patches started to fail in CI, see e.g.
> http://ci.isar-build.org:8080/job/isar_ibr_devel_2_fast/12/consoleFull.
> The build succeeds, but start_vm fails due to init dying.
> 
> The problem seems to be that Debian doesn't support operating without
> /usr anymore. We can fix it by saving a backup of the image before
> generating one without /usr -- I'll send the updated patch.

Oh i see. The idea was to just test wic and whether it would still crap
out with its exception. There was no focus on whether that image was in
fact bootable. And i am not surprised it is not ...
 
> I'd be ready to apply this with the modification above. I see that
> the wic series also touches this part but doesn't include the CI
> patch. What would be the preferred way?
> 
> 1. Apply this, rework the wic series, OR
> 
> 2. Include the CI patch in the wic series and apply that.

3. apply the wic series and do not even care about the test

The test was just there to motivate the backport, if we bump that would
be much better.

Henning 
> 
> With kind regards,
> Baurzhan.
> 


  parent reply	other threads:[~2020-09-02 10:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 20:16 Henning Schild
2020-04-06 20:16 ` [PATCH 1/3] oe.path: Add copyhardlink() helper function Henning Schild
2020-04-06 20:16 ` [PATCH 2/3] lib/oe/path: try hardlinking instead of guessing when it might fail Henning Schild
2020-04-06 20:16 ` [PATCH 3/3] CI: test the exclude-path feature of wic Henning Schild
2020-05-07 19:25   ` Baurzhan Ismagulov
2020-05-07 20:13     ` Henning Schild
2020-09-01 19:54   ` [PATCH v2 " Baurzhan Ismagulov
2020-09-02  5:30     ` vijaikumar....@gmail.com
2020-09-02 10:10       ` Henning Schild
2020-04-06 20:18 ` [PATCH 0/3] fix and test wic exclude-path Henning Schild
2020-06-10 15:26 ` Henning Schild
2020-06-12  6:55   ` Baurzhan Ismagulov
2020-06-12 15:17     ` Jan Kiszka
2020-06-12 18:11       ` Henning Schild
2020-06-12 18:17         ` Henning Schild
2020-06-12 18:44           ` Jan Kiszka
2020-06-12 18:22       ` Henning Schild
2020-06-12 18:46         ` Jan Kiszka
2020-06-12 18:03     ` Henning Schild
2020-09-01 19:53       ` Baurzhan Ismagulov
2020-09-02  5:24         ` vijaikumar....@gmail.com
2020-09-02 10:04         ` Henning Schild [this message]
2020-09-14 13:36 ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200902120420.6924e4f6@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=ibr@radix50.net \
    --cc=isar-users@googlegroups.com \
    --cc=vijaikumar.kanagarajan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox