From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6812695221159067648 X-Received: by 2002:a05:6512:6c1:: with SMTP id u1mr3037418lff.28.1599041409732; Wed, 02 Sep 2020 03:10:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b0e9:: with SMTP id h9ls317929ljl.5.gmail; Wed, 02 Sep 2020 03:10:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzy7Pz4m9nF5sD7cMfNqwmsXvPl02hnkrWwmdlNZ6UBGz0iuMRmVh7zKCf1EuhkWPNHWlHD X-Received: by 2002:a2e:898a:: with SMTP id c10mr3026877lji.175.1599041408942; Wed, 02 Sep 2020 03:10:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599041408; cv=none; d=google.com; s=arc-20160816; b=XI91nTcjy2wm912MgQwYnpwSreD4BQS0dw3irymXcz8Wv4iYUiGeMSPoSEJ/wHORrG 7m3f6yDryeDOqFgRa+qIYY/PTOYRNC739Rz+fqNJcw+D/TIdAwU8x/23GgYHFSPzdSLl Se1VKHIPlQdlkoMjF+fcjQA64TUyZe5KPvXZOinBqvlHfN9u7vkHyUUQFgHmvmVQUMzx G7A5pBeIN+kI0dptG4gve8YlD0IwB3/iiUaIb0UGfo5dCeo2L2LFjgCYwyOlWPmwkO3F X/jlUoo9D9pxH4rLWhTRBBCMRtWrhA8qfJr0UZwR8m6pc2MmHXijhb8jMrfjkxGMAfCT 8M7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=6UowA0CPpkyQu3CINZRArUc01vtusz+Wzpe5btP/3DY=; b=Byeow56dcigw9DhQ+/jDSF2Gpql8ppkNQD+9OZfJrYcrTC4g3G754oeluhc7xBRC2m Vjk8LmgUwTueoP5BQnv2p4RmghEs8jQRYUi6/t3gRedJjzYiDTPLgbHfYY31J/YzYFv9 8NLmf4RKS9tS9A/wBrDZlWNb4SrqGz+33li/EHo3KobYvdZOOKMILPFP5Vo0136fp+8P kM2UiqasV7KqOnNourrM6g5oX/oTuVLkrZlhq4A4+Di9JNbmO0hkCGYaqIJuJiZVtRv5 XrqnGAz2qKCCrmD20qsUpIarfvCpWIHBjXrRwZhSihTQPvvsCKQDuNfW7Br78S0JSYYb rM1A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id a7si102192ljp.2.2020.09.02.03.10.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Sep 2020 03:10:08 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 082AA7R5028506 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Sep 2020 12:10:07 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.29.156]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 082AA763004475; Wed, 2 Sep 2020 12:10:07 +0200 Date: Wed, 2 Sep 2020 12:10:05 +0200 From: Henning Schild To: "vijaikumar....@gmail.com" Cc: isar-users , Baurzhan Ismagulov Subject: Re: [PATCH v2 3/3] CI: test the exclude-path feature of wic Message-ID: <20200902121005.46d87fde@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20200406201648.26945-4-henning.schild@siemens.com> <20200901195405.32162-1-ibr@radix50.net> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: kAL46E1YksXr Baurzhan, thanks for the proposed fix. Looks like you got the idea that this one was supposed to only test wic, not "bootable". If you think that still makes sense we can keep it, we could also go to "wic ls". We could also add a wks file that excludes /var and turns it into a partition on its own. That would test the exclude, be bootable, and be a good example. I would actually opt for that or for dropping the testcase alltogether. Henning Am Tue, 1 Sep 2020 22:30:30 -0700 (PDT) schrieb "vijaikumar....@gmail.com" : > On Wednesday, September 2, 2020 at 1:24:13 AM UTC+5:30 > i...@radix50.net wrote: > > > From: Henning Schild > > > > Signed-off-by: Henning Schild > > --- > > scripts/ci_build.sh | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh > > index d2c707b..af996d1 100755 > > --- a/scripts/ci_build.sh > > +++ b/scripts/ci_build.sh > > @@ -212,3 +212,15 @@ echo -e "do_fetch_append() {\n\n}" >> > > "${ISARROOT}/meta/classes/dpkg-base.bbclas > > bitbake $BB_ARGS mc:qemuamd64-stretch:isar-image-base > > > > mv "${ISARROOT}/meta/classes/dpkg-base.bbclass.ci-backup" > > "${ISARROOT}/meta/classes/dpkg-base.bbclass" > > + > > +# Test wic --exclude-path > > +cp -a > > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" > > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks.ci-backup" > > > > +mv > > ${BUILDDIR}/tmp/deploy/images/qemuamd64/isar-image-base-debian-stretch-qemuamd64.wic.img > > \ > > + > > ${BUILDDIR}/tmp/deploy/images/qemuamd64/isar-image-base-debian-stretch-qemuamd64.wic.img.ci-backup > > > > +sed -i -e 's/part \/ /part \/ --exclude-path usr /g' > > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" > > + > > +bitbake $BB_ARGS mc:qemuamd64-stretch:isar-image-base > > + > > +mv > > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks.ci-backup" > > "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" > > +mv > > ${BUILDDIR}/tmp/deploy/images/qemuamd64/isar-image-base-debian-stretch-qemuamd64.wic.img.ci-backup > > \ > > + > > ${BUILDDIR}/tmp/deploy/images/qemuamd64/isar-image-base-debian-stretch-qemuamd64.wic.img > > > > > > The only problem I see is the CI actually doesnot validate the image > to see if /usr is excluded. It validates the code-path for errors but > doesnot validate the feature itself. We could mount and check though. > Once the new wic is integrated this should be easy with the "wic ls" > feature. We could list the contents of the partition using > "wic ls" and validate if /usr is excluded. > > Thanks, > Vijai Kumar K >