From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6864480010557718528 X-Received: by 2002:aa7:c7da:: with SMTP id o26mr12940672eds.261.1599296297275; Sat, 05 Sep 2020 01:58:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:bf49:: with SMTP id g9ls5589878edk.1.gmail; Sat, 05 Sep 2020 01:58:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMCdZxgMdavq7jkl7I5cbcau7ukk3xitr5d0JMHYOvQfIuCPacaYmeCTlm1eaay6L5ZvjA X-Received: by 2002:aa7:da10:: with SMTP id r16mr12925468eds.333.1599296296663; Sat, 05 Sep 2020 01:58:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599296296; cv=none; d=google.com; s=arc-20160816; b=tl/AyMxOgvXznjglu9Xwa4oL03our0Aj9U/85SjDgfx+kKgGfhbFr5imMlvf+s8M10 7FfGrktG1ikwhF0ZiWO8ou8K0EZhXRv+8t4o/bfGq+0IX0Ldw4ZVm5HeAakHGUOHwW34 ELnJUQtlxJhKhiIwaO5OZHIslT7QeKRnclfYN0OGbCXe0oF6/1bWVGAXqnq6IEpVaLlF SsnKKolLESsnSk/yJCqIE35yak7pc+zBRtIbUkiumUpirOBtgTV7j2hCdA7bK5hf1GM7 YG1EhYXjY67SH656blgPhSTNQFhj/mkB5pcxGEhU1FVgn67FuTvmI6g8ymFvyf8i7At/ Io/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=ydkuJnTRTsFjpgvYS4RHSxz+dNGDM5aas5TqL21pxkI=; b=xhIJIldiHIM8BwGOxpgQ5xkmPlz0C+R3NGTjcIrkwaq4hah0gXW4kvX2d9k9iCQX/E 7NNmpjh1RVGy/4f6n4xSPsjGEqZJCL34Ta9they7t5+T0taf4jf/qsxwjBVQ8lmv+atc kfZU90+owhPyRmctEuy26L994VD4pxL/7M4g9NkJ1QMmfQ0EKR+GEQAIP/BTEctHVvBm H7SK0JlUyjqB0NbTZGmDYHTOHczgQBw2zYFhfkhpeLqE861+Vsienr4XpX/WFvykTtT7 nn+IOZw9otpiJOcO1aYHEzXQq0rGV95adjt6QzNjunUK47umqkeo5/ynJfM5shha89s1 cYFA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id r5si209275eda.1.2020.09.05.01.58.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Sep 2020 01:58:16 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 0858wGWc002256 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 5 Sep 2020 10:58:16 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.13.147]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 0858wFwF021702; Sat, 5 Sep 2020 10:58:15 +0200 Date: Sat, 5 Sep 2020 10:58:15 +0200 From: Henning Schild To: Vijai Kumar K Cc: Subject: Re: [PATCH v2 10/10] meta-isar/canned-wks: Remove /boot mountpoint Message-ID: <20200905105815.263d8c3e@md1za8fc.ad001.siemens.net> In-Reply-To: <20200902190247.15421-2-Vijaikumar_Kanagarajan@mentor.com> References: <20200902185624.15044-9-Vijaikumar_Kanagarajan@mentor.com> <20200902190247.15421-1-Vijaikumar_Kanagarajan@mentor.com> <20200902190247.15421-2-Vijaikumar_Kanagarajan@mentor.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Wsqp5kfNYbyH Hi, i do not like this one at all. Suggesting people to hide the boot partition from debian as hard as they can? If i understand it correctly. In fact the hiding is an issue that should be solved, debian should know about that partition and use it correctly. On EFI it only contains the bootloader, so such isar images will be able to receive kernel updates with apt-get during their lifetime. They will never be able to update the bootloader, but that might be ok. On BIOS the story is different. These systems have the kernel in the roots/boot only that kernel is never used for booting and the machines will never be able to update the kernel they boot. I always wanted to solve that but it was not too easy. The first idea was just bootloader in the boot partition, like efi. But syslinux can not boot files from other partitions, so we need the kernel and initrd there. But now with the exclude feature it might be easier. Place the bootloader and config into rootfs/boot and point to the kernel initrd symlinks in the config. (Done in our custom BIOS plugin) And now take rootfs/boot as boot, excluding it from rootfs. Henning On Thu, 3 Sep 2020 00:32:47 +0530 Vijai Kumar K wrote: > In the older version of wic, the fstab entry for /boot mountpoint > was skipped. > However in the latest wic this is not the case. Adding a /boot > mountpoint in part results in creating a fstab entry for automount. > Remove it to avoid the unwanted mount which makes original contents > unavailable in debian rootfilesystem. > > Signed-off-by: Vijai Kumar K > --- > RECIPE-API-CHANGELOG.md | 17 > +++++++++++++++++ .../lib/wic/canned-wks/common-isar.wks.inc | > 2 +- meta-isar/scripts/lib/wic/canned-wks/hikey.wks | 2 +- > .../scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +- > 4 files changed, 20 insertions(+), 3 deletions(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 1839770..070cde3 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -246,3 +246,20 @@ by setting DEBIAN_BUILD_DEPENDS. > > ${S} can now be used for checking out sources without being linked > implicitly with ${D} which needs to be filled explicitly in > do_install as before. + > +### Wic adds /boot mountpoint to fstab > + > +With the latest wic, /boot mount point, if any, is added to > /etc/fstab. Debian +uses /boot to store the kernel and initrd images. > If an image's wks file +specifies /boot mountpoint for boot > partitions like EFI, the image may fail to +boot or might make the > original contents of /boot unavailable after boot. +All unwanted > /boot mountpoints should be removed. + > +Below is an example wks entry that might cause an issue. > +``` > +part /boot --source bootimg-efi-isar --sourceparams > "loader=grub-efi" --ondisk sda --label efi --part-type EF00 --align > 1024 +``` +Drop the /boot entry to avoid issues. > +``` > +part --source bootimg-efi-isar --sourceparams "loader=grub-efi" > --ondisk sda --label efi --part-type EF00 --align 1024 +``` > diff --git a/meta-isar/scripts/lib/wic/canned-wks/common-isar.wks.inc > b/meta-isar/scripts/lib/wic/canned-wks/common-isar.wks.inc index > c8ea4c2..e7dabd4 100644 --- > a/meta-isar/scripts/lib/wic/canned-wks/common-isar.wks.inc +++ > b/meta-isar/scripts/lib/wic/canned-wks/common-isar.wks.inc @@ -1,3 > +1,3 @@ # This file is included into 3 canned wks files from this > directory -part /boot --source bootimg-pcbios-isar --ondisk sda > --label boot --active --align 1024 +part --source bootimg-pcbios-isar > --ondisk sda --label boot --active --align 1024 part / --source > rootfs --ondisk sda --fstype=ext4 --label platform --align 1024 diff > --git a/meta-isar/scripts/lib/wic/canned-wks/hikey.wks > b/meta-isar/scripts/lib/wic/canned-wks/hikey.wks index > 1e82f8c..840858e 100644 --- > a/meta-isar/scripts/lib/wic/canned-wks/hikey.wks +++ > b/meta-isar/scripts/lib/wic/canned-wks/hikey.wks @@ -3,7 +3,7 @@ # > # SPDX-License-Identifier: MIT > > -part /boot --source bootimg-efi-isar --sourceparams > "loader=grub-efi" --ondisk mmcblk1 --label efi --part-type EF00 > --align 1024 +part --source bootimg-efi-isar --sourceparams > "loader=grub-efi" --ondisk mmcblk1 --label efi --part-type EF00 > --align 1024 part / --source rootfs --ondisk mmcblk1 --fstype ext4 > --label platform --align 1024 --use-uuid diff --git > a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks > b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks index > 2afa016..e0fa7a1 100644 --- > a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks +++ > b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks @@ -2,7 +2,7 > @@ # long-description: Creates a partitioned EFI disk image without > any swap that # the user can directly dd to boot media. > -part /boot --source bootimg-efi-isar --sourceparams > "loader=grub-efi" --ondisk sda --label efi --part-type EF00 --align > 1024 +part --source bootimg-efi-isar --sourceparams "loader=grub-efi" > --ondisk sda --label efi --part-type EF00 --align 1024 part / > --source rootfs --ondisk sda --fstype ext4 --label platform --align > 1024 --use-uuid