From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6864480010557718528 X-Received: by 2002:ac2:522e:: with SMTP id i14mr5708646lfl.82.1599296688511; Sat, 05 Sep 2020 02:04:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:93c7:: with SMTP id p7ls2359172ljh.11.gmail; Sat, 05 Sep 2020 02:04:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOewI0Kv/JNN9YX06KcbkIroVEMqVUO2OQor/lI9S+egj/Arz/lcnOmg8lp/KmQfgBQJz8 X-Received: by 2002:a2e:7d07:: with SMTP id y7mr2980772ljc.179.1599296687688; Sat, 05 Sep 2020 02:04:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599296687; cv=none; d=google.com; s=arc-20160816; b=y1ZVgeqWyEOiUkgO8356YRN7lf1TdaqBx/Q4xnuu+tKBp0XCp9Ote+zLQ6Z6L/dJUg FoSLmNLFuEJhOuFvWogf5SGIohrBSUczNoFI3DY9ZUDj479YbEl4/n7PRoTC7TBMC/O7 bK4E9rPqu9xBDdh/6vGfzwak/AJcSVwfh+7sxW59oE2Vxsoqfp0x8V/UvP9yPnRp/HKY +oAW4wWMINGddVUN0h3glb83GpLZR3B9hUbKX5NZbuYJ8J6VwxISYiJJ8+ZR7+IBt9Bi aq5yC85lV3H26PabEFYmhmzFBmizazPV4KbYAr5mUy8SAm6WW4PUIYWVLIbMPwuRRg2y 7ytA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=dYXYmbbDaBW38KpruEYODPun+3s+ILeo+dIPzNSEPbo=; b=ocSBaXejGPp84vCapneMfLNOFIwbK3cTGwHs4J47Y8W2SkWT3r4YpT2EQGFkBZR5VX dMgnU496a8HarvKySmsbBnjKxN13Mabjnc4Ovl/cHsSLTuG/ahohkbqD2KuGDn9K0ZtJ N51TVPS5o+FwRr29fEQzwt1J1EqZ/+EOqtpP3yzWXQuQOaY6uXh1jQz2FMTx4mMahFiB qCBoVuLIHv905o9KBpaQYJFItoJHFPvPQaXdQdDIcVnB57atT4guq1CFivQBqiMmswPg FE+BJEU994QVZRgK1vGvWMX7fYS1SR48VxSb8+6mQJkdL0nS/hUmgj+hNAritVbCL0AG Stog== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id f12si378875lfs.1.2020.09.05.02.04.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Sep 2020 02:04:47 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 08594ktu027756 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 5 Sep 2020 11:04:46 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.13.147]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 08594jYT024784; Sat, 5 Sep 2020 11:04:45 +0200 Date: Sat, 5 Sep 2020 11:04:45 +0200 From: Henning Schild To: "vijaikumar....@gmail.com" Cc: isar-users Subject: Re: [PATCH v2 00/10] WIC update Message-ID: <20200905110445.6a7dbf28@md1za8fc.ad001.siemens.net> In-Reply-To: <6deeccbb-0139-4dc3-96f8-43f48d33d1c0n@googlegroups.com> References: <20200902185624.15044-1-Vijaikumar_Kanagarajan@mentor.com> <6deeccbb-0139-4dc3-96f8-43f48d33d1c0n@googlegroups.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: UYJ1LxMX9YFq This looks good at a first glance, left some comments. I assume the isar tests work with it. We already heard from Jan that he tested it on one of his layers. Did you happen to test it on one of you mentor layers, maybe a board with a "complex" wic setup. Henning On Wed, 2 Sep 2020 22:46:18 -0700 (PDT) "vijaikumar....@gmail.com" wrote: > If there are no review comments, can this get merged to next? > > Thanks, > Vijai Kumar K > > On Thursday, September 3, 2020 at 12:26:57 AM UTC+5:30 > vijaikumar_...@mentor.com wrote: > > > Changes since RFC(v1): > > > > - P9 commit is upstreamed and replaced with the version from > > OE-core. > > - P10: Lot of downstream projects tend to use /boot mountpoints for > > bootloader/EFI > > partitions. Added RECIPE-API-CHANGELOG entry to warn user about > > potential issues > > that might arise when doing so with latest wic. > > > > Henning Schild (1): > > lib/oe/path: try hardlinking instead of guessing when it might fail > > > > Paul Barker (1): > > oe.path: Add copyhardlink() helper function > > > > Vijai Kumar K (8): > > wic: Update to the latest wic from openembedded core > > wic/plugins: Fix wic plugins to work with the latest wic > > wic-img: Satisfy the quirks of latest wic > > wic_fakeroot: Handle standalone pseudo invocations > > meta-isar/conf: Add provision to debug WIC > > debian-common: Add tar as a dependency for wic > > wic: misc: Add /bin to the list of searchpaths > > meta-isar/canned-wks: Remove /boot mountpoint > > > > RECIPE-API-CHANGELOG.md | 17 + > > meta-isar/conf/local.conf.sample | 3 + > > .../lib/wic/canned-wks/common-isar.wks.inc | 2 +- > > .../scripts/lib/wic/canned-wks/hikey.wks | 2 +- > > .../lib/wic/canned-wks/sdimage-efi.wks | 2 +- > > meta/classes/wic-img.bbclass | 15 +- > > meta/conf/distro/debian-common.conf | 3 +- > > meta/lib/oe/path.py | 27 +- > > .../wic/plugins/source/bootimg-efi-isar.py | 2 +- > > .../wic/plugins/source/bootimg-pcbios-isar.py | 9 +- > > .../lib/wic/plugins/source/rootfs-u-boot.py | 2 +- > > scripts/lib/scriptpath.py | 32 ++ > > scripts/lib/wic/__init__.py | 14 +- > > scripts/lib/wic/canned-wks/common.wks.inc | 2 +- > > .../directdisk-bootloader-config.cfg | 8 +- > > .../lib/wic/canned-wks/efi-bootdisk.wks.in | 3 + > > scripts/lib/wic/canned-wks/mkhybridiso.wks | 2 +- > > scripts/lib/wic/canned-wks/qemuriscv.wks | 3 + > > .../lib/wic/canned-wks/qemux86-directdisk.wks | 2 +- > > .../lib/wic/canned-wks/sdimage-bootpart.wks | 4 +- > > .../lib/wic/canned-wks/systemd-bootdisk.wks | 4 +- > > scripts/lib/wic/engine.py | 421 +++++++++++++++- > > scripts/lib/wic/filemap.py | 170 ++++--- > > scripts/lib/wic/help.py | 401 ++++++++++++++-- > > scripts/lib/wic/ksparser.py | 115 +++-- > > scripts/lib/wic/{utils => }/misc.py | 100 ++-- > > scripts/lib/wic/partition.py | 234 ++++----- > > scripts/lib/wic/pluginbase.py | 36 +- > > scripts/lib/wic/plugins/imager/direct.py | 175 ++++--- > > .../wic/plugins/source/bootimg-biosplusefi.py | 213 +++++++++ > > scripts/lib/wic/plugins/source/bootimg-efi.py | 111 +++-- > > .../wic/plugins/source/bootimg-partition.py | 153 ++++-- > > .../lib/wic/plugins/source/bootimg-pcbios.py | 91 ++-- > > scripts/lib/wic/plugins/source/fsimage.py | 56 --- > > .../wic/plugins/source/isoimage-isohybrid.py | 185 +++---- > > scripts/lib/wic/plugins/source/rawcopy.py | 44 +- > > scripts/lib/wic/plugins/source/rootfs.py | 159 ++++-- > > scripts/lib/wic/utils/__init__.py | 0 > > scripts/lib/wic/utils/runner.py | 114 ----- > > scripts/wic | 452 +++++++++++++----- > > scripts/wic_fakeroot | 5 + > > 41 files changed, 2357 insertions(+), 1036 deletions(-) > > create mode 100644 scripts/lib/scriptpath.py > > create mode 100644 scripts/lib/wic/canned-wks/efi-bootdisk.wks.in > > create mode 100644 scripts/lib/wic/canned-wks/qemuriscv.wks > > rename scripts/lib/wic/{utils => }/misc.py (70%) > > create mode 100644 > > scripts/lib/wic/plugins/source/bootimg-biosplusefi.py delete mode > > 100644 scripts/lib/wic/plugins/source/fsimage.py delete mode 100644 > > scripts/lib/wic/utils/__init__.py delete mode 100644 > > scripts/lib/wic/utils/runner.py > > > > -- > > 2.17.1 > > > > >