From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
To: <isar-users@googlegroups.com>, <Vijaikumar_Kanagarajan@mentor.com>
Subject: [PATCH v3 9/9] meta-isar/canned-wks: Remove unwanted /boot mountpoint
Date: Mon, 7 Sep 2020 21:50:18 +0530 [thread overview]
Message-ID: <20200907162018.16636-6-Vijaikumar_Kanagarajan@mentor.com> (raw)
In-Reply-To: <20200907162018.16636-1-Vijaikumar_Kanagarajan@mentor.com>
In the older version of wic, the fstab entry for /boot mountpoint
was skipped. However in the latest wic this is not the case.
Adding a /boot mountpoint in part results in creating a fstab
entry for automount.
It is observed that in some kickstart files, /boot is used as a
mount point for bootloaders. This was okay with the previous
wic since anyway it ignored adding /boot mount points to fstab.
With the new wic, this now causes an unwanted mount of that partition
in /boot which inturn makes the original contents of /boot unavailable
after a successful boot.
This is not the default behaviour expected.
Remove such bogus /boot mount point in wks files.
Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
RECIPE-API-CHANGELOG.md | 23 +++++++++++++++++++
.../lib/wic/canned-wks/common-isar.wks.inc | 2 +-
.../scripts/lib/wic/canned-wks/hikey.wks | 2 +-
.../lib/wic/canned-wks/sdimage-efi.wks | 2 +-
4 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index 1839770..c677b1d 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -246,3 +246,26 @@ by setting DEBIAN_BUILD_DEPENDS.
${S} can now be used for checking out sources without being linked implicitly
with ${D} which needs to be filled explicitly in do_install as before.
+
+### Wic adds /boot mountpoint to fstab
+
+With the latest wic, /boot mount point, if any, is added to /etc/fstab. Debian
+uses /boot to store the kernel and initrd images.
+
+Any wks file which assumed that /boot would be skipped from /etc/fstab should
+now be corrected. Otherwise, the original /boot contents, i.e kernel initrd &
+config files will be unavailable after boot.
+
+Below is an example wks entry that might cause an issue. The rootfs already
+has /boot with valid contents. Specifying /boot as mount point for the efi
+partition would only make /boot contents of "part /" unavailable after boot.
+```
+part /boot --source bootimg-efi-isar --sourceparams "loader=grub-efi" --ondisk sda --label efi --part-type EF00 --align 1024
+part / --source rootfs --ondisk sda --fstype ext4 --label platform --align 1024 --use-uuid
+```
+If mounting /boot parition is an unwanted behaviour in your target then
+remove it.
+```
+part --source bootimg-efi-isar --sourceparams "loader=grub-efi" --ondisk sda --label efi --part-type EF00 --align 1024
+part / --source rootfs --ondisk sda --fstype ext4 --label platform --align 1024 --use-uuid
+```
diff --git a/meta-isar/scripts/lib/wic/canned-wks/common-isar.wks.inc b/meta-isar/scripts/lib/wic/canned-wks/common-isar.wks.inc
index c8ea4c2..e7dabd4 100644
--- a/meta-isar/scripts/lib/wic/canned-wks/common-isar.wks.inc
+++ b/meta-isar/scripts/lib/wic/canned-wks/common-isar.wks.inc
@@ -1,3 +1,3 @@
# This file is included into 3 canned wks files from this directory
-part /boot --source bootimg-pcbios-isar --ondisk sda --label boot --active --align 1024
+part --source bootimg-pcbios-isar --ondisk sda --label boot --active --align 1024
part / --source rootfs --ondisk sda --fstype=ext4 --label platform --align 1024
diff --git a/meta-isar/scripts/lib/wic/canned-wks/hikey.wks b/meta-isar/scripts/lib/wic/canned-wks/hikey.wks
index 1e82f8c..840858e 100644
--- a/meta-isar/scripts/lib/wic/canned-wks/hikey.wks
+++ b/meta-isar/scripts/lib/wic/canned-wks/hikey.wks
@@ -3,7 +3,7 @@
#
# SPDX-License-Identifier: MIT
-part /boot --source bootimg-efi-isar --sourceparams "loader=grub-efi" --ondisk mmcblk1 --label efi --part-type EF00 --align 1024
+part --source bootimg-efi-isar --sourceparams "loader=grub-efi" --ondisk mmcblk1 --label efi --part-type EF00 --align 1024
part / --source rootfs --ondisk mmcblk1 --fstype ext4 --label platform --align 1024 --use-uuid
diff --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
index 2afa016..e0fa7a1 100644
--- a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
+++ b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
@@ -2,7 +2,7 @@
# long-description: Creates a partitioned EFI disk image without any swap that
# the user can directly dd to boot media.
-part /boot --source bootimg-efi-isar --sourceparams "loader=grub-efi" --ondisk sda --label efi --part-type EF00 --align 1024
+part --source bootimg-efi-isar --sourceparams "loader=grub-efi" --ondisk sda --label efi --part-type EF00 --align 1024
part / --source rootfs --ondisk sda --fstype ext4 --label platform --align 1024 --use-uuid
--
2.17.1
prev parent reply other threads:[~2020-09-07 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 16:17 [PATCH v3 0/9] WIC update Vijai Kumar K
2020-09-07 16:17 ` [PATCH v3 1/9] wic: Update to the latest wic from openembedded core Vijai Kumar K
2020-09-07 16:17 ` [PATCH v3 2/9] wic/plugins: Fix wic plugins to work with the latest wic Vijai Kumar K
2020-09-07 16:17 ` [PATCH v3 3/9] wic-img: Satisfy the quirks of " Vijai Kumar K
2020-09-07 16:20 ` [PATCH v3 4/9] oe.path: Add copyhardlink() helper function Vijai Kumar K
2020-09-07 16:20 ` [PATCH v3 5/9] lib/oe/path: try hardlinking instead of guessing when it might fail Vijai Kumar K
2020-09-07 16:20 ` [PATCH v3 6/9] wic_fakeroot: Handle standalone pseudo invocations Vijai Kumar K
2020-09-07 16:20 ` [PATCH v3 7/9] meta-isar/conf: Add provision to debug WIC Vijai Kumar K
2020-09-07 16:20 ` [PATCH v3 8/9] debian-common: Add tar as a dependency for wic Vijai Kumar K
2020-09-07 16:20 ` Vijai Kumar K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907162018.16636-6-Vijaikumar_Kanagarajan@mentor.com \
--to=vijaikumar_kanagarajan@mentor.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox