From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6868613252732944384 X-Received: by 2002:a17:906:c830:: with SMTP id dd16mr3863325ejb.196.1599659085934; Wed, 09 Sep 2020 06:44:45 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c9c2:: with SMTP id i2ls2909319edt.2.gmail; Wed, 09 Sep 2020 06:44:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIrQ8pgwVl+vN8vJBE2NS2jLcQBg8TKINfP3fZwPjqCAJZa5odIQwWyZGW+IxypzT61Y34 X-Received: by 2002:aa7:d697:: with SMTP id d23mr4297970edr.13.1599659084944; Wed, 09 Sep 2020 06:44:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599659084; cv=none; d=google.com; s=arc-20160816; b=fC6oRzLU6PlIK8sZJiKcSiAAxwSThu0Hwvi/HNapJsjNPxdR86S+XyihIx0b2xyflT r+ujlSmocIxm+IISOGaCKerj18Cec5WxADh7Z9ecS4ytHl+WBxtBxw/gysYPwKP++sXN QOdD6GdIXieknAzE3HlKh52K6SqMTS7LFcimgHsxg0HFLL8TjgtMBVt/YTKzbo34qXbT VHIKThZEl6bbFodubzL9Qr5comgVGL1Dwu23bd6DiHwGo3xeOmUA79WEUrdL6ynMMntG WVpMo0FMjQx0JMGgUtafeOW/Sj4BFrOziyeEOV5UqB16FRtkb+d9Qge7WE16r13ZsHpg uK3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=smJQ5O7FVWI+Agf2bulaTP9Guq1wd6e2P/CNS4ducjU=; b=tJ3cr2fJSBwD9+hxXTUuesrGyACiCdy7ElkRGcVog7xQDFeVPARRRU0dFTxKomnKg+ p5VJEagTO+FRYbIjcdUzpQ1SFpjphkGyYNbmEG9A3Kewp1fblj+z6J4PqaFqAB4GsaVo vjXOc9pdQ3JZ1ztYomD5QChCxNZvtVbRhVgA7tZpybb+zDOlZlqFNeT4N3sZdcK9JWwC DNM+UMjkE01wQYwznNBuV6cFF7oC+6fMX1fwO7axeFlDlklhp3mFwDMiUPifK9jf6YIx NoSxViL+djl99eAcgobrEjbJGdArWluu4ujeutjWT7+paa+Sc/acEswzwL1ABXUfwUDn LBmA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id dk15si138067edb.2.2020.09.09.06.44.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Sep 2020 06:44:44 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 089Diine005292 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 9 Sep 2020 15:44:44 +0200 Received: from md1za8fc.ad001.siemens.net ([167.87.59.40]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 089DiiE0029917; Wed, 9 Sep 2020 15:44:44 +0200 Date: Wed, 9 Sep 2020 15:44:42 +0200 From: Henning Schild To: "[ext] Jan Kiszka" Cc: isar-users Subject: Re: [PATCH 2/2] ci: Add compat arch support Message-ID: <20200909154442.1241936f@md1za8fc.ad001.siemens.net> In-Reply-To: References: <64fa79e829f2b29553b2baedabc766f7ec3ef230.1599223641.git.jan.kiszka@siemens.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: D3a7aSnfnLEm On Tue, 8 Sep 2020 10:53:58 +0200 "[ext] Jan Kiszka" wrote: > On 04.09.20 14:47, [ext] Jan Kiszka wrote: > > From: Jan Kiszka > > > > Build hello-isar and libisar for the compat arch if that is enabled. > > Set ISAR_ENABLE_COMPAT_ARCH for all supported combinations in CI. > > > > Signed-off-by: Jan Kiszka > > --- > > meta-isar/recipes-app/hello-isar/hello-isar.bb | 3 +++ > > meta-isar/recipes-app/libhello/libhello.bb | 3 +++ > > scripts/ci_build.sh | 6 ++++++ > > 3 files changed, 12 insertions(+) > > > > diff --git a/meta-isar/recipes-app/hello-isar/hello-isar.bb > > b/meta-isar/recipes-app/hello-isar/hello-isar.bb index > > 144a433e..8c3ba8b2 100644 --- > > a/meta-isar/recipes-app/hello-isar/hello-isar.bb +++ > > b/meta-isar/recipes-app/hello-isar/hello-isar.bb @@ -20,4 +20,7 @@ > > SRC_URI = " \ file://yet-another-change.txt;apply=yes;striplevel=0" > > SRCREV = "a18c14cc11ce6b003f3469e89223cffb4016861d" > > > > +# NOTE: This is just to test 32-bit building on 64-bit archs. > > +PACKAGE_ARCH_compat-arch = "${COMPAT_DISTRO_ARCH}" > > + > > inherit dpkg > > diff --git a/meta-isar/recipes-app/libhello/libhello.bb > > b/meta-isar/recipes-app/libhello/libhello.bb index > > ab271b58..5c44de50 100644 --- > > a/meta-isar/recipes-app/libhello/libhello.bb +++ > > b/meta-isar/recipes-app/libhello/libhello.bb @@ -13,4 +13,7 @@ PV = > > "0.1-98f2e41" SRC_URI = > > "git://github.com/ilbers/libhello.git;protocol=https;destsuffix=${P}" > > SRCREV = "98f2e41e7d05ab8d19b0c5d160b104b725c8fd93" > > +# NOTE: This is just to test 32-bit building on 64-bit archs. > > +PACKAGE_ARCH_compat-arch = "${COMPAT_DISTRO_ARCH}" > > + > > inherit dpkg > > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh > > index d2c707b8..461fd5cc 100755 > > --- a/scripts/ci_build.sh > > +++ b/scripts/ci_build.sh > > @@ -139,6 +139,12 @@ if [ ! -d "$BUILD_DIR" ]; then > > fi > > source isar-init-build-env "$BUILD_DIR" > > > > +cat >>conf/local.conf < > +ISAR_ENABLE_COMPAT_ARCH_amd64 = "1" > > +ISAR_ENABLE_COMPAT_ARCH_arm64 = "1" > > +ISAR_ENABLE_COMPAT_ARCH_debian-stretch_amd64 = "0" > > +EOF > > + > > if [ -n "$CROSS_BUILD" ]; then > > sed -i -e 's/ISAR_CROSS_COMPILE ?= "0"/ISAR_CROSS_COMPILE ?= > > "1"/g' conf/local.conf fi > > > > This triggers a problem: > > In a multiconfig setup like our CI, building the 32-bit package from > both the native 32-bit arch as well as the 64-bit arch now races. If > the 64-bit arch tries to install its self-built compat package, that > may just be under re-deployment by the 32-bit arch, and the build > fails. > > Options: > - somehow express that both archs provide the same package (though > that may defeat the purpose of testing the compat build) The purpose is that people want to use compat because they have just one image. > - split isar-apt per arch, not just per distro But would the compat not need to include both now, and the mc enemy would still mess with one of them? - better/more locking around isar-apt readers and writers > Suggestions? Well one thing ... but i do not want to repeat myself ... Henning > Jan >