From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6876081981542629376 X-Received: by 2002:a05:6512:10d1:: with SMTP id k17mr289845lfg.179.1600982879013; Thu, 24 Sep 2020 14:27:59 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:c7c8:: with SMTP id x191ls180183lff.0.gmail; Thu, 24 Sep 2020 14:27:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzvFlLqbRPW2RKNDy4RMZdk0YztS5cBxlHSh3BCO5VPN73g3JwCUHBnpBp7h2rJ3K1RIJP X-Received: by 2002:ac2:4acf:: with SMTP id m15mr236309lfp.261.1600982877916; Thu, 24 Sep 2020 14:27:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600982877; cv=none; d=google.com; s=arc-20160816; b=sw1tnu9J+2mZ2mEy91eULmCWfO4CgtpGSdkn1m7/ZLvgALN9qAE46rpxUA83RY6+cZ JBTerz/7zT0RGMxVfvaPL+7nW+nnPsAFC1h9nUy9+toLjFmGLRTdYGbCGhrFkcDcsD5Y 92PT8R84CDaep8C7wwaiPsQoEH5Wl95JE1DJ0zZd0i/v8otmxpqaIE6S37LqfhrqpK3b eHkFlUmP4tiYfkPr0TW/R2CsxJmfRR/S45/JVJeDvZE530wDXxiLR67pesNEgZQ+nvJI f0Jn/gg4sy7TqJAolztd7BMCdZYGEYybVpQD2HlasS7ZRNdVS1Bdg6vPWX7eJc6yifIS RETQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=fV3LzXEWaPBxqb7HlCy4JpcxOQBnxQubwmBgkYtXRdE=; b=E3ITdrOBroPYwoUd1aeJFQ+z7zb5+dNXcgdDGEk6z8IPAtvBp3FBHEsrmsi8sc1Fgs Hdb3BYhOpnfbMglegwu2zInWcigv8n5ojzSidbchVnjqbmPsQgD5uXyhQ4aNdhnTrKtJ 2Wlbdx/sI8CslBxrAEpnm1Os2ahr2ET2h0StTy15Vw5CuCe2JHGAIb2obVUYyogbAibO ZPKzh/CkSra5qIxtTeDsXZeBfxe/AMeuUwiGvaz7BSQuzCf0LtnJ9UkhySud3btJAT2k kFbigiVywABplYqybSLeKZ0B44+u4nOjwXddO96WpXPZbNlD1SoF7m7mSOVkMIiUvSBi J68A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id f23si10377ljg.8.2020.09.24.14.27.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Sep 2020 14:27:57 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 08OLRvhG004540 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 24 Sep 2020 23:27:57 +0200 Received: from md1za8fc.ad001.siemens.net ([139.22.41.43]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 08OLRukY016055; Thu, 24 Sep 2020 23:27:56 +0200 Date: Thu, 24 Sep 2020 23:27:53 +0200 From: Henning Schild To: "[ext] Jan Kiszka" Cc: isar-users Subject: Re: [PATCH 2/5] deb-dl-dir: Fix quoting Message-ID: <20200924232753.2466f655@md1za8fc.ad001.siemens.net> In-Reply-To: <815ce8ec0fadec7ba3a5b8bf49e48c10e7370142.1600962590.git.jan.kiszka@siemens.com> References: <815ce8ec0fadec7ba3a5b8bf49e48c10e7370142.1600962590.git.jan.kiszka@siemens.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: TTZ0ULu0WNhd Good catch! On Thu, 24 Sep 2020 17:49:48 +0200 "[ext] Jan Kiszka" wrote: > From: Jan Kiszka > > The outer flock call wraps this in '', so this can't be used inside > the block. The current code failed if some .deb file happened to lie > around in the build folder. > > Signed-off-by: Jan Kiszka > --- > meta/classes/deb-dl-dir.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/deb-dl-dir.bbclass > b/meta/classes/deb-dl-dir.bbclass index e9967036..54c29947 100644 > --- a/meta/classes/deb-dl-dir.bbclass > +++ b/meta/classes/deb-dl-dir.bbclass > @@ -14,8 +14,8 @@ deb_dl_dir_import() { > set -e > printenv | grep -q BB_VERBOSE_LOGS && set -x > > - sudo find "${pc}" -type f -iname '*\.deb' -exec \ > - cp -n --no-preserve=owner -t > "${rootfs}"/var/cache/apt/archives/ '{}' + > + sudo find "${pc}" -type f -iname "*\.deb" -exec \ > + cp -n --no-preserve=owner -t > "${rootfs}"/var/cache/apt/archives/ {} + ' > } >