From: Baurzhan Ismagulov <ibr@radix50.net>
To: isar-users@googlegroups.com
Subject: Re: [PATCH v3 06/16] sdk: Add support for adding self-defined sdk packages
Date: Wed, 7 Oct 2020 10:06:39 +0200 [thread overview]
Message-ID: <20201007080638.GI5019@yssyq.m.ilbers.de> (raw)
In-Reply-To: <9f4047a0-d11f-adff-1601-643b4e8a5cae@siemens.com>
On Wed, Oct 07, 2020 at 09:30:06AM +0200, Jan Kiszka wrote:
> OK, need to check again. Cannot explain yet why that should happen,
> given the change in patch 9. Maybe I have a regression further down the
> series...
Thanks, please let us know. I also stared at the line for some time and
couldn't see what is wrong.
> > This explains to the user how Debian multiarch works with option 2. This
> > example works inside or outside of the chroot. We should not be removing
> > documentation for a supported use case, thus NAK here.
> >
>
> This hunk looks pointless to me. Why should the user try out all that
> stuff? It's the duty of the SDK creator to do that upfront and ship a
> properly working package.
Trying in the context of SDK -- that's a matter of taste, I like when some
background is presented rather than "do 1, 2, 3", sometimes without
understanding what I'm really doing. The hunk explains how Debian officially
handles cross-building with multiarch, so I'd be reluctant to remove that
completely. Maybe we could make it a separate section on Debian basics or
details how SDK option 2 is implemented.
> Thanks, will fix.
>
> But please comment inline, not out of context.
I wanted to avoid scattering the issue over many mails -- but no problem, I can
do it.
With kind regards,
Baurzhan.
next prev parent reply other threads:[~2020-10-07 8:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 15:28 [PATCH v3 00/16] Complete backlog: SDK, compat arch, assorting fixed and cleanups Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 01/16] Split up isar-apt into distro-arch specific instances Jan Kiszka
2020-10-06 8:29 ` Baurzhan Ismagulov
2020-09-22 15:28 ` [PATCH v3 02/16] linux-custom: Clean up minor inconsistencies in rules.tmpl Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 03/16] sshd-regen-keys: Issue sync after regeneration Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 04/16] meta-isar: Drop outdated cross-compilation comment Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 05/16] qemuamd64: Fix OVMF path Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 06/16] sdk: Add support for adding self-defined sdk packages Jan Kiszka
2020-09-29 19:15 ` Baurzhan Ismagulov
2020-09-30 19:19 ` Jan Kiszka
2020-10-06 9:00 ` Baurzhan Ismagulov
2020-10-07 7:30 ` Jan Kiszka
2020-10-07 8:06 ` Baurzhan Ismagulov [this message]
2020-10-07 13:36 ` Jan Kiszka
2020-10-15 21:51 ` Baurzhan Ismagulov
2020-10-16 7:15 ` Jan Kiszka
2020-11-01 15:17 ` Baurzhan Ismagulov
2020-09-22 15:28 ` [PATCH v3 07/16] sdk: Make all links in the SDK chroot relative Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 08/16] sdk: Add script to relocate SDK Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 09/16] sdk: Make shipping the isar-apt repo opt-in Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 10/16] sdk: Inject sysroot path when calling relocated toolchain Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 11/16] sdk: Update README.sdk Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 12/16] Add compat architecture support via multiarch Jan Kiszka
2020-09-24 20:19 ` Baurzhan Ismagulov
2020-09-22 15:28 ` [PATCH v3 13/16] ci: Add compat arch support Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 14/16] doc: Enhance list of supported cross-archs, drop QEMU reference Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 15/16] doc: Describe new compat arch support Jan Kiszka
2020-09-22 15:28 ` [PATCH v3 16/16] isar-bootstrap: Connect to gpg-agent before adding keys Jan Kiszka
2020-09-22 21:03 ` Jan Kiszka
2020-09-23 20:29 ` Baurzhan Ismagulov
2020-09-24 9:10 ` [PATCH v4 " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007080638.GI5019@yssyq.m.ilbers.de \
--to=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox