public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
To: <isar-users@googlegroups.com>, <ibr@radix50.net>
Cc: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
Subject: [PATCH v9 12/14] rootfs: Fix possible overwrite of existing resolv.conf
Date: Thu, 26 Nov 2020 16:51:06 +0530	[thread overview]
Message-ID: <20201126112108.3320-4-Vijaikumar_Kanagarajan@mentor.com> (raw)
In-Reply-To: <20201126112108.3320-1-Vijaikumar_Kanagarajan@mentor.com>

There is a possiblilty that one of the packages installed in the
rootfs provides /etc/resolv.conf and we might accidentally remove
it. Fix it by taking a backup of any existing resolv conf files
and restoring it later. This is needed since we could not effectively
move caching before rootfs_install_clean_files since we need the
latest dpkg log.

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
 meta/classes/rootfs.bbclass | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index 9142f12..b6dc2c8 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -185,10 +185,18 @@ python do_rootfs_install() {
 addtask rootfs_install before do_rootfs_postprocess after do_unpack
 
 cache_deb_src() {
+    if [ -e "${ROOTFSDIR}"/etc/resolv.conf ]; then
+        sudo mv "${ROOTFSDIR}"/etc/resolv.conf "${ROOTFSDIR}"/etc/resolv.conf.isar
+    fi
     rootfs_install_resolvconf
+
     deb_dl_dir_import ${ROOTFSDIR} ${ROOTFS_DISTRO}
     debsrc_download ${ROOTFSDIR} ${ROOTFS_DISTRO}
-    rootfs_install_clean_files
+
+    sudo rm -f "${ROOTFSDIR}"/etc/resolv.conf
+    if [ -e "${ROOTFSDIR}"/etc/resolv.conf.isar ]; then
+        sudo mv "${ROOTFSDIR}"/etc/resolv.conf.isar "${ROOTFSDIR}"/etc/resolv.conf
+    fi
 }
 
 ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-package-cache', 'rootfs_postprocess_clean_package_cache', '', d)}"
-- 
2.17.1


  parent reply	other threads:[~2020-11-26 11:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 11:18 [PATCH v9 00/14] Debsrc caching Vijai Kumar K
2020-11-26 11:18 ` [PATCH v9 01/14] rootfs: Make rootfs finalize a separate task Vijai Kumar K
2020-11-26 11:19 ` [PATCH v9 02/14] deb-dl-dir: Cache host distro debs separately Vijai Kumar K
2020-11-26 11:19 ` [PATCH v9 03/14] meta: cache deb srcs as part of postprocessing Vijai Kumar K
2020-11-26 11:19 ` [PATCH v9 04/14] deb-dl-dir: Make debsrc_download faster Vijai Kumar K
2020-11-26 11:19 ` [PATCH v9 05/14] deb-dl-dir: Download files only belonging to the current image Vijai Kumar K
2020-11-26 11:19 ` [PATCH v9 06/14] deb-dl-dir: Factor out the mounting part Vijai Kumar K
2020-11-26 11:19 ` [PATCH v9 07/14] deb-dl-dir: Fix skipping of removed files Vijai Kumar K
2020-11-26 11:19 ` [PATCH v9 08/14] repository: Add a sanity test to check missing sources Vijai Kumar K
2020-11-26 11:21   ` [PATCH v9 09/14] base-apt: Introduce BASE_REPO_FEATURES Vijai Kumar K
2020-11-26 11:21     ` [PATCH v9 10/14] repository: Fix failures due to missing section Vijai Kumar K
2020-11-26 11:21     ` [PATCH v9 11/14] scripts/ci_build.sh: Enable deb-src caching Vijai Kumar K
2020-11-26 11:21     ` Vijai Kumar K [this message]
2020-11-26 11:21     ` [PATCH v9 13/14] rootfs: Handle failures when postprocess is rerun Vijai Kumar K
2020-11-26 11:22       ` [PATCH v9 14/14] doc/user_manual.md: Document details about deb-src caching Vijai Kumar K
2020-11-26 17:28         ` Anton Mikanovich
2020-11-26 17:56           ` vijaikumar....@gmail.com
2020-11-26 18:12             ` vijaikumar....@gmail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126112108.3320-4-Vijaikumar_Kanagarajan@mentor.com \
    --to=vijaikumar_kanagarajan@mentor.com \
    --cc=ibr@radix50.net \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox