Re: [RFC] Image templates

[Joe MacDonald <Joe_MacDonald@mentor.com>]

[-- Attachment #1: Type: text/plain, Size: 10845 bytes --]

Hi Jan,

[Re: [RFC] Image templates] On 20.12.01 (Tue 09:40) Jan Kiszka wrote:

> On 01.12.20 08:59, Cedric Hombourger wrote:
> > Image Templates for ISAR
> > ========================
> > 
> > Introduction
> > ------------
> > 
> > Embedded System projects may have multiple teams working at different
> > levels. It is not uncommon to have groups creating a "base platform"
> > which is handed over to product teams to customize further.
> > Thanks to ISAR leveraging bitbake, image recipes from a base layer may
> > be easily extended by product layers but also with its ability to
> > produce and use a `base-apt` instead of upstream package feeds.
> > This workflow functions well in many cases, it may not be optimal for
> > application teams. Such teams are typically receiving a base platform
> > release that is likely to be left untouched for weeks.
> > Creating a product image for those teams is sometimes as easy as adding
> > a few packages.
> 
> There is another use case, even for base image developers: accelerating
> the turn-around time when working only on few, widely isolated packages,
> may it be the kernel or a bootloader artifact.
> 
> For that scenario, it should be possible to define an image template
> excluding those bits, only injecting them on top in a second step.

That's a very good point.  We will incorporate the additional use case
idea in a revised verison of the proposal.  Do you have thoughts on what
the implementation may look like for this?  An explicit list of packages
in the image that should be removed or otherwise excluded from the
generated template?

> > In such cases, it may be desirable to have a mechanism for ISAR to
> > construct product images starting from the base platform root
> > file-system instead of ISAR's bootstrap root file-system. We will refer
> > to these base platform root file-systems as _Template Images_.
> > 
> > This document will describe both the construction and the use of
> > _template images_.
> > 
> > Construction
> > ------------
> > 
> > Developers needing to produce image templates in addition to bootable
> > system images will have their image recipes `inherit` the
> > `produce-image-template` class either as part of their image development
> > or by extending an existing image with an appropriate `.bbappend`.
> > 
> > The class would invoke a `do_rootfs_template` task after
> > `do_rootfs_install` and before the post-processing tasks (which should
> > be applied on the final image). This new task would simply create a
> > template image in the deploy folder built from the common root
> > file-system artifacts. Some systems may have additional, more extensive
> > post-processing operations that must be performed on the final
> > image, this class will still allow for such operations to function
> > normally.
> > 
> > It is anticipated that configuration files in `/etc/apt/sources.list.d`
> > and `/etc/resolv.conf` should be excluded (they should be recreated
> > while the template image is imported). A subsequent update
> > will define a criteria for determining which files should be excluded
> > from the tarball. As yet the specific mechanism has not been determined,
> > whether it would be a file list, pattern or some other
> > external attributes. We anticipate other objects that may need to be
> > excluded are `/etc/hosts` and proxy configuration, to name two simple
> > examples.
> > 
> > The process of constructing the base image would then continue as usual
> > (with post-processing and imager tasks).
> > 
> > It is suggested to expose the produced image template as an opaque
> > binary blob and use a `.tmpl.img` file extension although the initial
> > implementation is anticipated to be a compressed tarball.
> > The template filesystem may need embedded meta-data to be consumed by
> > import mechanism or image recipes that make use of templates but omitted
> > from the final rootfs. It would be useful at the outset
> > to either specify a minimal set of metadata (build date, image name and
> > feature list is the initial list to be considered) and the structure of
> > that metadata (currently considering either JSON-formatted
> > suitable for extraction with `jq` or `deb` packaging, which has embedded
> > metadata in the cpio archive).
> > 
> > Usage
> > -----
> > 
> > Application teams may create image recipes referencing image templates
> > in their SRC_URI list. As noted above, image templates would use the
> > `.tmpl.img` file extension. This would be used by ISAR's `rootfs`
> > class to locate image templates in the list and make sure that only one
> > template is specified (extracting a template over another would have
> > unpredictable results).
> > 
> > If the bulk of the template intelligence is present in the `do_rootfs`
> > stages, the `do_rootfs_prepare` task from the `rootfs` class would
> > behave differently.  In this case, an image template may be added to
> > an image SRC_URI. Instead of copying ISAR's bootstrap rootfs, the
> > template feature would instead unpack the specified template. It would
> > also be necessary to copy `/etc/apt/sources.list.d` from the bootstrap
> > and possibly other files (e.g. `/etc/resolv.conf`). As the environment
> > may include different apt sources, a complete `apt-get update` would be
> > in order.
> > 
> > ISAR would then "enter" the unpacked template carrying updated apt
> > sources to install packages listed in `IMAGE_INSTALL` and
> > `IMAGE_PREINSTALL` using `apt- get install` as it does today in
> > `do_rootfs_install`.
> > 
> > This design should allow images constructed from an image template to
> > produce a new image template (e.g. a base platform could provide a
> > template having a BSP and a minimal Debian system, and middleware teams
> > could then produce their own template with middleware stacks added and
> > finally consumed by application teams to produce a final system image).
> > 
> 
> There will likely be a number of traps we can stumble over, but the
> general vision is shared.
> 
> One of the trap is that you may not only need a target image template
> but also the corresponding buildchroots, if not isar-bootstraps.

Also a good point.  I wonder if we could avoid this by having a second
manifest (maybe another SRC_URI-like variable) for the template which
would include development versions of all installed packages or something
and then during development the template will include them but the final
image that derives from the template would have those removed unless
specifically added by the final image SRC_URI.  It would be nice, if
possible, to avoid having to bundle the image and the chroot/bootstrap
directories as well.

> Would your model be that a developer works within the layer that creates
> the template? A key issue would be that changes to the layer that
> invalidate the template would be detected and make the template-based
> build fail or fall back to the full build.
> 
> Or would your model be that templating enforce a split build via
> separate repos? That might be problematic from the maintenance
> perspective as application injection will come before imaging, and the
> latter is not the task of an application developer.

Cedric and I may have different views on this.  Personally I had been
thinking it would be more along the lines of the latter, where the
templates are entirely an external entity that a developer brings in, so
there would be no 'risk' of the template being invalidated and recreating
a full build.  The primary motiviation for this, from my perspective, is
that it's better for such a change to cause a failure and be flagged
appropriately than for it to silently build and give the developer the
impression that they are building on top of the specified template but are
really using something different.

I'm not sure what you mean about this being a problem for application
developers.  Can you elaborate a bit?  It seems to me that this isn't
significantly different thatn any existing Isar workflow is today and it
is still possible for the application developer to simply generate a
binary deb and install that on a deployed system whether that system was
assembled from templates or in the more traditional manner.

> > Future Work
> > -----------
> > 
> > It may be desirable to offer a mechanism to remove packages coming from
> > an image template (application teams may need to optimize the final
> > system image to meet the footprint constraints of their design and/or
> > to reduce the attack surface by removing services they do not need).
> > 
> > Status
> > ------
> > 
> > This high-level design was created to seek early feedback from the ISAR
> > developer community by exposing the problem we are trying to solve and
> > the mechanism we are proposing as a solution. The next step would be
> > the development of a Proof-of-Concept in the event where positive
> > comments are received. This document may also be updated as feedback is
> > received and may result in different approaches being discussed.
> > 
> > We will be happy to answer questions you may have or provide more
> > details in areas where this document would be too evasive.
> > 
> 
> The whole thing also reminds me a lot of how docker images are created.
> I wonder to which degree we can learn from that, reuse concepts or avoid
> pitfalls. Adding Silvano with whom I was recently discussing base
> container image generation via Isar.

Oh, that's very interesting!  I'd been thinking the same thing, and
certainly it's no coincidence that the proposal does somewhat follow the
same model as Docker container assembly.  I think there are some very good
ideas in the way Docker containers are created and there are some things
that are very limiting and seem like unnecessary restrictions, so I would
certainly welcome the opportunity to discuss those further.

About a year ago I'd started putting infrastructure into our IndustrialOS
builds to automatically generate Docker images alongside our current IPC
wic images.  In the end, coming up with a good way to create usable
Docker-style workflows seemed like more effort than we could justify at
the time for something for which we had no customer-driven use-case, and I
just created a script to do much the same thing outside of the Isar build
process.  I still think it's an excellent idea to use Isar to generate
base images, though, I'd be very interested in the discussion when you're
ready to share details.

> 
> Jan
> 
> -- 
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux

-- 
-Joe MacDonald.
Linux Architect | Mentor® A Siemens Business
:wq

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]