From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6917993065941565440 X-Received: by 2002:adf:df12:: with SMTP id y18mr1226514wrl.141.1611044735971; Tue, 19 Jan 2021 00:25:35 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:5543:: with SMTP id g3ls11885336wrw.0.gmail; Tue, 19 Jan 2021 00:25:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwV9rbDm531EvJjyHNOKyD6nJ0p35B11ZuaXRvx7L3VqsbE5LXxbYEk1kMg8hCgqtwN5nMS X-Received: by 2002:adf:efc5:: with SMTP id i5mr3018726wrp.377.1611044735100; Tue, 19 Jan 2021 00:25:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611044735; cv=none; d=google.com; s=arc-20160816; b=woIEkmQvauqesGjF7wz/bHluysc/nxZ5Zx5u9CTwsKMYlo2ThU9WZSiy5Av2DZc2d/ Sw1NYF/VHYvcFw+z6pUi2A3BZ+XrOrd1qRvr45PuGEHjGKrLLBFyXHOS4twtInC/tzKx oiNWWRHOSXdrwffFFFwhQEikL1wcH7P6l7jQ3NYhlgTdSaq8pBVB6MprKIq5aCtZ8jCR eZ5rgoikgKz45BrefJBNhHsJ8ASkeMxr62ChxJR4cLHNf7nO+tRf99fK7ZFQ/wAYoEIq NWiRKloMpbUMYYRPuAAN0Pk2vj6nkCGfAOww/BmZcNW4tutpxocuPZU3lTkegFzIkdqv y5qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=iNaeGua52GpCeyqZn2NkyAsepmK+MC0CMzyRiao8GTc=; b=lAN6vRz1310FqNygBiIlzxOjGI1Tvg8Yyi5nbrMIFgrUIjeKGB8b7EsQK4AZLgpOA7 Yi/MFhBOlfmbncHx6K/pOyrQO5NnGGVH0SyceX8B/GPHRW1gDxR4ZeMVNAO7XSuuPda2 +/tK0551omHOIqUcHSSSqJXdv7Ce7aHag7YmvlOT+mBiZIjon93yVW4qE6Fh0gOSmzMK 8a8yfgsdDft38sNHIeDuWpqAQNCCMThk90cm3DkT4CrRFdNc5+XH93G+mJLS0IbWZtHD bKBrqMzjTr/L6PWX99kHhw0gJIzabFPuh9A7qCPx4C739+5D54L8KnH5Eq1UE6aCclDu j9Iw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id e16si1198360wrn.1.2021.01.19.00.25.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jan 2021 00:25:35 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 10J8PYcM030196 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Jan 2021 09:25:34 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.120.228]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 10J8PXsm014546; Tue, 19 Jan 2021 09:25:33 +0100 Date: Tue, 19 Jan 2021 09:25:31 +0100 From: Henning Schild To: Claudius Heine Cc: Silvano Cirujano Cuesta , isar-users@googlegroups.com Subject: Re: image-postproc-extension.bbclass modifying /etc/os-release Message-ID: <20210119092531.2cc80db5@md1za8fc.ad001.siemens.net> In-Reply-To: References: <67e1fac9-5af5-29aa-de57-9a0de0cdd165@siemens.com> <79cdea42-8338-2e7f-33dd-f396db634a14@siemens.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: COXQvlImrMRG Am Mon, 18 Jan 2021 13:35:53 +0100 schrieb Claudius Heine : > Hi Silvano, >=20 > On 2021-01-18 12:35, Silvano Cirujano Cuesta wrote: > > I might try to provide a fix, if we agree that the current > > implementation has an issue. > >=20 > > @Claudius: you wrote the original code [1]. Do you remember why you > > implemented it this way? Do you remember if you were aware of the > > issue I mentioned and you provided a mitigation for the issue that > > I see (assuming my analysis is right)? > >=20 > > [1] > > https://github.com/ilbers/isar/commit/13ce96e5bc84b60f2fa7ccfe93dde0454= 61884e6 > >=20 > > =C2=A0 Silvano > >=20 > > On 15/01/2021 15:26, [ext] Silvano Cirujano Cuesta wrote: =20 > >> Hi, > >> > >> I've noticed that '/etc/os-release' is being changed on the image > >> in meta/classes/image-postproc-extension.bbclass [1].=C2=A0 What BTW > >> ends up changing '/usr/lib/os-release', since it's only a symlink. > >> But both '/etc/os-release' and '/usr/lib/os-release' are owned by > >> 'base-files'... > >> > >> An upgrade of 'base-files' would be replacing (silently, since is > >> not marked as a configuration file) '/usr/lib/os-release' with the > >> version of the upstream 'base-files' package and possibly breaking > >> any tools in the system relying on certain values in that file. > >> > >> Is there a reason that I'm missing for doing so instead of the > >> Debian-way (file diversion with dpkg-divert)? Or any hack that > >> I've overseen that avoids the mentioned breakage? =20 >=20 > Interesting, I didn't remember that `/etc/os-release` is a symlink,=20 > could that be something that has changed in more recent debian > versions? >=20 > If so then, of course that needs to be fixed. the problem seems to be that it is a symlink, otherwise one would assume that changes in /etc/ are allowed and covered by the config file exception and will be subject to merging if an updated package comes around. My guess would be that we need to - make it a copy instead of a symlink - modify it In this case an update of the base-files package should leave it alone or ask for a merge. And i think that would be OK behaviour. Henning > regards, > Claudius >=20